From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 4C60D4C8A for <dev@dpdk.org>; Tue, 19 Jun 2018 15:12:00 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 0AC10B4005A; Tue, 19 Jun 2018 13:11:59 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 19 Jun 2018 14:11:54 +0100 To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon <thomas@monjalon.net> CC: <dev@dpdk.org> References: <20180514155648.81149-1-ferruh.yigit@intel.com> <20180619010457.61490-1-ferruh.yigit@intel.com> <20180619010457.61490-2-ferruh.yigit@intel.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <8b6ead9a-a329-dadc-d523-ab89ff8269ca@solarflare.com> Date: Tue, 19 Jun 2018 16:11:49 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180619010457.61490-2-ferruh.yigit@intel.com> Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23916.003 X-TM-AS-Result: No--7.829500-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1529413919-TgmXd_GUFU2s Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 2/3] ethdev: convert static logtype usage to dynamic X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 19 Jun 2018 13:12:00 -0000 On 06/19/2018 04:04 AM, Ferruh Yigit wrote: > Replace RTE_PMD_DEBUG_TRACE with RTE_ETHDEV_LOG. > > RTE_PMD_DEBUG_TRACE is using hardcoded PMD logtype and ERR log level, > controlled by compile time flags. > RTE_ETHDEV_LOG is using dynamic ethdev_logtype. > > Also a few minor cleanups, like > - use %u for unsigned values like port_id which is uint16_t > - use PRIx64 for owner_id > - Join some log lines > - Unify to not have a "." at the end of the log > - Unify log start with uppercase > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> The patch is too long due to many minor cleanups in one changeset, but I think it is still OK to go. Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>