From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id E62A21AFF for ; Mon, 24 Sep 2018 14:42:26 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2018 05:42:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,298,1534834800"; d="scan'208";a="91410885" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.39]) ([10.237.221.39]) by fmsmga004.fm.intel.com with ESMTP; 24 Sep 2018 05:38:42 -0700 To: Marcin Wojtas Cc: thomas@monjalon.net, =?UTF-8?Q?Tomasz_Duszy=c5=84ski?= , Natalie Samsonov , dev@dpdk.org, Andrzej Ostruszka References: <1536045016-32008-1-git-send-email-tdu@semihalf.com> <1536068953-9352-11-git-send-email-tdu@semihalf.com> <10679582.IxOl8a41ax@xps> <03d2129a-2ceb-a483-cc22-ed354751a13f@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Message-ID: <8b6f2352-9aaa-5243-1a18-5a51e943be65@intel.com> Date: Mon, 24 Sep 2018 13:38:41 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 10/12] net/mvpp2: align documentation with MUSDK 18.09 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Sep 2018 12:42:27 -0000 On 9/24/2018 12:51 PM, Marcin Wojtas wrote: > Hi Ferruh, > > pon., 24 wrz 2018 o 13:38 Ferruh Yigit napisał(a): >> >> On 9/23/2018 11:40 PM, Thomas Monjalon wrote: >>> 19/09/2018 19:15, Ferruh Yigit: >>>> On 9/4/2018 2:49 PM, Tomasz Duszynski wrote: >>>>> From: Natalie Samsonov >>>>> --- a/doc/guides/nics/mvpp2.rst >>>>> +++ b/doc/guides/nics/mvpp2.rst >>>>> - git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.52-armada-17.10 >>>>> + git clone https://github.com/MarvellEmbeddedProcessors/linux-marvell.git -b linux-4.4.120-armada-18.09 >>>> >>>> There is a strict dependency to MUSDK 18.09, dpdk18.11 won't compile with older >>>> versions. It is hard to trace this dependency, what do you think having a matrix >>>> in DPDK documentation showing which DPDK version supports which MUSDK? >>> >>> It does not compile even with MUSDK 18.09. >>> >>> With MUSDK 18.09, the error is: >>> drivers/crypto/mvsam/rte_mrvl_pmd.c:867:26: error: 'SAM_HW_RING_NUM' undeclared >> >> I confirm same error. I wasn't building with crypto PMD enabled so not caught it. >> >>> >>> The explanation is in MUSDK: >>> commit 9bf8b3ca4ddfa00619c0023dfb08ae1601054fce >>> Author: Dmitri Epshtein >>> Date: Mon Nov 20 10:38:31 2017 +0200 >>> >>> sam: remove SAM_HW_RING_NUM from APIs >>> >>> Use function: >>> u32 sam_get_num_cios(u32 inst); >>> >>> As a consequence, next-net cannot be pulled! >> >> Got it, should I drop the patchset from tree? > > We're checking the error and will provide fix asap. Please let know if > this should be another version of the entire patchset or fix on top. There is another comment from Thomas (mvpp2_tm.png). Both "fix on top" and "new version" is OK for me, pick whichever easy for you. For "fix on top", I will squash fixes to original commits, so fixes should be separate patches with a information which commit it targets. But overall build should not be broken, it should be clear in which commit dependency changed to 18.09. Let call the commit that switch happens X, all commits before X should compile successfully with 17.10, commit X and all following commits should be compile successfully with 18.09. > Sorry for the problems. > > Best regards, > Marcin >