From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D4F743266; Thu, 2 Nov 2023 00:40:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8500A40ED8; Thu, 2 Nov 2023 00:39:54 +0100 (CET) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2055.outbound.protection.outlook.com [40.107.93.55]) by mails.dpdk.org (Postfix) with ESMTP id 3730C4027D for ; Thu, 2 Nov 2023 00:39:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BENX/YbH6/FDSgHhsSCvRAze2Zrj7Vjwo5U3Eets9cmMqxwtOEDjFO2lYrl/rErMZMzQxm6bjOYBzURysjt5Pbas/BfH1QNrI3JU4ejkPXN8lR2RGH4dB04QXnELflbQV16wItllsFR9jabh+HTjR+X4Wj3dWIGolzk3K1QdH8CiGIIldyVAnox11PsGj1mhrTQc4hHf9uD5Yu7kG7EH5oJVKCSujHts2y71uRr3MxdzaEwOFcOtslZlzp3sTguz0w3NQcWpMFELJ1zvsafmXaFa7qVbdRWfy0frNNrb1nDkdLn5rNooBrTgtp2LOG7QuWTNdLUKwzZm93q0ceYCEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4OxC+obHeNcRQESv/KEQ/34QjCC+7yJIzcNZILwmWcs=; b=NsEsyjrFxomj4TUZT8s2diTKjI6Ool5bTViDND+ImhYRuf+GYCK8RV2UOICYkkDXzRHDjmckJEC7Cq5Lloih+tdetgZijS5kG2mKxCCJi0sNgoNCWJIi2U1IZtnTjkm5oUdmdTybNvZ//IWc6rY75SWpEpulhPYknl3TqJHg7YxLhapIS45PCjeqCyGMaxbb8pXBQOm3T9CFaIgbbH02x5v7Z40Nx79/AB5glggKXzjieTMiKmB3jRzXEZ0O6Yvr7kAquvQIXKKnMfyw6UpYsW78rE63/vvIgSDe7ejdSmX7mo147jNklohf9RamdRnF+HCRyged+uPAf3RMZZEbvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4OxC+obHeNcRQESv/KEQ/34QjCC+7yJIzcNZILwmWcs=; b=1i/TjV7ckVgqDdMGZBwVLkmbHI6/ofDokKdBuMZiB1rAO7uUY09sDK3HzQbQzZYCysgaZ4ADSozUT72JXsElcek4UEGOYg16aGW1R58fyQ3aUPULYVgKjHnNtFs0zTzt6zUElVyh3p5wYem5nKh4ulLoBfH77kIKWoshNgjBRBU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DS0PR12MB7629.namprd12.prod.outlook.com (2603:10b6:8:13e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.29; Wed, 1 Nov 2023 23:39:50 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.6954.019; Wed, 1 Nov 2023 23:39:50 +0000 Message-ID: <8bac319f-6abd-450d-a103-f8c4db753eb8@amd.com> Date: Wed, 1 Nov 2023 23:39:42 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/2] ethdev: add the check for PTP capability Content-Language: en-US To: Hemant Agrawal , "lihuisong (C)" , "dev@dpdk.org" , Gagandeep Singh Cc: "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "liuyonglong@huawei.com" References: <20220628133959.21381-1-liudongdong3@huawei.com> <20230817084226.55327-1-lihuisong@huawei.com> <1834a6a9-ef92-4a67-a987-490151cf5380@amd.com> <242e8583-969e-d8ca-2dd4-80e8cf73a662@huawei.com> <0d7f429c-8862-4f16-b7e5-46d69581f54f@amd.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0209.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:ad::6) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DS0PR12MB7629:EE_ X-MS-Office365-Filtering-Correlation-Id: affa379b-b238-4b1c-c85b-08dbdb33d728 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ha5By3DQa2XxG1GAeY2fjMjup1SbyjPaUxwt+3292L3FGE/6rJ5iEb5vsEOIc510qY8jeWRaWlaB8I3E79jprLAZIuufEmnnpL0bJ2e8o3EPBFd0kXgB/0raq09OCvnalFCmAXoLRZISJLZZKw5we2+ZQ8rwUOZECtVMqu8ZMFyLsdSW/XHzpwySQ4oL65xyf4cbnZeqERhj0jfVgf+o8P7AcJh3QgWgIYlcwE/wXgLMqZrGS24D8b+CyQlLEL1Q7AgY4hwQ/D4Y2thUam1GhIzYc2UepdztyHVVsXDK0syl/azERl8lUPKqh12osf0fqAIREqe8HWTbNiQ3Cl1vWMmIp6V4UdYxHqtcJSjXt1AAqgp/c1JnwNnznA3/tSW8k83G1wafCGDTJMfU7/QMecq4y6oEpoezue+Kh8oQu8LCkVntyA1OUk6QhYS2yKpCFeWUW6JAgIYVfAavsLma3bKRepAPXnmmfNxP42dCL9nvK67yfroLi9FiCkBXC8wLzRFNf1aIE60GZ207p1YRUrPijZEiOf2Z3rjbCttS0LdU43b4+y/h0oSfp146tOv1ypGPmJ1PqW5Uby1/KGOKJmApN2qm2PE4zbcffkmGwyXmGaghxpy6k5/pM24aBfy0ES0vwhQafefjGZZnqPj65A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(346002)(366004)(39860400002)(136003)(230922051799003)(64100799003)(1800799009)(186009)(451199024)(83380400001)(8676002)(2906002)(44832011)(2616005)(316002)(53546011)(8936002)(5660300002)(41300700001)(38100700002)(26005)(4326008)(54906003)(478600001)(66476007)(110136005)(31696002)(66556008)(6512007)(6486002)(6506007)(66946007)(6666004)(86362001)(36756003)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T3BkaVBQbDhWZWtOZWtuVzVDT0lwbFhSL0NuTWQ4Vnp4N1V6Si9kV0FPZlVs?= =?utf-8?B?cVd5RFpnWlZmRzhQOHlLVHNaRForbzZ5REFwUEZ5S2ZKNWVnMUZUTzNUb3Js?= =?utf-8?B?bzhaTXhFeDY1WU5RUDhBekRpbU1CTDZQRG9KSXpjVmhIbTNEZ0d3dlZwMVBQ?= =?utf-8?B?SUNXOThXa1NYYzZpb1AzVis2bU5nWURNWDRianMzeGU5a1FWdFdyY2thUDBn?= =?utf-8?B?bGNiMFhsS2hySUhvbHBkWjJvbGo2QlhmbXV1NDQyZ2U4dVhKeThIVlhoTklD?= =?utf-8?B?ekhVNXZ5b3lMWURzaDFjdWJTRXltQ1VjMnZPUERvQ2lldG44L2dHQVRNQlAv?= =?utf-8?B?dUdsdTVjeko4WUlpNXVvRllIZExGWkxyK3V3blBobVdFWWtuV0NuVTZpMzFY?= =?utf-8?B?aXBrSG9zS0xUK3Y5ek9TRWdJN002LzF6cWg4TFJzbU14MEp6UVVlaXZXSjF3?= =?utf-8?B?VTl3cS9QTmVMZGxwUWFGSC9VUThycEJlZVJ6bDlFcmswV2I4SGdDMkVPellB?= =?utf-8?B?NTMwaFJVZGhkRlAva1VzQnd3QVhVc0tlZlFSNGhUK2k0bW1peU14SHBBeVhW?= =?utf-8?B?bkFGUzJiTXhzOFVvaDhpUEdueU5EeGl6VHpucE1OR2ZPUzRWWFkwYTUrYnpY?= =?utf-8?B?RVZPSFVReUxrek0xdHh1eGZodVRqbHV0aGRYajNubXAyaXNlYUp0KzV2M1ow?= =?utf-8?B?M24vS2pxcUNYa1g3WnF3ZXlRcFAxUjJlQVV4WmRsUjZZcjBTQ2RLaEhZdnly?= =?utf-8?B?dnpRMmxPTmpyWFErb0JQZTFoOHFWR0RiajNzNmhoS0s0RTMzb0hHYXMvWkE1?= =?utf-8?B?azZERUV0anJSK1crMHRMZGk3VVN4dUYza2o2QUptcjZwZlAvOW1GYXFheGl1?= =?utf-8?B?THFDajd2ZlRPSmJYYTg2VDJZbEozNWZkaDMxZE43T28rK1ZyTkdQaFkvUm1T?= =?utf-8?B?RGRVUFoxaEg1R0RJcFVXY1o5bmloblk2bGxINXRObjJjbzdURjZ3T21hRGJt?= =?utf-8?B?bEdpQnRXUVoxcmtOWjlaWFo5YWhQcnhaeXpIZnZ4L0tBVndQZ0pFV21COVFG?= =?utf-8?B?RVROb1lRK3hiZ3ZkNDI2QnlIWUFMYnQ1bWVEMkVEYUM4VG1DZkpBOXpMMHRO?= =?utf-8?B?NVpvcmNIcURJNU9EQWhqcHgyaHhNdERISXhMZ3FsYXpleEJpTDMwc29paVky?= =?utf-8?B?S2doT2tncUY3aE5sNURmMGVhMGk4QUIvaVRoWm9MVnpBaitqektkOGw0ZWEw?= =?utf-8?B?MUFGWFp0WVZERUd3YlBaMkFyWTRGZUdiK3AxTUQzTTcrNEhrNUJ2Tm95QXpI?= =?utf-8?B?MTJtTHZydGRrOGhFejN0YVY2citmdjNEemFxSld1UkkvNk1Gb1lRdkpiTVNH?= =?utf-8?B?VGRMbUlXRDE2U2pDTTQxNzdWY0RKT25CWFJMcUNCL3dGQTV0UnNDanFwQTRO?= =?utf-8?B?bEFabFFrNDhucTNYREVMUmhOWnFMalM0Vk5WYkI2NmpNUkl4WHJNSm1vdkZq?= =?utf-8?B?SGkzNHVNc0M1bml5MktocXBSVk4ycUZUZTlzZDZ6K0cwRTg5cldJMy9raGRB?= =?utf-8?B?MkFhVmJWaFd5di9wVFg5RlU3dmFpdjg0RFMxakY0ZUdlMW15UVdGWDJERmJ6?= =?utf-8?B?dDV3SWN4dTAxcWRtMElhaHFDaVRBejRBN0ZtUnVOeEVmSGFwdy9oMFlES0Ey?= =?utf-8?B?Y2pENy9RQ1NnL1lSY25VLzBLMmZWaisrMXcxbkpRUWJKSnlscDY5YmdjS0dz?= =?utf-8?B?aHJENXBRLzZDYi9XU0o0TU01bDN4c0txVDR6ODEyVUNyNWExWkF6c2U1UG4x?= =?utf-8?B?bW81WXlEOGZEdFBYamMyRS8wYXBsUE9aMk1KZUNuVUs4QnJRSjZXVW5QcmpI?= =?utf-8?B?MXkzV1hvbTF2VXlEb3ZsSFY1Yms0b0t6elhhVC9pK1BiVGVmNUZna0hvT0dw?= =?utf-8?B?TGFFM0hZMndXOGVsN3lNM21IbzExNlhwM1M4WDQvSnpzdzcxVEJTNjFyOEZ3?= =?utf-8?B?NyswaGNudWpaanlEZEM1ZTRPOWFzM0EvVHZZbXhEa2FTaWZJaGhndDJvZVE1?= =?utf-8?B?OG01b0hNMkVJdGFtSXJLM0xxTitHTFh2ZDExUDhORnlMbUdIMmxDNDFIL0R2?= =?utf-8?Q?fRebnDZYd4TU1iCpo91Jdybdt?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: affa379b-b238-4b1c-c85b-08dbdb33d728 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Nov 2023 23:39:50.4699 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ArcFbSuYvYac4PMQdSr7dHZXnA0QgPRf3e7T9Iz3PD5HU5FZH0haCKX/xJ+Id4E0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7629 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/21/2023 12:17 PM, Hemant Agrawal wrote: > HI Ferruh, > >> On 9/21/2023 11:02 AM, lihuisong (C) wrote: >>> Hi Ferruh, >>> >>> Sorry for my delay reply because of taking a look at all PMDs >>> implementation. >>> >>> >>> 在 2023/9/16 1:46, Ferruh Yigit 写道: >>>> On 8/17/2023 9:42 AM, Huisong Li wrote: >>>>>  From the first version of ptpclient, it seems that this example >>>>> assume that the PMDs support the PTP feature and enable PTP by >>>>> default. Please see commit ab129e9065a5 ("examples/ptpclient: add >>>>> minimal PTP client") which are introduced in 2015. >>>>> >>>>> And two years later, Rx HW timestamp offload was introduced to >>>>> enable or disable PTP feature in HW via rte_eth_rxmode. Please see >>>>> commit 42ffc45aa340 ("ethdev: add Rx HW timestamp capability"). >>>>> >>>> Hi Huisong, >>>> >>>> As far as I know this offload is not for PTP. >>>> PTP and TIMESTAMP are different. >>> If TIMESTAMP offload cannot stand for PTP, we may need to add one new >>> offlaod for PTP. >>> >> >> Can you please detail what is "PTP offload"? >> >>>> >>>> PTP is a protocol for time sync. >>>> Rx TIMESTAMP offload is to ask HW to add timestamp to mbuf. >>> Yes. >>> But a lot of PMDs actually depand on HW to report Rx timestamp >>> releated information because of reading Rx timestamp of PTP SYNC >>> packet in read_rx_timestamp API. >>> >> >> HW support may be required for PTP but this doesn't mean timestamp >> offload is used. > >> >>>> >>>>> And then about four years later, ptpclient enable Rx timestamp >>>>> offload because some PMDs require this offload to enable. Please see >>>>> commit 7a04a4f67dca ("examples/ptpclient: enable Rx timestamp >> offload"). >>>>> >>>> dpaa2 seems using TIMESTAMP offload and PTP together, hence they >>>> updated ptpclient sample to set TIMESTAMP offload. > > [Hemant] In case of dpaa2, we need to enable HW timestamp for PTP. In the current dpaa2 driver > If the code is compiled with, RTE_LIBRTE_IEEE1588, we are enabling the HW timestamp > Otherwise, we are only enabling it when the TIMESTAMP offload is selected. > I think this is reasonable, HW timestamp enabled only when required. > We added patch in ptpclient earlier to pass the timestamp offload, however later we also updated the driver to do it by default. > This part I am not sure, so application request TIMESTAMP offload enable HW timestamp to use it for PTP. There are already 'rte_eth_timesync_enable()' and 'rte_eth_timesync_disable()' functions, and ptpclient sample already uses them, why now utilize these APIs to enable HW timestamp, or other related configuration? > >>> There are many PMDs doing like this, such as ice, igc, cnxk, dpaa2, >>> hns3 and so on. >>> >> >> Can you please point the ice & igc code, cc'ing their maintainers, we can look >> together? >> >> >>>> >>>> We need to clarify dpaa2 usage. >>>> >>>>> By all the records, this is more like a process of perfecting PTP >>>>> feature. >>>>> Not all network adaptors support PTP feature. So adding the check >>>>> for PTP capability in ethdev layer is necessary. >>>>> >>>> Nope, as PTP (IEEE1588/802.1AS) implemented as dev_ops, and ops >>>> already checked, so no additional check is needed. >>> But only having dev_ops about PTP doesn't satisfy the use of this feature. >>> For example, >>> there are serveal network ports belonged to a driver on one OS, and >>> only one port support PTP function. >>> So driver needs one *PTP* offload. >>>> >>>> We just need to clarify TIMESTAMP offload and PTP usage and find out >>>> what is causing confusion. >>> Yes it is a little bit confusion. >>> There are two kinds of implementation: >>> A： ixgbe and txgbe (it seems that their HW is similar) don't need >>> TIMESTAMP offload，and only use dev_ops to finish PTP feature. >>> B:  saving "Rx timestamp related information" from Rx description when >>> receive PTP SYNC packet and >>>     report it in read_rx_timestamp API. >>> For case B, most of driver use TIMESTAMP offload to decide if driver >>> save "Rx timestamp related information. >>> What do you think about this, Ferruh? >>>> I would be great if you can help on clarification, and update >>>> documentation or API comments, or what ever required, for this. >>> ok >>>> >>>>> --- >>>>> v3: >>>>>   - patch [2/3] for hns3 has been applied and so remove it. >>>>>   - ops pointer check is closer to usage. >>>>> >>>>> Huisong Li (2): >>>>>    examples/ptpclient: add the check for PTP capability >>>>>    ethdev: add the check for the valitity of timestamp offload >>>>> >>>>>   examples/ptpclient/ptpclient.c |  5 +++ >>>>>   lib/ethdev/rte_ethdev.c        | 57 >>>>> +++++++++++++++++++++++++++++++++- >>>>>   2 files changed, 61 insertions(+), 1 deletion(-) >>>>> >>>> . >