From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6655A0C56; Mon, 23 Aug 2021 09:55:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9890A40687; Mon, 23 Aug 2021 09:55:06 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 3A1D240143 for ; Mon, 23 Aug 2021 09:55:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="204192961" X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="204192961" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2021 00:55:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,344,1620716400"; d="scan'208";a="473005022" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga008.jf.intel.com with ESMTP; 23 Aug 2021 00:55:04 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 23 Aug 2021 00:55:03 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 23 Aug 2021 00:55:03 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 23 Aug 2021 00:55:03 -0700 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.47) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 23 Aug 2021 00:55:03 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XEhftBtMlA882mJw7vWSECYrIZBGVp93xbMM3LCDEbWBIKuTzWgVmvTFo6XoP0wwGQ5LZyVG/7PESI8YT/DIqywBKsm4egl+2OmO88w7qFPTViA3YthUPzbkmDHQ8mpNk/cK/EhiCcaYvca5Pi5UodZiU5xD1z1NbZWc+jISt3zwVnvvSPs36nKsTCCbimFv+9qLil5UVarIhEmykwQrMQ2Qi+/stirZDV0qXp0XjW0CF/PXXOKpfuSBotEgTASPaRHr3Tmmz6dus7aYBc6bw+l/r9demXmXLjrpTcg4zsQXhx4fK3cMc0tzWF2CO4hrlLlUg0/FwiHcfu31p3uuUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGvfNmjs3/gs/IZC0MTF7kguHV3ItaSnYWywB16w1Vo=; b=P6oEXqsC/9uSgFHlqeu/vlZ55Zkw6rJCq0dots7DPkvpIrjUWE5WbE4LLxtyBD49oeQFt0zuNKEDIXCRxXY9u6DGmEnxLGcOHiIt5jjWJVE3cd+l/wQFjXOdJwNWOL2N91IyEFTMN7Q7Eq94J1vyXO6Uv5KwCgSZNfeJyFP3WlhvcQxPGHOkiul+l7i2wMIwQAElBIK6FJidYHZ0JoNkgPaj7aifjHl4wdZrMOMM/ydQEEZ4hFkY0/U5SfB85i8hR8s3ZVDyRwBeuHQgz7QJ/+uu6HOt3CNfu/WOQLXUrgyUGNk0DpIp38DFv4677EDFsMAOkCC9VWte+U6q6fWFRw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BGvfNmjs3/gs/IZC0MTF7kguHV3ItaSnYWywB16w1Vo=; b=VRGKJC00L7CC/RYZyvyIiQYNYbE0muhHIpQdlWDSMTooKBjTdecJ+nwBhEk+U+nbcCPXT0vPXOJv9XsrY74isancbKQ0ZEC4qHN9iyKsavxm6fdYGBkMb60pP9dz8hRhFvVIhRzQrk6ebyQvoAITuTB8HUjwJuVr1ICPD+Q4h5s= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5144.namprd11.prod.outlook.com (2603:10b6:510:3e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 07:55:00 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%6]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 07:55:00 +0000 To: Stefan Baranoff , References: CC: Jingjing Wu , Beilei Xing , Qi Zhang From: Ferruh Yigit X-User: ferruhy Message-ID: <8bc0d3bc-9956-d964-2ea6-2e834aa0c105@intel.com> Date: Mon, 23 Aug 2021 08:54:55 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB7PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:10:36::42) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DB7PR05CA0029.eurprd05.prod.outlook.com (2603:10a6:10:36::42) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19 via Frontend Transport; Mon, 23 Aug 2021 07:54:59 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e42a2570-0907-4192-22fa-08d9660b4edc X-MS-TrafficTypeDiagnostic: PH0PR11MB5144: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 18So9qoduR+wnE3a+1q36l1Ro7jPubnPqcCPwtIxjRIjiFyvVRSL/0XOEzUnAP6kqxtlmeX7MfaOtmFiUx7DzMq0kabcXnT3Dt5Q9nVGZc2KLrc1rap0To06tdX3XaicHGj9oLGZszupHvNsEmZA5Fob5yAUNmAssy31NFyzCnCAWV7GVp0YRxXOpz237joKWOueRvjVM7Nm9ORQXA14YxD5ejUfurRE0cBxaj7kyS5EiiiWKZLkHBsDaHnFTxnQToERz1ibBeG4731jIILs+k+2+BzATHcwAXzVOoXMaNfkTv7NDFhqaxmSPjtHGNXuAfbttHfTrl93uPg62+8sHrKzxfdePR4aY89zfg9U8BtjLNq+FM14NgjIESkI0YV3Q0woAVcdm96twuyFiUwD++KIceM+duiCqXjusWHuVDHIozmGf+oexDL43t/7o813ZqnRVg+kVjI4+ZxJiCR1xf4TyhXtxtof9KgSapwnpjqn2LODAP5cQnRxbqaSv29T3xddKrFgpIXly9vSkCYczHN/vvhLM/IiV4W514tRbNiQveYr+/vnzvzVOeAm0bKCHyAb/W2iGwBSr1hEVz4gtjzQbNxzj7gvIwjx7wkm5E8AEFSF2AdwK6VejcmeoKtLNM0kdIKgGHyZJZBjl3Ndvqs8mKDFQI8IK+5Q3M1A4BSLLeb/tc7zDqOq6n6Zs5f9wCVHumra10FmEn4RAWfJZQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(54906003)(6666004)(16576012)(4326008)(53546011)(6486002)(31696002)(26005)(4744005)(186003)(38100700002)(44832011)(86362001)(66946007)(66556008)(66476007)(107886003)(2906002)(508600001)(8676002)(8936002)(316002)(31686004)(2616005)(956004)(36756003)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TlFRR1VWVk1DVStJZG1qdUlQWHZTU0I5RFc5eWxQcUF3akFHdXpTSEtjWTR5?= =?utf-8?B?QU1MdmNtQk9EczY5RG0zOW45NUdhZzZhZ3lxM1ZTYXVqMEIwNWFDUmd3Q3Ra?= =?utf-8?B?YTNISm1uYkdjZ0dmYkE2ZjMxeHNjYVpwRUEvTWsvbUVLYVFuOEZEZE90dFB4?= =?utf-8?B?anhDRFdnSkhTY2h4TlJZODRMbWZ5YThRVkdweUVYNWpHOHlaakxDWFduR1Iy?= =?utf-8?B?M2VCTjN0WWJ4QjNEUFJzeHdEN2VkckFGSkE1aWNIb3VpSXc1QUR3SVVLc2NZ?= =?utf-8?B?cFlFTGVIbUkzOXdJT0d5SE1PUnJaeTRscHlwbHhUQmNMSC9KbllqdHU3YU9i?= =?utf-8?B?YTZKcm5xQXY2cnpyOEx5ekk2UHNHNVp0REI3ME5DNXliNHRMZmdHZytnd0Qx?= =?utf-8?B?MVFYWVEwcE1zUExqSDU3Zzh4OUVadHV5NmhmNk1TUFRmRHcrOWZLSThqd29O?= =?utf-8?B?Vzh3MjY0U0NQYjh0K2R1NEs4eWxMMjdTRFJWZEJSa3ZyZUsraThncGk5SUIx?= =?utf-8?B?amVLOHhHUFZOQjI4dEt4V1RoOGtVUEpFS3NZV0taUHVYOW54ZWwwNEtiKzQ5?= =?utf-8?B?aDZ3QXUzdTRMRDdiWGhNZGFNSmRWWGovN2hQc2ZrTWFUaE53Tll1ZVhnekZs?= =?utf-8?B?ZGd1K3FTN3UvUC85NURLNE1nVjFSU3k1MS9EZWtSemVWTHdodE9FajYrS2Vo?= =?utf-8?B?UHp3MU9MVSs5VzVmZzlid3pwNHhUdzlvTUJmQzFPNTY3aTR3QXcwc3lGVG96?= =?utf-8?B?UTRoK3VDeVB5WTNBVEdUa1hxd1JwMzlmK0kzZmJKTU9QQ09PUGlBWVNoN1FF?= =?utf-8?B?VExueDAxUngrbW43WnRQVjNVRk00eC9SK2JjV1prVjZCMHVldkhMS2dVaUJN?= =?utf-8?B?TXBpVmhHQ3J6OEVOZUJjN0plYWl0dGsybHdnR2VFdFcvWXMrVHBRY0hQRGFB?= =?utf-8?B?a05zTjVDTTk1d0JsTzI2cmV5c290U0JaY1BHelh6RlhwUDJ5d3dmUlpNbTI4?= =?utf-8?B?Rk1rOVIrUXpyVHYwTWpTb1EzN2RtQXVKdFBxbnhqcUFma21XOGppWU5NRDV0?= =?utf-8?B?MEdxeFJIbFZXc0hhSzRjUTk0K3JvN0FyZCttT2FkQkdPQnlvUkVXc3JJTDQv?= =?utf-8?B?VUZDb0hIN0RTU3Q5OEJ2TDNDZFpLeXRuYWtuQ3lUQ0E5MFV6U1F6MGpRc2Jx?= =?utf-8?B?cWw2Wm9vajZLdGFoUVNpZFpHQ1ZjOHZOVTRFbEtMNVU2ajc1YVRCNzZtTkhw?= =?utf-8?B?YTRhT29jWmZhOUJaeC8zbXQ2anBRRnlEZ0ZxYU9OWDhCUGZNZk15aWQyNUtq?= =?utf-8?B?SmJOWnJjeWlYSHlZbGFVaFo4bnQ3d2pibk1qQzJqZ2VrcE9pVUcxL3JuWWRs?= =?utf-8?B?clREM3NEUk1WL3NQSzRNODRpTmZldFk2ZmZMUURCUm4zSjZVVFc2V1J6ZHlZ?= =?utf-8?B?U1pydnU4Z0lwL3lpVHRVVXFlSkRDSllPQ3FaYjAzM0RwTzRLNUgyNTVNSVRy?= =?utf-8?B?VkIza1FXenlKYnpOYWNJV0xQQ3ZHVlFCd3hFMk0vSUJNYTNsbHNyTzk2Mmd5?= =?utf-8?B?eXl5TERUV05EMjU4OTZ5clV2dEQrb3pCNGI1UmtmekdBU01OTnJQVC80aU9o?= =?utf-8?B?d1diMWppQjZpUG1uS3dEbGtXNTlXY2poSEZPTmVvaUhpUitnc293SlZjOFds?= =?utf-8?B?WitWSlB0V2kyakxiL3RuK2phN3BiUjNXNGFoQUttSVJLb2gvMmhzZW04amFZ?= =?utf-8?Q?o1ab9WTN7ligh0oEa3CBQSkq8U0RsKp84OrhEN4?= X-MS-Exchange-CrossTenant-Network-Message-Id: e42a2570-0907-4192-22fa-08d9660b4edc X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Aug 2021 07:55:00.7102 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UdaACs3YD00cxmdFCq7bLFxyxzKXvlEqwjigZIpXjPe+X9C9JAqJjC9wGKneviENX2/2wBjcftgjQmsY42vpkQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5144 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] i40evf: potential segfault X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/20/2021 7:18 PM, Stefan Baranoff wrote: > Hi all! > > I was chasing a potential segfault and it appears, if I'm reading this > driver correctly, that in i40evf_init_vf() the value vf->adapter->eth_dev > is never set like pf->adapter->eth_dev is in eth_i40e_dev_init(). > > I believe this is leading to a segfault when something like > i40e_recv_scattered_pkts calls: > dev = I40E_VSI_TO_ETH_DEV(rxq->vsi); // dev ends up NULL here > dev->data->rx_mbuf_alloc_failed++; // this generates a NULL pointer > dereference/segfault > > > I'm not completely confident in my understanding of the PF/VF drivers so I > may be missing something; but we are seeing the segfault on those lines in > v20.05 at least. I couldn't find a related patch/commit but wanted to check > if my reasoning was correct before adding this 1 line fix. > > > Thanks, > Stefan Baranoff > +cc maintainers.