From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EE9FA0C45; Wed, 1 Sep 2021 16:30:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AEE2140140; Wed, 1 Sep 2021 16:30:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id D4C1B4013F for ; Wed, 1 Sep 2021 16:30:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630506599; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RPHnGtvCXqerseGKlxfrhUjZj+e4RF5GeGt264723UU=; b=KLq34q1JiU6021lD316JkFgVPw7i9QjXCPNgKs1yWg5i/ursfEO1BajFLU6KxALp8o7PJZ RsoMghavs9wnQ4rL8cFPtNsA3AW7OAEVn/X48XV2fzEyCAJx+U4BnuAcgXVUCcXkl4nZuU FzB02zSSft/U4KRIyv+wF2aUMxglFI4= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-89-F_CVqO_wMyyvJNflT4Ev1w-1; Wed, 01 Sep 2021 10:29:58 -0400 X-MC-Unique: F_CVqO_wMyyvJNflT4Ev1w-1 Received: by mail-oi1-f200.google.com with SMTP id o185-20020acaf0c20000b029025cacdf2ac0so1432137oih.9 for ; Wed, 01 Sep 2021 07:29:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=RPHnGtvCXqerseGKlxfrhUjZj+e4RF5GeGt264723UU=; b=hqzhxSyHzfNHGftaxS7X1SXyKf79U+GUp8KzdPYEKs/wswpvbt7TXvMqv3c2s3COAC MHmer1cwhV4v7P3Tg88nfq4oCewaGK1p9b1smMZYJHsgPTnrUZ/TtNJOWmBSV95Q0OX3 p8+OD3nSNL3KKbhcl6nfO6si1CT2MfsiFrGqSytxdAfoGe7XbyrqjaKSZa6BrZrS5clD OIs8qXdTbTLfyoAB0ab8ZjMoliDQNS+sYENEZO9NmqAL6XvQduf2kxNkM6zL9V/VR4k4 P+WRBzLtdWHk4ps3DdQPG2aJRAv09n7jhxUsdVDjYL2ZHAxWTtPXjjWxrE7ifdIgA7d7 umBA== X-Gm-Message-State: AOAM5312wuPS3ft8FjXClKJvw7jl+OSFvzwxS1U+lpEQ7XWXM+Vfd9Te 1pa6pjPechIezLtWKUZVrZ1sfwTZtB30nMnzULGfa+nAW45rgJfiy2HohiVdIzk+LAIQwr4EZB4 rpA0= X-Received: by 2002:a05:6808:150c:: with SMTP id u12mr7500455oiw.136.1630506598175; Wed, 01 Sep 2021 07:29:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy/5rAdds+nKWkwyu89+owpdda+bFNLkt8ewkkZ3Y/sTP7kCt0Uej5MBdGIrIaA2fjtnzCjTA== X-Received: by 2002:a05:6808:150c:: with SMTP id u12mr7500437oiw.136.1630506597974; Wed, 01 Sep 2021 07:29:57 -0700 (PDT) Received: from localhost.localdomain (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id i1sm2933oiy.25.2021.09.01.07.29.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Sep 2021 07:29:57 -0700 (PDT) To: Nicolas Chautru , dev@dpdk.org, gakhil@marvell.com Cc: thomas@monjalon.net, hemant.agrawal@nxp.com, mingshan.zhang@intel.com, arun.joshi@intel.com References: <1629407410-28822-1-git-send-email-nicolas.chautru@intel.com> <1629407410-28822-7-git-send-email-nicolas.chautru@intel.com> From: Tom Rix Message-ID: <8bd42e7c-e802-7a15-2d97-dcec97964656@redhat.com> Date: Wed, 1 Sep 2021 07:29:55 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <1629407410-28822-7-git-send-email-nicolas.chautru@intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2 6/6] bbdev: reduce warning level for one scenario X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/19/21 2:10 PM, Nicolas Chautru wrote: > Queue setup may genuinely fail when adding incremental queues > for a given priority level. In that case application would > attempt to configure a queue at a different priority level. > Not an actual error. > > Signed-off-by: Nicolas Chautru > --- > lib/bbdev/rte_bbdev.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c > index fc37236..defddcf 100644 > --- a/lib/bbdev/rte_bbdev.c > +++ b/lib/bbdev/rte_bbdev.c > @@ -528,9 +528,10 @@ struct rte_bbdev * > ret = dev->dev_ops->queue_setup(dev, queue_id, (conf != NULL) ? > conf : &dev_info.default_queue_conf); > if (ret < 0) { > - rte_bbdev_log(ERR, > - "Device %u queue %u setup failed", dev_id, > - queue_id); > + /* This may happen when trying different priority levels */ > + rte_bbdev_log(INFO, > + "Device %u queue %u setup failed", > + dev_id, queue_id); Earlier code tears down the exiting plumbing. If it is ok to fail, should this block move earlier before the teardown ? Tom > return ret; > } >