From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5D9DA0547; Wed, 29 Sep 2021 11:44:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4241C410D7; Wed, 29 Sep 2021 11:44:50 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 2DC2540E3C for ; Wed, 29 Sep 2021 11:44:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10121"; a="223012007" X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="223012007" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Sep 2021 02:44:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,332,1624345200"; d="scan'208";a="617368253" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 29 Sep 2021 02:44:46 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 02:44:46 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 29 Sep 2021 02:44:45 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 29 Sep 2021 02:44:45 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.45) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 29 Sep 2021 02:44:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dY9MzauapEmfE7REk/PAnjYoR59YhpjKiHKeV6CLx+BV9ZTFnkEYI6sfWTOH+jhaQ7E7HdszbDr/FKU2j9OyHSSKGLYxWD8cR3e9jek0MaLm365eV9eTleOAG0Fmw3mIJq0i/mz+W3H0Qpf7pHYm2IMexqUuXOnGsrerWLTkeoltfsoNY2GezZpS/V8CpjAhTPyihFqrHKTuJldI4aQKmb46vu3WXR2RSp6biV/Z5+3oM7BvvfV349wGKCMCe4yCJjRtARb51vD4vI32LZjb23natOE4fmDzfDzP6x2Fe2feSfnZMBrJ/fFXkn4iWWWiWo6PTnNsVXPpoVd3qr5N6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=jxoqJX0+VmO9Ai9frSjw6zYrN4bbpkUyOCmKZqz//nw=; b=i73qwBNQ1EHf7TdPRek/qek05H3X4Qk6YPYD5O+oteqJlYONMTKTU9RX7VEvsoPuHucukUDf97Z1GdU4ySsxEen/RgPqJJAfwGkGahmJE1LP2WvOxbYxXr5DUBJlIvIOMPFUR9y9mKgsOu/Cva+tfzjC2nPcM+HxQckCSr+G7PQkehKn6hChASN2/+yJc39rZpmEvdQacKuxfhJvXxTbE/q2VO/ugMpaNol006kcPlW1e3RDZi1siNUfzHfVpAb5UJqZPprCn1x/YROaolwABc759IFqRufST04GFMEt3Hi8ApTrWn04+coyZXkcmju37IyeA9k6bf150lfV/Wg5mQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jxoqJX0+VmO9Ai9frSjw6zYrN4bbpkUyOCmKZqz//nw=; b=zLThzX1wdTwHXmb52v17eOl2QYGkDteRP4YCDxBkcomaVYNOsHh5lYydBCNKfTlNwPR/aLycwN3OSxkW83x0NveDhR2D/uqSDoY5Iaug4j/PoJottPS87Pqr+8kfm/l04sQUtGMwani6P+ahc5Dlml4qmjsj3WwEynvz2H543Fw= Authentication-Results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5014.namprd11.prod.outlook.com (2603:10b6:510:31::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14; Wed, 29 Sep 2021 09:44:24 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Wed, 29 Sep 2021 09:44:24 +0000 To: Thomas Monjalon , Ajit Khaparde CC: Venkat Duvvuru , dpdk-dev , Kishore Padmanabha , "jerinj@marvell.com" References: <20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com> <043f9e39-222d-975d-d361-f9b27e7a3c74@intel.com> <1971997.DethVJQmbG@thomas> From: Ferruh Yigit X-User: ferruhy Message-ID: <8bea0af2-5713-032c-96db-bbcb0b690cda@intel.com> Date: Wed, 29 Sep 2021 10:44:17 +0100 In-Reply-To: <1971997.DethVJQmbG@thomas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6PR0801CA0044.eurprd08.prod.outlook.com (2603:10a6:4:2b::12) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0801CA0044.eurprd08.prod.outlook.com (2603:10a6:4:2b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.15 via Frontend Transport; Wed, 29 Sep 2021 09:44:22 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cb11a62e-f3a2-4217-7603-08d9832db80a X-MS-TrafficTypeDiagnostic: PH0PR11MB5014: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x0F3gPGjt4k7G+8BKhG0kTQQHNI4pG2EON0bCvU+0WhSYLEmDUrtpFwOxMbVCBMyYSVYS2djg2+ubHn+P6ED3XNOzCFgFB+k/Xkfu6gV+Zuli6S0pdZAUDh/Crw3I4R3mXfNIAGUtwmyCGH/AdLqCvLDGCEssOeZZoaKvEEgtPJ/N8yVIs74rF3nHr1ZWEgfHsBLwR70CG4jYq3EB+vrpj6CVeGvuJFtxXvf7AOsGwnQW9FVHLoQhx2vvs64lSfHtGMeJAy5WtX9puhJlOawgYkbRRGS8DxSqyK6MH/gsUZaAOUQtbGkpOGM9dc/EV9oulokM7k1I2V/zWO+RL3+wb228Dhz12X1y7tymO879Pwohgn0hMb2OVx/Rd9rxkuXEei59KrWueUFRyHC7LfSyDM+q7BVwzmAz/IWp7diT6+0XLbRA+TPcHQN5OKepl6ccMd8yqQUgU/51EhpY7aSD+iQnhGrtscGUspqw1lI4JFzv2FxFvNz4r1xSmDuwirNjos73ze+sooL0D9B8ENgUOaX/RqcSiC1yb1eNMmyoyEVZGot46yGWarf55re855Bz940MOLFc5jyhwF5zh5FUhABCyqtCLu6Yw4azcPbkbnXnDXr5nIv/P6Az1bsDjeNfs+Sa/Wr/guGDbQXeOBqsx5/cdnINjFfwvSzIV0lPETN3QUyf7dRoPMSejpZc71zDC+UO8tHywFkwy0ISoqajg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(8676002)(5660300002)(110136005)(54906003)(6486002)(36756003)(66476007)(66556008)(186003)(2616005)(4326008)(956004)(66946007)(53546011)(16576012)(38100700002)(8936002)(26005)(44832011)(31696002)(83380400001)(31686004)(508600001)(316002)(6666004)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YlRQM1pvaWVTQjFUN1NnRitYYU5zVjk3QzJ4d01RbzF0cEhpTXR0VHBtU0Iz?= =?utf-8?B?c09nYW5ZaHh5ODdNNXFZMktaWjJwL2JOS21oVmQrN05XQXNnQ3RaUkk2WFVD?= =?utf-8?B?WmUzRUFLVXZpMHRMMFByS0ZrdXJGNGdQTGRDUWZUVXBESkV3bkdSUWRFYXlx?= =?utf-8?B?M213K0s0L1Y0OXRrR2VrbnhSOUdTSTM5WEV0WEVHNitJZnNPNEIybjVlWGNK?= =?utf-8?B?Zlh0UlhTUTJVVlNSRTJJbkRpYkhQbEFMZitBSWdIM0lZOUJxQUE5WWFBSms5?= =?utf-8?B?c3RCdXh5cEVVVGhOM0xrUFFiSWQzd0dpTFRHQTB4dWdVWkVBMUVXbVhSRWxm?= =?utf-8?B?OHFYUjE3OVZlNzdwMytMSE00eTJIai9yUTVFUVNvTGdXSkJSaXVjL2Z2RUkw?= =?utf-8?B?cXBFVllyeXZJMkRzU2N1MTVrNFowNUVWLzF6VUhVd3ZoNlVaU0orTG5JRnYy?= =?utf-8?B?bFZhTmV6aXVXOFg4d0g1NHJMQTc2eHZVWkptRVBFcVhRZFovK0U2VWxFaXJG?= =?utf-8?B?MUhWSWN1eVZDbHFrMzNON2I4SEJNZi9sR2REbkl6MVRGVHUxcnBBeU95SmM3?= =?utf-8?B?WU9HUFFUbmRWZzh4eEdNelBNV0xuNVhOM0FZNVVpa09oRVQ2SS9rc013M1Jw?= =?utf-8?B?aVR4MW9yOE9uY0xhUVhjUmVzVlJsb0t2VXdjWVNjaTZ6ZGlLRWNqNFY5ZTk3?= =?utf-8?B?aStKUjJlUXdGT3hsVEhWVExMakZ3dHpSdEZnZks3V2FhQ0RMM3Z2d05xNk9v?= =?utf-8?B?cDN3aWdFL3h0Z0FOdTRPZkZoYmU5K2Y1SjdGNVNFVHlSOVhUTVN1YnBWOVNS?= =?utf-8?B?aUlFbk9aeDdtZ3ZCQWhva01TU1BWK05CanMwOHV5b3Q1N0JsS1Zna0xad1hV?= =?utf-8?B?NzFqWkpWR3hjbmQ2YXZNcG1Tb29YZzBSOXNNbmRtQXN6aFNIL1dWNkh6anVS?= =?utf-8?B?UjVtZ0RzM3doMGlMS3hveWdScjB5czJRbjZndmZTckVOQ3UxUXg5aXlhQ09i?= =?utf-8?B?ZXZ0ZUliT3JmakRpbjJCMGJuaXpFTnhPbHVZcjFiL3g0dVBlb3ZlOUZkQ3VH?= =?utf-8?B?WHJueUlReUh3T2orenhYd3dRRjlvaXB0ZERaNU5LNDBsTkwrMVFlWHVNdCtz?= =?utf-8?B?SUFOamlDTHlFWXcxYWNwcEpCc1MyUTZVRkFFZUVRQzd3T05vbXlRTks0Nitl?= =?utf-8?B?Q3ZtS3lsaW1odUh5OXFhTUhlc1B3Q1A3ZU5udHExeDdzakZMUXpUM1E2RzJ6?= =?utf-8?B?MFBPNE5aNHhsOFgreHRYMXA2c2UyRkdPV0NZNUdRTjdMQ0JBV09xY2dOeXhv?= =?utf-8?B?UUNkNUoxSVB4YzVkVWtKcitZMDhqYU9lb1l5SitkM3R1cW9sSmRZK2c2T29H?= =?utf-8?B?ckZOR0VhNlpSM2lZcEJZeHlsMk9naVFDQ2p6YzE3cGpvd21EY0YxWjAxeS9M?= =?utf-8?B?Vlh2cXNGbHloNzhGaU05SStKaG5PR3ROZzdlTVN5RU1lemlUcjZLVDlzWndD?= =?utf-8?B?V3V5Y0FQU01UdjZxNEVqQ0RLQmdXZStSN1BvQjhYWlhuQ3ZTSWlYOXgzSFFu?= =?utf-8?B?ODZyRmhRdStUb21RM3VkSi8yWUYwSldBRWJVeERxSllnRG00R0hZWWRVaGEx?= =?utf-8?B?ZlVQNStUaEpDZjEwVGo5Y2FDZS83dXRJVm1iQzhsZnRWcFZwdUkvWnVzWHFx?= =?utf-8?B?eEcrNHhRK1JuNm5Xa0ExRDFPMURKaCtFeWloZUIvbU1LdCtiSm1NRXJpUHh3?= =?utf-8?Q?+jpvOIIJjYxBW6yZXmXGbVyLiR9aY9Y3wwpHgkY?= X-MS-Exchange-CrossTenant-Network-Message-Id: cb11a62e-f3a2-4217-7603-08d9832db80a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2021 09:44:23.5549 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vJbk8/Ji7csz47t6k2/5jPLqLim0DgXIJ+vILg3mZUtj0uDgTnIRkNzl8Q2U+57BMQVcd+ykDaQsyu6YVT4ayA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5014 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 06/13] net/bnxt: add support for tunnel offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2021 9:20 AM, Thomas Monjalon wrote: > 28/09/2021 23:32, Ajit Khaparde: >> On Tue, Sep 28, 2021 at 5:43 AM Ferruh Yigit wrote: >>> Following warning is reported by Jerin & Thomas: >>> >>> $ ./devtools/check-doc-vs-code.sh >>> rte_flow doc out of sync for bnxt >>> action shared >>> >>> >>> This is mainly saying 'RTE_FLOW_ACTION_TYPE_SHARED' flow action is supported but >>> not documented. But from code I am not sure if shared action is used, there is >>> only one range check using this enum in the code, can you please clarify? >> >> Correct. RTE_FLOW_ACTION_TYPE_SHARED is being used only for a range check. >> It is not really a supported action right now as far as the code is concerned. >> As of now, no document update is necessary. Thanks > > You need to update something to make the check OK. > If it is a false positive, it can be handled in the script, > but we cannot let the script returning an error. > > I will add following exception to the script (suggested by Thomas) in the next-net: diff --git a/devtools/parse-flow-support.sh b/devtools/parse-flow-support.sh index 8462abe53603..63c0b20e234f 100755 --- a/devtools/parse-flow-support.sh +++ b/devtools/parse-flow-support.sh @@ -25,7 +25,8 @@ exclude() # $dir/tf_ulp/ulp_rte_handler_tbl.c | grep -wo "$1[[:alnum:]_]*" | sort -u | tr '\n' '|' | sed 's,.$,\n,') - grep -vE "$filter";; + exceptions='RTE_FLOW_ACTION_TYPE_SHARED' + grep -vE "$filter" | grep -vE $exceptions;; *) cat esac }