From: Nipun Gupta <nipun.gupta@amd.com>
To: Abhijit Gangurde <abhijit.gangurde@amd.com>, nikhil.agarwal@amd.com
Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@amd.com
Subject: Re: [PATCH] bus/cdx: Remove ineffective code statement
Date: Thu, 15 Jun 2023 15:05:52 +0530 [thread overview]
Message-ID: <8bea71ab-1929-7ff1-07c2-5f51ab04df75@amd.com> (raw)
In-Reply-To: <20230614102201.224495-1-abhijit.gangurde@amd.com>
Acked-by: Nipun Gupta <nipun.gupta@amd.com>
On 6/14/2023 3:52 PM, Abhijit Gangurde wrote:
> ret = 0 statement is ineffective since it is overwritten in a loop.
>
> Coverity issue: 385379
> Fixes: 45ef232af515 ("bus/cdx: introduce AMD CDX bus")
> Signed-off-by: Abhijit Gangurde <abhijit.gangurde@amd.com>
> ---
> drivers/bus/cdx/cdx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/cdx/cdx.c b/drivers/bus/cdx/cdx.c
> index 28bbf92ed5..9130c30515 100644
> --- a/drivers/bus/cdx/cdx.c
> +++ b/drivers/bus/cdx/cdx.c
> @@ -452,7 +452,6 @@ cdx_probe(void)
> dev->name);
> rte_errno = errno;
> failed++;
> - ret = 0;
> }
> }
>
prev parent reply other threads:[~2023-06-15 9:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 10:22 Abhijit Gangurde
2023-06-15 9:35 ` Nipun Gupta [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bea71ab-1929-7ff1-07c2-5f51ab04df75@amd.com \
--to=nipun.gupta@amd.com \
--cc=abhijit.gangurde@amd.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=nikhil.agarwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).