From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 937C0A3168 for ; Wed, 16 Oct 2019 12:16:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 13D1C1E8F9; Wed, 16 Oct 2019 12:16:55 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 34A701E8E0 for ; Wed, 16 Oct 2019 12:16:53 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2019 03:16:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,303,1566889200"; d="scan'208";a="220731343" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by fmsmga004.fm.intel.com with ESMTP; 16 Oct 2019 03:16:48 -0700 To: Jerin Jacob Cc: Andrew Rybchenko , "Yigit, Ferruh" , Thomas Monjalon , John McNamara , Marko Kovacevic , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qi Zhang , Wenzhuo Lu , Rosen Xu , Konstantin Ananyev , Shahaf Shuler , Yongseok Koh , Viacheslav Ovsiienko , Rasesh Mody , Shahed Shaikh , dpdk-dev , David Marchand , Adrien Mazarguil References: <20190730155726.26450-1-thomas@monjalon.net> <8145f03d-0911-91a8-73ee-9febe0c1dbec@linux.intel.com> <06588c18-4931-1328-fafe-73c4c02f5c17@intel.com> <42a41fd3-cfa3-2806-f8c2-b6fff2232aa1@intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <8c147be1-ae63-4b90-57ce-fe2644054b98@intel.com> Date: Wed, 16 Oct 2019 11:16:47 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] doc: remove deprecated ethdev features X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/16/2019 11:08 AM, Jerin Jacob wrote: > > > On Wed, 16 Oct, 2019, 3:32 PM Ferruh Yigit, > wrote: > > On 10/15/2019 5:19 PM, Jerin Jacob wrote: > > On Tue, Oct 15, 2019 at 9:26 PM Ferruh Yigit > wrote: > >> > >> On 10/15/2019 3:16 PM, Jerin Jacob wrote: > >>>>>>> @@ -36,13 +36,6 @@ VMDq                 = > >>>>>>>   SR-IOV               = > >>>>>>>   DCB                  = > >>>>>>>   VLAN filter          = > >>>>>>> -Ethertype filter     = > >>>>>>> -N-tuple filter       = > >>>>>>> -SYN filter           = > >>>>>>> -Tunnel filter        = > >>>>>>> -Flexible filter      = > >>>>>>> -Hash filter          = > >>>>>>> -Flow director        = > >>>>>>>   Flow control         = > >>>>>>>   Flow API             = > >>>>>>>   Rate limitation      = > >>>>>> I suggest adding these features back! > >>>>>> > >>>>>> "Flow director" and other filters are features that device/driver > supports. > >>>>>> > >>>>>> And "Flow API" and "filter_ctrl" are methods used to implement these > features. > >>>>>> Indeed they are only different APIs to get input from application/user. > >>>>>> > >>>>>> It doesn't really mean much to say "Flow API" is supported? So what > is really > >>>>>> supported? It matters more what feature is supported. > >>>>>> > >>>>>> Since we are saying old method is deprecated, we can update the > feature list of > >>>>>> drivers which implements filtering features using old method as not > supported. > >>>>>> And that is the case with this patch since old APIs are marked as > deprecated, > >>>>>> users can't use them to enable a filtering feature. > >>>>>> > >>>>>> Indeed I am for removing the "Flow API" from feature list, first it > is not a > >>>>>> feature, second if it is only method to enable a filtering, and if > filtering is > >>>>>> enabled in a driver, what is the point of redundant "Flow API" listing? > >>>>>> > >>>>>> I can make a quick patch if there is no objection, thanks. > >>>>> > >>>>> As I understand it was a decision to avoid details about flow API support > >>>>> in features matrix. Mainly because matrix would be really huge in > >>>>> attempt to represent it. The question is why filters/patterns mentioned > >>>>> above are better than others and should be mentioned. > >>>>> I'm not against adding some details, just want to understand criteria. > >>>>> Flexible and hash are definitely not well defined. > >>>>> What is flow director and which features should be supported to say yes? > >>>>> > >>> > >>>> > >>>> The criteria I have is what users will be interested about a device/driver. > >>>> > >>>> Will it be really huge to list filtering capabilities of the devices? I > believe > >>>> we can group them into a few groups like above. > >>>> Or at least keep existing one and improve it by time and +1 to clarify > them more > >>>> but that is something else. > >>>> > >>>> A device can have capabilities but it is not easy to find if that > capability has > >>>> been enabled via DPDK, this kind of feature matrix works for it, and all > >>>> features together makes it much easier than digging datasheets and code. > >>>> > >>>> Saying that "Flow API" is enabled for a driver doesn't really gives any > >>>> information to the user if they are interested what kind of filtering > features > >>>> are supported by that device/driver. > >>> > >>> I agree. I think, we need to enumerate rte flow patterns and actions > >>> supported by the PMD. > >>> Since there was no single place such documentation, we added the same > >>> in PMD documentation > >>> See 39.8. RTE Flow Support at > https://doc.dpdk.org/guides/nics/octeontx2.html > >>> > >>> And IMO, We should not add deprecated features in the features matrix as > >>> new PMDs are not planning to implement the deprecated APIs. That > >>> makes, matrix looks > >>> new PMDs do not implement a lot of features, but in reality, those are > >>> deprecated and never planning to implement if even though HW supports it. > >>> > >> > >> +1 to not add deprecated features to the matrix, but those removed ones > [1] are > >> not deprecated. Implementing them via "filter_ctrl" is deprecated. Below > >> features still can be implemented via "Flow API", that is why I am for adding > >> them back to default.ini. > > > > Got it. Instead of [1], Can we document it as in the form of rte_flow > > semantics(patterns and actions) so > > that for the end-user it is very clear. Reason being: > > # Expressing "Tunnel filter" or "N-tupe filter" or "Flexible filter" > > or "Flow director" etc is very vague in rte_flow semantics > > and function is not just limited with above-fixed functions > > #  The new PMDs also can express the rte_flow aka "Flow API" support > > in the rte_flow semantics. > > rte_flow is implementation detail, as well as 'filter_ctrl', I believe listing > rte_flow semantic will be too much detail for the feature table. > > And end user may be interested in features, as if that drive/device support > "Flow Director" or not, instead of rte_flow semantic. > > But I can see feature being vague is also problem, perhaps we can have rte_flow > level details in features.rst file, will it work? > > > > +1 for adding rte_flow level level details in features.rst OK, let me check this > > IMO, Supported packet types(ptype) also good addition in features list. "Packet type parsing" feature is already there, http://lxr.dpdk.org/dpdk/v19.08/source/doc/guides/nics/features/default.ini#L53 If you mean the list of supported types, it is possible to get list on runtime via an API, it will be hard to maintain that list in documentation. > > > > > > > >> And announce them as supported per PMD only if they are implemented via > Flow API. > >> > >> [1] > >>  Ethertype filter     = > >>  N-tuple filter       = > >>  SYN filter           = > >>  Tunnel filter        = > >>  Flexible filter      = > >>  Hash filter          = > >>  Flow director        = >