From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30062.outbound.protection.outlook.com [40.107.3.62]) by dpdk.org (Postfix) with ESMTP id 350621B01C for ; Mon, 29 Jan 2018 08:33:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6xKJz1S9rRwhbCeYQkjMYOp9AMnKXIvbNtFTQ4HIctw=; b=sgrDyQv39IAq2wAGxKkZ7zOh1YS5vXgHIJpmXqi0RdkTN17ro3KD/bcOiOUkJqPbsNFNP43ytAo/fTru11oGZH4kW64xqCF5GSN7oX0oVAY8nDAU8eG/HxIADXXxBiPCSyCPG5xl5/IT0GP6IREpLeKogm5JRnzLyI20f+KwYPw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.49] (192.88.169.1) by DB5PR04MB1383.eurprd04.prod.outlook.com (2a01:111:e400:58da::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.444.14; Mon, 29 Jan 2018 07:33:08 +0000 To: "Nicolau, Radu" , Anoob Joseph Cc: "Doherty, Declan" , "Gonzalez Monroy, Sergio" , Jerin Jacob , Narayana Prasad , Nelio Laranjeiro , "dev@dpdk.org" References: <1516626668-9031-1-git-send-email-anoob.joseph@caviumnetworks.com> <4ab55855-0649-4d68-7b63-b75a6029dbb2@caviumnetworks.com> <763A2F19A5EFF34F8B7F1657C992EE297B31E1D5@IRSMSX104.ger.corp.intel.com> <763A2F19A5EFF34F8B7F1657C992EE297B3202FA@IRSMSX104.ger.corp.intel.com> From: Akhil Goyal Message-ID: <8c1b457a-d6ea-1a56-cd73-385108f8c538@nxp.com> Date: Mon, 29 Jan 2018 13:02:38 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <763A2F19A5EFF34F8B7F1657C992EE297B3202FA@IRSMSX104.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [192.88.169.1] X-ClientProxiedBy: HK2PR02CA0198.apcprd02.prod.outlook.com (2603:1096:201:21::34) To DB5PR04MB1383.eurprd04.prod.outlook.com (2a01:111:e400:58da::17) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6a58f770-5c58-4124-415d-08d566ea8fea X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(2017052603307)(7153060)(7193020); SRVR:DB5PR04MB1383; X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 3:ol6zEL92wf8cAlkeAwn2aC181og6J/EwiFAuFHB4hnbrL9krt5+YmaGzs+fEukS0of3lbHShUwyIb5BWcruJ1+oN1HF2BXZMAolevK22bS0PlXXMNe5cQ2gub+E2E7L3jD/t0Z6Bqhvcc78bgzlFy9Muksw97b7gP74fl60FlFqtcLd3+pyOboGbkKlJ3to2V06rKmp9+Z+mZFLJ3id33EDqfRdS6W5F+36Be60udEkVvyj1dImoiJjQbEMcjdj7; 25:Ot8shteNlF6T7W7GrLyaWZv/gJHXAc02YmDpVrUZhu0OYNbhyaHh5mwpeT67WVfDIZO59w7WXSIqvt51DDMlQj7PWI9GjZvG7LTRsncpupDTPrZPUhVodIkDD1zr94fNgmLsXBVrIququctopXrjWoPLycSyqDYz8oULQkhUEf0p05kk5/zlCWgJhIAT2O/l6gJf2t9RMGSn6dhTnBnJBaQhl0tjUKuypUUcNcXA7YCE/6SO7Lw5E1lUEBOYwIbf8OW/li6yOKm8MNoBZfLGVaQla2lfyPfngCh4RtUftQQoLcgmQQVhsHS1Ba+waQH1J9Wbn1E5NI1UBFkO1I9EOQ==; 31:+Z4/6nslZuIgg1QuooKC/Lei6EKvDYquh0ctZ9Rz5YmjqQEreix0F4WRFivqgrExkkrigv4pumab9NZo8Dyydi8TD2HJoszCc3Hwqa/l/Ox9+LccsYRvsImFsQocZILTY2qpN57coa/PonWxaPplnYAI39GKY2NjsF2xe5w/Ag1nRZaf5wMURpzhXw3Mlg72j+uBNaOP0QWf3ypeA+t+LEX69AYutQuVYM4AMKYrh9g= X-MS-TrafficTypeDiagnostic: DB5PR04MB1383: X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 20:mZ5cpdsn/nCDDJpxIEJRgG+lxkVoYGwUmRRSUCQPcv0DruSDDFqtUkZc6LQGQoDUKKKcUf9mqJG4+iU0fctM8ABJo2d5pFGtToJl2CAJG8K07R4dAsN6zTy1NL2qCE00rdU/+oVtABy/DEopa7BPCou5dApGhWr6TqMnGdAOzVJw4dJe/ZfVdzSbh/+HASiNft6pUz+iwmkhC3pEmg8FuQRcrkfD2xIiLtLQPnd9p+D/WYP/uGB8DE9BQ01JWcrVIG4VQp+b1dJDh9dD3QRrhNf5+4FPGsZtJXqi5mqWW2lOoxwm5qaiktrSpozlwD6CgcDumxf4eMaZhhwrtAYFMS1a9Lk9+WXy1WNQzKIruGHWo8GIdanbhNlukYgDMsovo0rZoTznfsCqBNGMI71APc644dq7f4FsWWyCgxAtiYgtFG2Ol1Gz7bRZxws5/gxQtHzQbkV5jogVA10UznMSWVnV7AsKaw5f0ICVVSemu6vQ9z+Vzwc7hwyRYqh9gT0G; 4:gZtUZmNJ6/624OkLR7YWtTswRkTXTJY0vZMSEUsbZjYbDOgtiYIqATz/hO4NTSiE6FZ+D0oRypQJbLgk6M4dlUGWiyoVYdUYIYqkVDCxkpP5TGWpHpaEs73sUBNYzG1rPvEVKBnPfDCDHXfaqvWW0Saw/euVtRsX2QeJKMnHC/9T58Q+Q2Pd1hQdiqvO2/TExr/qgpegGOq3vR6sI/+DexNznjQH+i6GwIBsWgY/G003MMPTG8tu+XQxnr6CveHetEH+gdQLxckz3auEx+0pJOoFuP33yCrNDeWuttiOMIBbYoCQloTAfB2J7yN8og23gSw0TKVPiEYvk+UgGfG63lUHKzIVoV8wskftsSXcZXcZaXSEbLDfp6mz0zE8zuk8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040501)(2401047)(5005006)(8121501046)(3002001)(3231101)(944501161)(10201501046)(93006095)(93001095)(6055026)(6041288)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:DB5PR04MB1383; BCL:0; PCL:0; RULEID:; SRVR:DB5PR04MB1383; X-Forefront-PRVS: 0567A15835 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(346002)(376002)(39860400002)(39380400002)(366004)(199004)(189003)(13464003)(316002)(58126008)(31696002)(50466002)(76176011)(26005)(65806001)(36756003)(16576012)(53936002)(97736004)(47776003)(53546011)(65956001)(6246003)(110136005)(54906003)(86362001)(66066001)(561944003)(52116002)(305945005)(3846002)(23676004)(52146003)(386003)(16526019)(8936002)(2950100002)(64126003)(229853002)(31686004)(7736002)(83506002)(230700001)(478600001)(6666003)(77096007)(2486003)(93886005)(106356001)(67846002)(6116002)(25786009)(4326008)(5660300001)(68736007)(81156014)(8676002)(81166006)(6486002)(105586002)(186003)(2906002)(65826007)(59450400001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB5PR04MB1383; H:[10.232.134.49]; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjVQUjA0TUIxMzgzOzIzOmpkTUlJckxCUmZxRG0wenlMd2ZQbExMQThp?= =?utf-8?B?N250cTBvK2pHU2hYc3d5bEhVY0VMSStiNXQ0S2hRMXpkRG1uQ29kUW8yWlo4?= =?utf-8?B?NXFGaThnVWhHbUNXcjN5TXhIa2RVczhUU043c2FxTTFIbWFIVWxUMGhuZkYr?= =?utf-8?B?Y3RyZ0hjeU80RHJ0UVZSY2FuWCtTbTFLc1MvZmQ4QTlYanh3dW5QTnVCMWNy?= =?utf-8?B?WVhUdmtCMFlhNlhvYUNRMkVUV2lKUjNycEJlZi9kaEpidUZZUXBpazIwbGhE?= =?utf-8?B?QWFkclpINXZMbWo2d25VNHJoSS9yWWY2MVlZWWxBOVdkTHlhaTByUUZOcDJI?= =?utf-8?B?a1RXRVJJK1dvTWNXS3BXR2lmZEZaSEJBNFlOSVV3RjFrS2F1cHlUY0ZRWkVL?= =?utf-8?B?cWVQbWluU2NXN2Exd2VFbk1NZjRRMXJmSXI5T3JOWWUwN1JWZUpNaXc2L2R0?= =?utf-8?B?NHQ4R29PZUlWMVFvVWpwTitoT1pXMUZ4RThwZEFSZkJJRWZ5MnVmS2JYSjFM?= =?utf-8?B?bktwb251WlZsNE5zZXF3MkFKTE1SWVhhSTJuZGNLT1NsMitRdVh0bHZMa08v?= =?utf-8?B?emJldnIySm1IdEJIZ01qeFQrQlF2Zy9RNzEyNEg1ZEY3RVk0UjhmNzBSUVhP?= =?utf-8?B?ZjBhK2xpYnJKUEltNVFzZHlZeFFDUUEwODZYWHljWDQxNjYxeFFCS2FObDlG?= =?utf-8?B?dmxoaEh0UUs5OXltMmhEYWp3NTBYbTFIZXZZUlFmM2M2K055RkF1QUdNMXVt?= =?utf-8?B?b0pDbVJKSWVHOTJHRy81cm4xNVdiZ29LbFAxVTNMVExWK1Y1T3BqZFROdWVJ?= =?utf-8?B?QjZYN1c3Z3JhWS9YWkViSUFsVEFxcHRudVI5YzErYUlteXZpdEZZZVY1ODNw?= =?utf-8?B?Q1EzMjNHZFBiUzMrL0Q2RVZMclE5MlpwWmZpNnIzUnphdE0zMXROSis5aFdy?= =?utf-8?B?alZpWUREMnlPMjNBcHNnY2JPR1pjWG8zOHFIeWpQOU9HaFRyb2NITjc4SUk1?= =?utf-8?B?eEU0dkdtMTRPVllnNThJNHhRUnRsaGszQWZoclhJY2RNL1ZsMUJ5M2RZRmhv?= =?utf-8?B?NStpVkxIZk9WQ0pVR3N3R1NJYk93UHVDU0w3UkUxNXJIMXUzZWtiWnlmcmNu?= =?utf-8?B?dmtMNmJMcjNSUmQ1QTdFTHVCa0tKVEpyc2FxQ2o1VnpEb3V1ZTNXeWl6S1FJ?= =?utf-8?B?RUF5TXZ4MFBYbGlWRTZWSUN5LzJPNDJBMklHN0tvR3JkU2pBdHdxN3RKTGVy?= =?utf-8?B?cGR5OGtVSFBicWlGK1hCM1BKVEo0Q3AvekpoZndVeXZkZnB3K2NNOXh1cTRh?= =?utf-8?B?ODVKcVVSa1V6VnhpUFJrL2oyZnhhbXB5dW9jNjd1UHlxTnE0VnMxclRDdEph?= =?utf-8?B?eGU3SnowNGlCWHN5ZEljei9JcDJGWERSaTFaMlRWUnllcWIwMUVFandNZTZu?= =?utf-8?B?b3ppWVB5V1A5alRyNzJTbGNFNTBPSEJpNlMvUzhJcTNpMFBIcDd5TFJWNWpr?= =?utf-8?B?ZC8xTk1jTjdDU0IzN2hiaXJuTEd0eHkvNGlLcmNWdzgrSTI1ZmZwcSsyMjR5?= =?utf-8?B?RGRmRDRFaDhUTTZKNEtuYVBVQjJvd1hMYThnZ2pQTnl0RVJ6ZnZNV3NINWNO?= =?utf-8?B?ZW5nMnZHY1UweXV6MFo2TGN3ZEZQcHdxcVFBVUNNZTdmdmQraVhlQjBtcXlO?= =?utf-8?B?Zzc3d09Dakp6OTYyRmxpSUJoTFg0RjFleGcvN2pxV3FzUkJlR1VrWE5wRUxh?= =?utf-8?B?aVNhOFN6VThGYU4yNVdwQVltaEd4NDkzZWNSZUJBZVlRVXZNT0N3bVIyMTY2?= =?utf-8?B?TEN6dXdoTWNvL1ZYaEw4L3dGMDdhQmsyckM0MUlzWENEL2k0c3hZZ1BvVTNp?= =?utf-8?B?L2t5VWZRWVNwdnQyVXNHN29ha0FBUlNyUUVEbVM2SG5tOXYwVk9HV2ZWNVFn?= =?utf-8?B?M2tucWpaaTN2TVdqNTdkdks4dVlUUG9RS0N2OHM2U2h4d2FXc0ZyR0xzTFUr?= =?utf-8?B?eDRhU2dmdGdlUGdPNGtPOGNiUlFzejlhUWpIQT09?= X-Microsoft-Exchange-Diagnostics: 1; DB5PR04MB1383; 6:ncD9S7GDej44zSsIMvlCE+/cpMT6UsB4FiuW9dVAXAc8i8CsEFrHmXvLmjo3tm7MicORxz4tI7wiWJgL+IIqnVjTATIMaGVVhdcGfmFGUhhXaDbWwAIUD9l6ruw1+cPaoToZxIGfKg/AmLRLUxjax4Weer1ZKdpTfaX4eo6OFJhwfnWmqMpedEUbFCPejC9siohqca74ok/PGAAdKwMoJGYHJ7p6buDzmX/60cY27nb5xAF89hV7RhyN/iywWh2NjvBCs6qtSsv2xbuHoarXll4Z+0yesWU5hTnolbik9wcDIcxE9szgfSP9rOA7ZQiwlVZWhtE8a+ma6ZxnPH/3h/zbZe75L3hEaW+Wxt7o0GI=; 5:Pg5zOV/zeBCdKVCxj6e0XGrb1gb8Diu3bLzVSOOkMx85WIbccY7tIpe6qgAShLknfwGOQVxSRjlAWrZVdEdFnN9StwBHekBu0fS1OTcmK0x7otyx2tGqxq9js6koHpYTXsdKn/+2/5dVrXfiyk4te+TfUkvbGjtJgRY7euUzMQs=; 24:N05iYQdVutyJ4BFgKxq982ipEaQfuiv3CUZjz1f3MG/gMJFc/VnKsGrYw+XbJJvkGQjlDnhwJAiN+0zH7+a/JlFeylNyUFnustvNKsLAnJc=; 7:y+etvIZqbND3dyG38tuZsyhr/60UMMv3KrawlzTjC/osh+/vKaqNVA6IYrmPnEilMDkPiksC+AcknKfWopTWXK2bzNwLnme7RydmeDWunsGZTkcLEpq/GWTz3erVdB08ryWZTVkk+CnxE3G/rebYv+CbQF5/mBEyRaWPtPkg2B0F7rjWSskzTepc26phtlOEwjNbWTQuHodlwHB4eRUO2qK0Te+GPLh1K0NOw6hNtRz+oMFWyPWt4T+Ia5cTAcxT SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jan 2018 07:33:08.7226 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a58f770-5c58-4124-415d-08d566ea8fea X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR04MB1383 Subject: Re: [dpdk-dev] [RFC 0/3] set protocol specific metadata using set_pkt_metadata API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Jan 2018 07:33:19 -0000 On 1/26/2018 8:38 PM, Nicolau, Radu wrote: > > >> -----Original Message----- >> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com] >> Sent: Friday, January 26, 2018 2:38 PM >> To: Nicolau, Radu ; Akhil Goyal >> >> Cc: anoob.joseph@caviumnetworks.com; Doherty, Declan >> ; Gonzalez Monroy, Sergio >> ; Jerin Jacob >> ; Narayana Prasad >> ; Nelio Laranjeiro >> ; dev@dpdk.org >> Subject: Re: [RFC 0/3] set protocol specific metadata using set_pkt_metadata >> API >> >> Hi Radu, >> >> On 01/26/2018 04:52 PM, Nicolau, Radu wrote: >>> >>>> -----Original Message----- >>>> From: Anoob Joseph [mailto:anoob.joseph@caviumnetworks.com] >>>> Sent: Thursday, January 25, 2018 5:13 PM >>>> To: Akhil Goyal ; Nicolau, Radu >>>> >>>> Cc: Doherty, Declan ; Gonzalez Monroy, >>>> Sergio ; >>>> anoob.joseph@caviumnetworks.com; Jerin Jacob >>>> ; Narayana Prasad >>>> ; Nelio Laranjeiro >>>> ; dev@dpdk.org >>>> Subject: Re: [RFC 0/3] set protocol specific metadata using >>>> set_pkt_metadata API >>>> >>>> Hi Akhil, Radu, >>>> >>>> Could you review the patch and share your thoughts on the proposed >>>> change? >>>> >>> Hi, >>> >>> I've had a quick look. From what I can see you can do everything you do in >> this patch with the current API. For example you can store an internal struct >> pointer in the private section of the security context and you can increment >> the ESP SN with every tx or set metadata call. >> With the current API, PMD could store the ESN with the security session, but >> there is no means for the application to read this. Application should be >> aware of the sequence number used per packet. This is required to monitor >> sequence number overflow.In the proposal, the sequence number field is >> IN-OUT. So application could either dictate the sequence number, or read >> the value from the PMD. >> >> Thanks, >> Anoob > > My concern is that we are adding too much and too specific to the security API. > Overflow situation can be monitored with a tx callback event or a crypto callback event, depending on the device type. > Agreed with Radu, this looks too specific information. Instead, we can do overflow checking in the driver and add a macro in rte_crypto_op_status for overflow. -Akhil