From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CD12045C22; Fri, 1 Nov 2024 03:26:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3A4E43283; Fri, 1 Nov 2024 03:26:42 +0100 (CET) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 8E96540265 for ; Fri, 1 Nov 2024 03:26:38 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.88.194]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Xfl7C5WmrzlXGS; Fri, 1 Nov 2024 10:24:39 +0800 (CST) Received: from dggemv703-chm.china.huawei.com (unknown [10.3.19.46]) by mail.maildlp.com (Postfix) with ESMTPS id 072061402D0; Fri, 1 Nov 2024 10:26:35 +0800 (CST) Received: from kwepemn100009.china.huawei.com (7.202.194.112) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 1 Nov 2024 10:26:34 +0800 Received: from [10.67.121.59] (10.67.121.59) by kwepemn100009.china.huawei.com (7.202.194.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 1 Nov 2024 10:26:34 +0800 Message-ID: <8c2be190-71d1-20b7-a514-25b0296b38e8@huawei.com> Date: Fri, 1 Nov 2024 10:26:33 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v4 0/7] refactor kvargs test To: Chengwen Feng , , , CC: , References: <20231103095325.47843-1-fengchengwen@huawei.com> <20241030085450.56864-1-fengchengwen@huawei.com> From: "lihuisong (C)" In-Reply-To: <20241030085450.56864-1-fengchengwen@huawei.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemn100009.china.huawei.com (7.202.194.112) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org For this series, Acked-by: Huisong Li 在 2024/10/30 16:54, Chengwen Feng 写道: > When developing patchset [1], I found the kvargs test is hard to > understand when tried to add some testcase. > > So refactor kvargs by: > 1. introduce UT suite framework. > 2. extract big test_valid_kvargs() to five part. > 3. add new introduced rte_kvargs_process_opt() UT. > > [1] https://patchwork.dpdk.org/project/dpdk/cover/20231103073811.13196-1-fengchengwen@huawei.com/ > > Chengwen Feng (7): > app/test: introduce UT suite framework for kvargs > app/test: extract basic token count testcase for kvargs > app/test: extract without keys testcase for kvargs > app/test: extract with keys testcase for kvargs > app/test: extract parse list value testcase for kvargs > app/test: extract parse empty elements testcase for kvargs > app/test: add process opt testcase for kvargs > > --- > v4: remove maintainer commit. > v3: add rte_kvargs_process_opt()'s testcase. > v2: remove copyright line and add Stephen's ack. > > app/test/test_kvargs.c | 326 +++++++++++++++++++++++++---------------- > 1 file changed, 199 insertions(+), 127 deletions(-) >