* [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check
@ 2017-04-11 15:20 Ferruh Yigit
2017-04-13 9:48 ` Ferruh Yigit
2017-04-14 3:52 ` Zhao1, Wei
0 siblings, 2 replies; 6+ messages in thread
From: Ferruh Yigit @ 2017-04-11 15:20 UTC (permalink / raw)
To: Helin Zhang; +Cc: dev, Ferruh Yigit, Wenzhuo Lu, wei.zhao1
Same check duplicated, updated check according what commend states.
Coverity issue: 1407507
Fixes: 11777435c727 ("net/ixgbe: parse flow director filter")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
drivers/net/ixgbe/ixgbe_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c
index e2ba9c2..803d6f8 100644
--- a/drivers/net/ixgbe/ixgbe_flow.c
+++ b/drivers/net/ixgbe/ixgbe_flow.c
@@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr,
index++;
NEXT_ITEM_OF_PATTERN(item, pattern, index);
if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) &&
- (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) {
+ (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) {
memset(rule, 0, sizeof(struct ixgbe_fdir_rule));
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ITEM,
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check 2017-04-11 15:20 [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check Ferruh Yigit @ 2017-04-13 9:48 ` Ferruh Yigit 2017-04-14 3:52 ` Zhao1, Wei 1 sibling, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2017-04-13 9:48 UTC (permalink / raw) To: Helin Zhang, Konstantin Ananyev; +Cc: dev, Wenzhuo Lu, wei.zhao1 On 4/11/2017 4:20 PM, Ferruh Yigit wrote: > Same check duplicated, updated check according what commend states. > > Coverity issue: 1407507 > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Superseded by http://dpdk.org/dev/patchwork/patch/23606/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check 2017-04-11 15:20 [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check Ferruh Yigit 2017-04-13 9:48 ` Ferruh Yigit @ 2017-04-14 3:52 ` Zhao1, Wei 2017-04-14 9:04 ` Ferruh Yigit 2017-04-14 9:08 ` Ferruh Yigit 1 sibling, 2 replies; 6+ messages in thread From: Zhao1, Wei @ 2017-04-14 3:52 UTC (permalink / raw) To: Yigit, Ferruh, Zhang, Helin, Ananyev, Konstantin; +Cc: dev, Lu, Wenzhuo > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, April 11, 2017 11:21 PM > To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com> > Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo > <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > Subject: [PATCH] net/ixgbe: fix duplicated check > > Same check duplicated, updated check according what commend states. > > Coverity issue: 1407507 > Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > drivers/net/ixgbe/ixgbe_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c > index e2ba9c2..803d6f8 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct > rte_flow_attr *attr, > index++; > NEXT_ITEM_OF_PATTERN(item, pattern, index); > if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && > - (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) { > + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { > memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > -- > 2.9.3 Acked-by Wei Zhao<wei.zhao1 @intel.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check 2017-04-14 3:52 ` Zhao1, Wei @ 2017-04-14 9:04 ` Ferruh Yigit 2017-04-14 9:06 ` Zhao1, Wei 2017-04-14 9:08 ` Ferruh Yigit 1 sibling, 1 reply; 6+ messages in thread From: Ferruh Yigit @ 2017-04-14 9:04 UTC (permalink / raw) To: Zhao1, Wei, Zhang, Helin, Ananyev, Konstantin; +Cc: dev, Lu, Wenzhuo On 4/14/2017 4:52 AM, Zhao1, Wei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, April 11, 2017 11:21 PM >> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin >> <konstantin.ananyev@intel.com> >> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo >> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> >> Subject: [PATCH] net/ixgbe: fix duplicated check >> >> Same check duplicated, updated check according what commend states. >> >> Coverity issue: 1407507 >> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") >> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> >> --- >> drivers/net/ixgbe/ixgbe_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c >> index e2ba9c2..803d6f8 100644 >> --- a/drivers/net/ixgbe/ixgbe_flow.c >> +++ b/drivers/net/ixgbe/ixgbe_flow.c >> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct >> rte_flow_attr *attr, >> index++; >> NEXT_ITEM_OF_PATTERN(item, pattern, index); >> if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && >> - (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) { >> + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { >> memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); >> rte_flow_error_set(error, EINVAL, >> RTE_FLOW_ERROR_TYPE_ITEM, >> -- >> 2.9.3 > > Acked-by Wei Zhao<wei.zhao1 @intel.com> OK. So, will continue with this patch, your version [1] marked as rejected. [1] http://dpdk.org/dev/patchwork/patch/23606/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check 2017-04-14 9:04 ` Ferruh Yigit @ 2017-04-14 9:06 ` Zhao1, Wei 0 siblings, 0 replies; 6+ messages in thread From: Zhao1, Wei @ 2017-04-14 9:06 UTC (permalink / raw) To: Yigit, Ferruh, Zhang, Helin, Ananyev, Konstantin; +Cc: dev, Lu, Wenzhuo Ok. > -----Original Message----- > From: Yigit, Ferruh > Sent: Friday, April 14, 2017 5:04 PM > To: Zhao1, Wei <wei.zhao1@intel.com>; Zhang, Helin > <helin.zhang@intel.com>; Ananyev, Konstantin > <konstantin.ananyev@intel.com> > Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com> > Subject: Re: [PATCH] net/ixgbe: fix duplicated check > > On 4/14/2017 4:52 AM, Zhao1, Wei wrote: > > > > > >> -----Original Message----- > >> From: Yigit, Ferruh > >> Sent: Tuesday, April 11, 2017 11:21 PM > >> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin > >> <konstantin.ananyev@intel.com> > >> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo > >> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> > >> Subject: [PATCH] net/ixgbe: fix duplicated check > >> > >> Same check duplicated, updated check according what commend states. > >> > >> Coverity issue: 1407507 > >> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") > >> > >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > >> --- > >> drivers/net/ixgbe/ixgbe_flow.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/drivers/net/ixgbe/ixgbe_flow.c > >> b/drivers/net/ixgbe/ixgbe_flow.c index e2ba9c2..803d6f8 100644 > >> --- a/drivers/net/ixgbe/ixgbe_flow.c > >> +++ b/drivers/net/ixgbe/ixgbe_flow.c > >> @@ -2231,7 +2231,7 @@ ixgbe_parse_fdir_filter_tunnel(const struct > >> rte_flow_attr *attr, > >> index++; > >> NEXT_ITEM_OF_PATTERN(item, pattern, index); > >> if ((item->type != RTE_FLOW_ITEM_TYPE_VLAN) && > >> - (item->type != RTE_FLOW_ITEM_TYPE_VLAN)) { > >> + (item->type != RTE_FLOW_ITEM_TYPE_IPV4)) { > >> memset(rule, 0, sizeof(struct ixgbe_fdir_rule)); > >> rte_flow_error_set(error, EINVAL, > >> RTE_FLOW_ERROR_TYPE_ITEM, > >> -- > >> 2.9.3 > > > > Acked-by Wei Zhao<wei.zhao1 @intel.com> > > OK. > So, will continue with this patch, your version [1] marked as rejected. > > [1] > http://dpdk.org/dev/patchwork/patch/23606/ ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check 2017-04-14 3:52 ` Zhao1, Wei 2017-04-14 9:04 ` Ferruh Yigit @ 2017-04-14 9:08 ` Ferruh Yigit 1 sibling, 0 replies; 6+ messages in thread From: Ferruh Yigit @ 2017-04-14 9:08 UTC (permalink / raw) To: Zhao1, Wei, Zhang, Helin, Ananyev, Konstantin; +Cc: dev, Lu, Wenzhuo On 4/14/2017 4:52 AM, Zhao1, Wei wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Tuesday, April 11, 2017 11:21 PM >> To: Zhang, Helin <helin.zhang@intel.com>; Ananyev, Konstantin >> <konstantin.ananyev@intel.com> >> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo >> <wenzhuo.lu@intel.com>; Zhao1, Wei <wei.zhao1@intel.com> >> Subject: [PATCH] net/ixgbe: fix duplicated check >> >> Same check duplicated, updated check according what commend states. >> >> Coverity issue: 1407507 >> Fixes: 11777435c727 ("net/ixgbe: parse flow director filter") >> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> <...> > Acked-by Wei Zhao<wei.zhao1 @intel.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-04-14 9:08 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2017-04-11 15:20 [dpdk-dev] [PATCH] net/ixgbe: fix duplicated check Ferruh Yigit 2017-04-13 9:48 ` Ferruh Yigit 2017-04-14 3:52 ` Zhao1, Wei 2017-04-14 9:04 ` Ferruh Yigit 2017-04-14 9:06 ` Zhao1, Wei 2017-04-14 9:08 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).