From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
Neil Horman <nhorman@tuxdriver.com>,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Matan Azrad <matan@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate DEFERRED device state
Date: Tue, 20 Nov 2018 11:52:03 +0000 [thread overview]
Message-ID: <8c3c959e-ed94-530f-f69c-34b951d9cb5e@intel.com> (raw)
In-Reply-To: <d8510c04-cfd3-4aae-cc0b-a6fb2542657c@solarflare.com>
On 8/27/2018 4:00 PM, Andrew Rybchenko wrote:
> On 08/24/2018 05:51 PM, Ferruh Yigit wrote:
>> Add a deprecation notice to remove RTE_ETH_DEV_DEFERRED state, but this
>> is mostly a reminder because of a missing target.
>> It doesn't worth to break the ABI because of this change and removal
>> can be done when ethdev ABI version increased.
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>> ---
>> Cc: Thomas Monjalon <thomas@monjalon.net>
>> Cc: Andrew Rybchenko <arybchenko@solarflare.com>
>> Cc: Matan Azrad <matan@mellanox.com>
>> ---
>> doc/guides/rel_notes/deprecation.rst | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index e2dbee317..9cd12ccd8 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -95,3 +95,7 @@ Deprecation Notices
>>
>> This is due to a lack of flexibility and reliance on a type unusable with
>> C++ programs (struct rte_flow_desc).
>> +
>> +* ethdev: remove deprecated RTE_ETH_DEV_DEFERRED device state.
>> + Since this is an enum filed in the middle, removing this field will break
>> + the ABI, so removing postponed to next ethdev ABI version increase.
>
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>
>
In this release we already break the ABI for ethdev, instead of putting this
deprecation notice in, I will send a patch to remove RTE_ETH_DEV_DEFERRED, since
it is not used in current code, it should be trivial and safe change.
next prev parent reply other threads:[~2018-11-20 11:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 14:51 Ferruh Yigit
2018-08-27 15:00 ` Andrew Rybchenko
2018-11-20 11:52 ` Ferruh Yigit [this message]
2018-11-20 12:02 ` [dpdk-dev] [PATCH] ethdev: remove unused " Ferruh Yigit
2018-11-20 14:15 ` Matan Azrad
2018-11-21 15:20 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c3c959e-ed94-530f-f69c-34b951d9cb5e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=matan@mellanox.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).