From: Andrzej Ostruszka <amo@semihalf.com>
To: Arnon Warshavsky <arnon@qwilt.com>,
i.maximets@samsung.com, thomas@monjalon.net,
stephen@networkplumber.org, david.marchand@6wind.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] devtools: move forbidden tokens awk script to a separate file
Date: Fri, 21 Sep 2018 13:37:34 +0200 [thread overview]
Message-ID: <8c7b1bea-526d-65cd-cdd9-6fa135c891a1@semihalf.com> (raw)
In-Reply-To: <1537477900-32682-1-git-send-email-arnon@qwilt.com>
Acked-by: Andrzej Ostruszka <amo@semihalf.com>
However you might consider keeping this comment in the awk script.
On 20.09.2018 23:11, Arnon Warshavsky wrote:
[...]
> @@ -44,85 +44,12 @@ print_usage () {
> }
>
> check_forbidden_additions() {
> - # This awk script receives a list of expressions to monitor
> - # and a list of folders to search these expressions in
> - # - No search is done inside comments
> - # - Both additions and removals of the expressions are checked
> - # A positive balance of additions fails the check
Best regards
Andrzej
next prev parent reply other threads:[~2018-09-21 11:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-20 21:11 Arnon Warshavsky
2018-09-21 11:37 ` Andrzej Ostruszka [this message]
2018-09-23 20:20 ` Arnon Warshavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8c7b1bea-526d-65cd-cdd9-6fa135c891a1@semihalf.com \
--to=amo@semihalf.com \
--cc=arnon@qwilt.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=i.maximets@samsung.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).