From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ktraynor@redhat.com>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id D21BC1B572
for <dev@dpdk.org>; Thu, 25 Apr 2019 11:55:44 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
[10.5.11.12])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 0199E3003AEC;
Thu, 25 Apr 2019 09:55:44 +0000 (UTC)
Received: from [10.36.116.255] (unknown [10.36.116.255])
by smtp.corp.redhat.com (Postfix) with ESMTP id 80E2860BE5;
Thu, 25 Apr 2019 09:55:42 +0000 (UTC)
To: Nikhil Rao <nikhil.rao@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org, jerinj@marvell.com
References: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com>
<1556170955-40555-1-git-send-email-nikhil.rao@intel.com>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <8c8eb58f-23b0-25ee-ce2c-b3d6f2055c70@redhat.com>
Date: Thu, 25 Apr 2019 10:55:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1556170955-40555-1-git-send-email-nikhil.rao@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.45]); Thu, 25 Apr 2019 09:55:44 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v3] eventdev: add experimental tag back
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Apr 2019 09:55:45 -0000
On 25/04/2019 06:42, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback,
> the Rx event callback register and the Rx event adapter statistics
> retrieval functions due to API change to be proposed in a
> future patch.
>
> This patch also adds the experimental tag to these
> function definition and adds the functions to the EXPERIMENTAL
> section of the map file, these were missing previously.
>
> Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
> Cc: jerinj@marvell.com
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>
> v3:
> * add experimental tag to the Rx event adapter stats retrieval function
>
> v2:
> * add patch explanation to commit message
>
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 11 ++++++-----
> lib/librte_eventdev/rte_event_eth_rx_adapter.h | 17 +++++++++++++++--
> lib/librte_eventdev/rte_eventdev_version.map | 8 +++++++-
'Eventdev Ethdev Rx Adapter API' in MAINTAINER should be updated also
> 3 files changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 8d178be..27e0fe7 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -2296,7 +2296,7 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
> return rxa_ctrl(id, 0);
> }
>
> -int
> +int __rte_experimental
> rte_event_eth_rx_adapter_stats_get(uint8_t id,
> struct rte_event_eth_rx_adapter_stats *stats)
I guess if this API is experimental, then the struct should also remain
experimental
> {
> @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
> return rx_adapter->service_inited ? 0 : -ESRCH;
> }
>
> -int rte_event_eth_rx_adapter_cb_register(uint8_t id,
> - uint16_t eth_dev_id,
> - rte_event_eth_rx_adapter_cb_fn cb_fn,
> - void *cb_arg)
> +int __rte_experimental
> +rte_event_eth_rx_adapter_cb_register(uint8_t id,
> + uint16_t eth_dev_id,
> + rte_event_eth_rx_adapter_cb_fn cb_fn,
> + void *cb_arg)
Unrelated indent changes - not sure if they are intentional
> {
> struct rte_event_eth_rx_adapter *rx_adapter;
> struct eth_device_info *dev_info;
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index cf23cde..176f8ca 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -173,6 +173,9 @@ struct rte_event_eth_rx_adapter_queue_conf {
> };
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * A structure used to retrieve statistics for an eth rx adapter instance.
> */
> struct rte_event_eth_rx_adapter_stats {
> @@ -201,6 +204,9 @@ struct rte_event_eth_rx_adapter_stats {
> };
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Callback function invoked by the SW adapter before it continues
> * to process packets. The callback is passed the size of the enqueue
> * buffer in the SW adapter and the occupancy of the buffer. The
> @@ -392,6 +398,9 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,
> int rte_event_eth_rx_adapter_stop(uint8_t id);
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Retrieve statistics for an adapter
> *
> * @param id
> @@ -404,7 +413,8 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,
> * - 0: Success, retrieved successfully.
> * - <0: Error code on failure.
> */
> -int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> +int __rte_experimental
> +rte_event_eth_rx_adapter_stats_get(uint8_t id,
> struct rte_event_eth_rx_adapter_stats *stats);
>
> /**
> @@ -437,6 +447,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Register callback to process Rx packets, this is supported for
> * SW based packet transfers.
> * @see rte_event_eth_rx_cb_fn
> @@ -453,7 +466,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> * - 0: Success
> * - <0: Error code on failure.
> */
> -int
> +int __rte_experimental
> rte_event_eth_rx_adapter_cb_register(uint8_t id,
> uint16_t eth_dev_id,
> rte_event_eth_rx_adapter_cb_fn cb_fn,
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 88c3ce5..55c56e3 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -63,7 +63,6 @@ DPDK_17.11 {
> rte_event_eth_rx_adapter_queue_del;
> rte_event_eth_rx_adapter_service_id_get;
> rte_event_eth_rx_adapter_start;
> - rte_event_eth_rx_adapter_stats_get;
> rte_event_eth_rx_adapter_stats_reset;
> rte_event_eth_rx_adapter_stop;
> } DPDK_17.08;
> @@ -124,3 +123,10 @@ DPDK_19.05 {
> rte_event_timer_arm_tmo_tick_burst;
> rte_event_timer_cancel_burst;
> } DPDK_18.05;
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_event_eth_rx_adapter_cb_register;
As per Jerin's comment, it needs to be removed from 19.05 section also
> + rte_event_eth_rx_adapter_stats_get;
> +};
>
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id 582FAA05D3
for <public@inbox.dpdk.org>; Thu, 25 Apr 2019 11:55:48 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id A09891B579;
Thu, 25 Apr 2019 11:55:46 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
by dpdk.org (Postfix) with ESMTP id D21BC1B572
for <dev@dpdk.org>; Thu, 25 Apr 2019 11:55:44 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com
[10.5.11.12])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mx1.redhat.com (Postfix) with ESMTPS id 0199E3003AEC;
Thu, 25 Apr 2019 09:55:44 +0000 (UTC)
Received: from [10.36.116.255] (unknown [10.36.116.255])
by smtp.corp.redhat.com (Postfix) with ESMTP id 80E2860BE5;
Thu, 25 Apr 2019 09:55:42 +0000 (UTC)
To: Nikhil Rao <nikhil.rao@intel.com>, thomas@monjalon.net
Cc: dev@dpdk.org, jerinj@marvell.com
References: <1555998614-35566-1-git-send-email-nikhil.rao@intel.com>
<1556170955-40555-1-git-send-email-nikhil.rao@intel.com>
From: Kevin Traynor <ktraynor@redhat.com>
Message-ID: <8c8eb58f-23b0-25ee-ce2c-b3d6f2055c70@redhat.com>
Date: Thu, 25 Apr 2019 10:55:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <1556170955-40555-1-git-send-email-nikhil.rao@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
(mx1.redhat.com [10.5.110.45]); Thu, 25 Apr 2019 09:55:44 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH v3] eventdev: add experimental tag back
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190425095541.JYYkcras3q1J0bqkxhm3gqQ_7yhwsNjVBngCkbV5l6A@z>
On 25/04/2019 06:42, Nikhil Rao wrote:
> Add the experimental tag back to the Rx event adapter callback,
> the Rx event callback register and the Rx event adapter statistics
> retrieval functions due to API change to be proposed in a
> future patch.
>
> This patch also adds the experimental tag to these
> function definition and adds the functions to the EXPERIMENTAL
> section of the map file, these were missing previously.
>
> Fixes: 80bdf91dc8ee ("eventdev: promote adapter functions as stable")
> Cc: jerinj@marvell.com
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>
> v3:
> * add experimental tag to the Rx event adapter stats retrieval function
>
> v2:
> * add patch explanation to commit message
>
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 11 ++++++-----
> lib/librte_eventdev/rte_event_eth_rx_adapter.h | 17 +++++++++++++++--
> lib/librte_eventdev/rte_eventdev_version.map | 8 +++++++-
'Eventdev Ethdev Rx Adapter API' in MAINTAINER should be updated also
> 3 files changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 8d178be..27e0fe7 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -2296,7 +2296,7 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
> return rxa_ctrl(id, 0);
> }
>
> -int
> +int __rte_experimental
> rte_event_eth_rx_adapter_stats_get(uint8_t id,
> struct rte_event_eth_rx_adapter_stats *stats)
I guess if this API is experimental, then the struct should also remain
experimental
> {
> @@ -2383,10 +2383,11 @@ static int rxa_sw_add(struct rte_event_eth_rx_adapter *rx_adapter,
> return rx_adapter->service_inited ? 0 : -ESRCH;
> }
>
> -int rte_event_eth_rx_adapter_cb_register(uint8_t id,
> - uint16_t eth_dev_id,
> - rte_event_eth_rx_adapter_cb_fn cb_fn,
> - void *cb_arg)
> +int __rte_experimental
> +rte_event_eth_rx_adapter_cb_register(uint8_t id,
> + uint16_t eth_dev_id,
> + rte_event_eth_rx_adapter_cb_fn cb_fn,
> + void *cb_arg)
Unrelated indent changes - not sure if they are intentional
> {
> struct rte_event_eth_rx_adapter *rx_adapter;
> struct eth_device_info *dev_info;
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.h b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> index cf23cde..176f8ca 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.h
> @@ -173,6 +173,9 @@ struct rte_event_eth_rx_adapter_queue_conf {
> };
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * A structure used to retrieve statistics for an eth rx adapter instance.
> */
> struct rte_event_eth_rx_adapter_stats {
> @@ -201,6 +204,9 @@ struct rte_event_eth_rx_adapter_stats {
> };
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Callback function invoked by the SW adapter before it continues
> * to process packets. The callback is passed the size of the enqueue
> * buffer in the SW adapter and the occupancy of the buffer. The
> @@ -392,6 +398,9 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,
> int rte_event_eth_rx_adapter_stop(uint8_t id);
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Retrieve statistics for an adapter
> *
> * @param id
> @@ -404,7 +413,8 @@ int rte_event_eth_rx_adapter_queue_del(uint8_t id, uint16_t eth_dev_id,
> * - 0: Success, retrieved successfully.
> * - <0: Error code on failure.
> */
> -int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> +int __rte_experimental
> +rte_event_eth_rx_adapter_stats_get(uint8_t id,
> struct rte_event_eth_rx_adapter_stats *stats);
>
> /**
> @@ -437,6 +447,9 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> int rte_event_eth_rx_adapter_service_id_get(uint8_t id, uint32_t *service_id);
>
> /**
> + * @warning
> + * @b EXPERIMENTAL: this API may change without prior notice
> + *
> * Register callback to process Rx packets, this is supported for
> * SW based packet transfers.
> * @see rte_event_eth_rx_cb_fn
> @@ -453,7 +466,7 @@ int rte_event_eth_rx_adapter_stats_get(uint8_t id,
> * - 0: Success
> * - <0: Error code on failure.
> */
> -int
> +int __rte_experimental
> rte_event_eth_rx_adapter_cb_register(uint8_t id,
> uint16_t eth_dev_id,
> rte_event_eth_rx_adapter_cb_fn cb_fn,
> diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map
> index 88c3ce5..55c56e3 100644
> --- a/lib/librte_eventdev/rte_eventdev_version.map
> +++ b/lib/librte_eventdev/rte_eventdev_version.map
> @@ -63,7 +63,6 @@ DPDK_17.11 {
> rte_event_eth_rx_adapter_queue_del;
> rte_event_eth_rx_adapter_service_id_get;
> rte_event_eth_rx_adapter_start;
> - rte_event_eth_rx_adapter_stats_get;
> rte_event_eth_rx_adapter_stats_reset;
> rte_event_eth_rx_adapter_stop;
> } DPDK_17.08;
> @@ -124,3 +123,10 @@ DPDK_19.05 {
> rte_event_timer_arm_tmo_tick_burst;
> rte_event_timer_cancel_burst;
> } DPDK_18.05;
> +
> +EXPERIMENTAL {
> + global:
> +
> + rte_event_eth_rx_adapter_cb_register;
As per Jerin's comment, it needs to be removed from 19.05 section also
> + rte_event_eth_rx_adapter_stats_get;
> +};
>