From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C86EA0547; Mon, 21 Jun 2021 05:08:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A99A040040; Mon, 21 Jun 2021 05:08:03 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id D260E4003F; Mon, 21 Jun 2021 05:08:01 +0200 (CEST) IronPort-SDR: oWg4vRn5caks748VNc5sSwNM9RCw7S2EKhYcaPQc5Oy/eNPbvcEx3owJJA9vluq00L0CRQJ3As WILrHVUZJmBA== X-IronPort-AV: E=McAfee;i="6200,9189,10021"; a="206808863" X-IronPort-AV: E=Sophos;i="5.83,288,1616482800"; d="scan'208";a="206808863" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2021 20:08:00 -0700 IronPort-SDR: r7tGki8jo3x6M0TUAWV+5ZMumnerGLTk7Gqju8mOsKt7IEB8MENxxErSUVePdZGYvH6nlDY4Hm oJ6KZVYf6d3Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,288,1616482800"; d="scan'208";a="556105401" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 20 Jun 2021 20:08:00 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Sun, 20 Jun 2021 20:07:59 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 21 Jun 2021 11:07:57 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2242.008; Mon, 21 Jun 2021 11:07:57 +0800 From: "Zhang, Qi Z" To: "Yu, DapengX" , "Xing, Beilei" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix data path corrupt on secondary process Thread-Index: AQHXXP3fwKBrOEXqQEyJuniRV8wYKKsd2j3A Date: Mon, 21 Jun 2021 03:07:57 +0000 Message-ID: <8cafbee3b1504094a88a309f5302f1d8@intel.com> References: <20210609070537.2714889-1-dapengx.yu@intel.com> In-Reply-To: <20210609070537.2714889-1-dapengx.yu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix data path corrupt on secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yu, DapengX > Sent: Wednesday, June 9, 2021 3:06 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; Yu, DapengX > ; stable@dpdk.org > Subject: [PATCH] net/i40e: fix data path corrupt on secondary process >=20 > From: Dapeng Yu >=20 > The rte_eth_devices array is not in share memory, it should not be refere= nced > by i40e_adapter which is shared by primary and secondary. > Any process set i40e_adapter->eth_dev will corrupt another process' > context. >=20 > The patch removed the field "eth_dev" from i40e_adapter. > Now, when the data paths try to access the rte_eth_dev_data instance, the= y > should replace adapter->eth_dev->data with adapter->pf.dev_data. >=20 > Fixes: 2bedd7277a10 ("net/i40e: print real global changes") > Fixes: 4861cde46116 ("i40e: new poll mode driver") > Fixes: be6c228d4da3 ("i40e: support Rx interrupt") > Fixes: 8e109464c022 ("i40e: allow vector Rx and Tx usage") > Fixes: 1d169e9dafb8 ("net/i40e: support cloud filter with L4 port") > Fixes: a778a1fa2e4e ("i40e: set up and initialize flow director") > Fixes: 460d1679586e ("drivers/net: delete HW rings while freeing queues") > Fixes: b0ea2716e05b ("net/i40e: add flow flush function") > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") > Fixes: 819a5c14d1dd ("net/i40e: fix null checks") > Fixes: e0cb96204b71 ("net/i40e: add support for representor ports") Just need to list the patch that bring the issue (in this case it is the on= e that add a non-shared point into a structure that will be shared) , all following up patches are not guilty. > Cc: stable@dpdk.org >=20 > Signed-off-by: Dapeng Yu