From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6460E2946 for ; Thu, 5 Jan 2017 15:24:00 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 05 Jan 2017 06:23:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,321,1477983600"; d="scan'208";a="1090276276" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by fmsmga001.fm.intel.com with ESMTP; 05 Jan 2017 06:23:58 -0800 To: nickcooper-zhangtonghao , dev@dpdk.org, Yong Wang References: <1483617709-7088-1-git-send-email-nic@opencloud.tech> From: Ferruh Yigit Message-ID: <8cb35df0-cdd6-143c-4f78-379a89f44616@intel.com> Date: Thu, 5 Jan 2017 14:23:57 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1483617709-7088-1-git-send-email-nic@opencloud.tech> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2017 14:24:00 -0000 On 1/5/2017 12:01 PM, nickcooper-zhangtonghao wrote: > The NUMA node information for PCI devices provided through > sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > > Signed-off-by: nickcooper-zhangtonghao Hi nickcooper-zhangtonghao, The patches in the patchset are individual patches, right? Is there any dependency between them? And CC'ed vmxnet3 driver maintainer: Yong Wang Thanks, ferruh > --- > lib/librte_eal/linuxapp/eal/eal_pci.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_pci.c b/lib/librte_eal/linuxapp/eal/eal_pci.c > index 4350134..5dfdbe9 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_pci.c > +++ b/lib/librte_eal/linuxapp/eal/eal_pci.c > @@ -317,7 +317,13 @@ > free(dev); > return -1; > } > - dev->device.numa_node = tmp; > + /* The NUMA node information for PCI devices provided through > + * sysfs is invalid for AMD Opteron(TM) Processor 62xx and 63xx > + * on Red Hat Enterprise Linux 6, and VMs on some hypervisors. > + * In the upstream linux kernel, the numa_node is an integer, > + * which data type is int, not unsigned long. > + */ > + dev->device.numa_node = (int)tmp > 0 ? (int)tmp : 0; > } > > /* parse resources */ >