Re: [dpdk-dev] [PATCH 5/8] net/mrvl: add classifier support

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 3/7/2018 11:16 AM, Tomasz Duszynski wrote:
> On Wed, Mar 07, 2018 at 11:07:14AM +0000, Ferruh Yigit wrote:
>> On 2/21/2018 2:14 PM, Tomasz Duszynski wrote:
>>> Add classifier configuration support via rte_flow api.
>>>
>>> Signed-off-by: Natalie Samsonov <nsamsono@marvell.com>
>>> Signed-off-by: Tomasz Duszynski <tdu@semihalf.com>
>>> ---
>>>  doc/guides/nics/mrvl.rst       |  168 +++
>>>  drivers/net/mrvl/Makefile      |    1 +
>>>  drivers/net/mrvl/mrvl_ethdev.c |   59 +
>>>  drivers/net/mrvl/mrvl_ethdev.h |   10 +
>>>  drivers/net/mrvl/mrvl_flow.c   | 2787 ++++++++++++++++++++++++++++++++++++++++
>>>  5 files changed, 3025 insertions(+)
>>>  create mode 100644 drivers/net/mrvl/mrvl_flow.c
>>
>> <...>
>>
>>> diff --git a/drivers/net/mrvl/mrvl_flow.c b/drivers/net/mrvl/mrvl_flow.c
>>> new file mode 100644
>>> index 0000000..a2c25e6
>>> --- /dev/null
>>> +++ b/drivers/net/mrvl/mrvl_flow.c
>>> @@ -0,0 +1,2787 @@
>>> +/*-
>>> + *   BSD LICENSE
>>> + *
>>> + *   Copyright(c) 2018 Marvell International Ltd.
>>> + *   Copyright(c) 2018 Semihalf.
>>> + *   All rights reserved.
>>> + *
>>> + *   Redistribution and use in source and binary forms, with or without
>>> + *   modification, are permitted provided that the following conditions
>>> + *   are met:
>>> + *
>>> + *     * Redistributions of source code must retain the above copyright
>>> + *       notice, this list of conditions and the following disclaimer.
>>> + *     * Redistributions in binary form must reproduce the above copyright
>>> + *       notice, this list of conditions and the following disclaimer in
>>> + *       the documentation and/or other materials provided with the
>>> + *       distribution.
>>> + *     * Neither the name of the copyright holder nor the names of its
>>> + *       contributors may be used to endorse or promote products derived
>>> + *       from this software without specific prior written permission.
>>> + *
>>> + *   THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
>>> + *   "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
>>> + *   LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
>>> + *   A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
>>> + *   OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
>>> + *   SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
>>> + *   LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
>>> + *   DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
>>> + *   THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>>> + *   (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
>>> + *   OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>>> + */
>>
>> Can you please use SPDX licensing tags for new files?
>>
>> And marvell PMD seems not switched to SPDX tags yet, can you please plan the switch?
> 
> SPDX conversion patches are waiting for submission. Once Marvell
> gives final approval they will be pushed out.

Good, thank you. Will it be possible to send this set with SPDX license?

> 
>>
>> Thanks,
>> ferruh
> 
> --
> - Tomasz Duszyński
>