From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id A514A23C for ; Wed, 28 Feb 2018 11:21:43 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Feb 2018 02:21:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,405,1515484800"; d="scan'208";a="178698996" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.78]) ([10.237.220.78]) by orsmga004.jf.intel.com with ESMTP; 28 Feb 2018 02:21:41 -0800 To: "Tan, Jianfeng" , "dev@dpdk.org" References: <31f6d9ef676fb1eb0a664c06d62d66f32876dcb6.1519672713.git.anatoly.burakov@intel.com> <2f9a4da56e7f31f141db8cb2bb34d3c7fef97691.1519740527.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" Message-ID: <8cc51c18-9999-642c-f8e3-3b3834104cc3@intel.com> Date: Wed, 28 Feb 2018 10:21:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Feb 2018 10:21:44 -0000 On 28-Feb-18 1:52 AM, Tan, Jianfeng wrote: > Hi Anatoly, > >> -----Original Message----- >> From: Burakov, Anatoly >> Sent: Tuesday, February 27, 2018 10:36 PM >> To: dev@dpdk.org >> Cc: Tan, Jianfeng >> Subject: [PATCH v3 5/5] eal: don't hardcode socket filter value in IPC >> >> Currently, filter value is hardcoded and disconnected from actual >> value returned by eal_mp_socket_path(). > > I can understand the hardcode is not good. But why it's not consistent with the actual value returned from eal_mp_socket_path()? It is consistent. It's just that it's disconnected from the value returned by eal_mp_socket_path(). Meaning, if you change how eal_mp_socket_path() works, you'll also have to update the filter (or you may forget to do it and have a bug). This patch makes it so that mp_filter value is automatically updated, should you change internal workings of eal_mp_socket_path(). > >> Fix this to generate filter >> value by deriving it from eal_mp_socket_path() instead. >> >> Signed-off-by: Anatoly Burakov > > Anyway, I think your way looks good to me, so > > Acked-by: Jianfeng Tan > > Thanks, > Jianfeng > -- Thanks, Anatoly