From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A16D842D2F; Fri, 23 Jun 2023 15:32:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 341AC40ED7; Fri, 23 Jun 2023 15:32:55 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2063.outbound.protection.outlook.com [40.107.237.63]) by mails.dpdk.org (Postfix) with ESMTP id 6DC02406B8 for ; Fri, 23 Jun 2023 15:32:54 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nL5k5I9DF+sIBXVQP2w+XIxUOgQj9wpbVnY4fSz3Q0G19sziC+Nb4QAa8KKVg6En4xHGRTe3N8DBCkJ6+GTqads99wK4kB7amTAImm5eAvAtlGyFsWTeNE5VNl+fWWCDl9OhlgVweB7tqEWjIN07Wh0cDMVHTW82yr+m4RvoWKIvocuzT9a/s7ZP1gNJ3KL6kpNm4bXecc7Ip0sNm1NEYrxUjXMTl12bsOcnyB/fdFysC6aL7vOts0+9qYme3kfgiUnLM2iwMl7LboB09gRijDsLkkYnb4YHZs2NTqAXEqSOd9chIZgd0IBiUyzGWsIVrhrOFCm77zS5UNnv55iaAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ifzs+3ia+4MOpYaT9aT29vmqUzErMcfZkgQVlgt807E=; b=RCGH5boyp2mDuyYO/cPAP10my4AixpW82dG8/Kqg+fP4JE24q4krIYU8ml9jPvCR9oypg9Sndn/1ClgHpMzJdx0WzWaeEnYYZzlmBUlSpUKVLKow+sJELndGREF4+H784Yau+5ycEPXITlQM3nsbHvsBcwt7IWF+elFrxs5Msoly3Bdtt8kDN8R8RHQXxpCMAyW8oistmzuz7jLxPpJ+/RkWhnDk7/TYUJqTtrqqIGrDghToVGNf6aXDQdkrabwGYqcBzM6PxBKkyYQ/+YuM9bF3+XEhj/yvYP3rmCEbQRjbCYtzATPqt5/pXLBM7KzXkeNdDg4kysgxeLDRpF36og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ifzs+3ia+4MOpYaT9aT29vmqUzErMcfZkgQVlgt807E=; b=AN8QJYqcpuDlIddnIzTLbIi5VS05gVBG/XArZHbz4p82O7NmpS9fCKPqhnRW/MdIp9hEeWkPcFsBLR6NN7CoWyX3kKRcuq8orqS6J2hNOLvLJdRojHWQHlHl91710nGDWCDR/VSKJ9qeHDovLE2nUWCK8FGX7DwEIvDUy5gDgyg= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA3PR12MB8021.namprd12.prod.outlook.com (2603:10b6:806:305::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.23; Fri, 23 Jun 2023 13:32:52 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6521.024; Fri, 23 Jun 2023 13:32:52 +0000 Message-ID: <8cce799c-3c71-4aa3-e600-3f85dce14692@amd.com> Date: Fri, 23 Jun 2023 14:32:45 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Chaoyong He , Chas Williams , "Min Hu (Connor)" Cc: oss-drivers , Niklas Soderlund , "dev@dpdk.org" , Aman Singh , Thomas Monjalon References: <20230216083231.4721-1-chaoyong.he@corigine.com> <20230301024826.885727-1-chaoyong.he@corigine.com> <470f085b-d479-4ea8-abdb-0de483439d13@amd.com> From: Ferruh Yigit Subject: Re: [PATCH v3 0/2] enhance bonding PMD to support the LACP negotiation In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0213.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::20) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA3PR12MB8021:EE_ X-MS-Office365-Filtering-Correlation-Id: 7b52191f-d12c-4f99-faab-08db73ee57e2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PGm6gNmE3VzAy8C71w4bM6jFebXj4jx8NXN+EXwLu3cvYQjDe2J1OOVPEMnk27m63jRQb4plYFFVQa/+j4RKNIrWLfNkD0rQ9fda+aJ4fDilrvSERz5dCW12ZYUrHDfVtoPMs2up0O9Bn4TuI1bRLQLGHVFbRgfr+N6VkserQs80NmAL0LNq6jpihB3YCwpYtIyb+j8goatuYdW04e5q+CLdyA1iQpa/P3VgKd+wQ4qmtJAiiNwtFlYUPp7QSrjLTZdHR9iqX3HdOwzIs6OxtvgWMrgiW2p9gQxV96wZHw9UbxAN/yrdMlIF8Db9oMNWvJtn4t7t5/AWsjkRjMaEfYA59HL3UhqkyRiJ+v5NLvNQMFRg1FiP0NcRm364gZlFOlYKtgLzv9Xmm4bqdSYABuVq7yZ4ZdIwzPFmfX/R12dB0eYSJqIwD0Axr17nKLXg4+6AFLt7Hx5s8aD0QNofZ7oUPfF9Tb1D1EN4fnGsYq9Z6CNf063ApJESfaMr+Ph0xmBpL0S+wfeG62uqsbJLyga9QtknDIX9ZiYvyH3uhF3MUtxl5y2LhHx1Kr/z6gj/aC4S6a5NHu5YIbBB9Mc7t2oBDuXQHrP8PzYGUFq3kIFMJCejyNKQSTNLLVSWW+fqMDexP6deALmxeySQecANUQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(39860400002)(376002)(136003)(346002)(366004)(396003)(451199021)(38100700002)(2906002)(44832011)(36756003)(31696002)(31686004)(86362001)(53546011)(6506007)(2616005)(6512007)(26005)(186003)(6666004)(110136005)(54906003)(6486002)(478600001)(66946007)(66476007)(66556008)(41300700001)(8676002)(316002)(5660300002)(4326008)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NXozRzVuZGZEYmhSL3ZoYUFDUGIrQWc2dnFjV0xXQ0hkczNlLzJ1OEtxb0NC?= =?utf-8?B?eWJISUdUeExoUEw0STNzNk1tclN6SG4vV20yeFR3WjJuRUI1MHQzbnRDN0dX?= =?utf-8?B?Z0hoNm95Q0YyMzdUbFdOMDk5RDJHWFdndDV0ZFVpRmlmVHVwMG1mWkxKbE5P?= =?utf-8?B?OTI4b2ZHWFY0NzlZSDJ3UlM4ekZjNUM5RDUwVElEa0JtT0JUMWNPWmdwbktm?= =?utf-8?B?NFk0VUZaL1JCdy9QSHdtdVZJVnArR2w2NERzc1ZvVm1XSHlvZWw2Rmhyb01i?= =?utf-8?B?aHFHVEg2dDdpb2RrVFplVnppOXlEL0lKSUJwWFBRY0w0M2FFU1BJdlNPQWRD?= =?utf-8?B?dktXY3BXYkdSYWV0YWx3bzVlY0xheldxWEZuTjI1WENWVGYrNnBCWU8xQ3Bo?= =?utf-8?B?clZsdzF6RHZ0ZG1PL1J6R0ZaSHgzVXlmT1F6K0tOVldhd2pCQlNaUUZtYUll?= =?utf-8?B?T1FJblVLb2JxeFcwaHVlU0IvaHI4Q1pZWWlIS3hXcDIvVWtNRGFpNnI3Tldz?= =?utf-8?B?SWhNYUFsSExVSDRIQjdGNCtGenhtYjJRdXhzQS9yTVpyZHZzZ1NhUFJxWlpj?= =?utf-8?B?R1ltWmExUVIzSE1va2pUSHVDN3pwaW5SLzhqOGg1ZTR6aWxiYW8xVk93Qkxr?= =?utf-8?B?MTdaUjQrbmxjdWtiejJSM3ZHN2VIRFEvekJBWEozeTZYcTR2cDBQc0lmWkNM?= =?utf-8?B?MURJMXBBRVEweStPaGFHR0ZLSGtGcDFBTzhlK1BGK0U3K2RyM3RMVmM0UVNi?= =?utf-8?B?UG5TMGNGeU1hNlRDeU1QK0U5VmFpa3JKSmdINWdwWDBtRXpaV1NkV3RsMWM2?= =?utf-8?B?VVRGTTZJdzJ5RWd6d2xIdnpXMmxGMzJSUXVoaVc0eDhkZTdqSHhJeDI4elpM?= =?utf-8?B?eGp5OTI0bXJpS2R6cVdMek9WWmxmNk1JQjFIUENDT1p5d2JGTmhwK1crem82?= =?utf-8?B?QytNNFhPYjJmOVR3RDdKRDloaVpaRUZrNlFxeDhCWHZ2V2tiaTJPdERmaDBj?= =?utf-8?B?ZEpGekhWTjVldU9Qa0tEL3h3NDhjTUpVYy9uSXlPdEVCNlB5U2ZvZjJ2RUV4?= =?utf-8?B?OElPQlVma2RscllDZmhWV1ZSczJWS0xpTThPZnhOVUVISHlaYUx4N1pvR1Rj?= =?utf-8?B?WGdseisyeCtLTVlKdm9DWVBXUkxFZ1NGT0crY1puc3IrMnVkOEpySjY4c2V3?= =?utf-8?B?WmpHeVBQMFVEWDZzMXpNbDdtMWVWend1RTQ2RmkrYXBGWVpjOFI5WTcxSTVl?= =?utf-8?B?Y2tiUkZWYnJ1SE9tZlBkK3l1bEFCaUdpTm92c0NyQ0hINmJSVnRwcGJNalNp?= =?utf-8?B?ZzRIN0pDc3ZpOUR2R29iaE1VTHQ0L2tjWlpHU2h2Z3pISXQybkl6d0tTcWdh?= =?utf-8?B?U25HQlprczV4RndCYmQxc2tic0JuMUp3a1NZeUc2anZBSklsWWJVK1FkRURi?= =?utf-8?B?eC9rcUdhWlFEellnNllUQy9jcWpUenAvMlZYZU9KWkd1WCtvdzZCS0NXbFRB?= =?utf-8?B?d2xkbmRsaXRjTG85WGYxT01MNEJCVXdOcTAySnVMVFVvVGJMMXVhNjVMejU4?= =?utf-8?B?ZlJLdkZ5K3g3TnRyKzNoNDdLNWgxVWpKa3ArdkJJQ1N5Nm5ZSFNNUlRjWXBz?= =?utf-8?B?MWJmK3l6UmovK2hMQnh5UGNLS3BSN1lWenRCMHRraFJoSEZvWnA2a01EZEd0?= =?utf-8?B?czR1Z3VBdThhUSt0ZkVWOFRpU0pycGVrMzQ4aUJONHJDSnd0TmY3aTNaaW52?= =?utf-8?B?U0dNdWRjMCs5Tk94OEFSVjh3L2JjMkhuRDg3QWYyaUxKK2VZd2hjZlJNU3dB?= =?utf-8?B?WlN6OTJ2S1RSWXUwRm5hZkwrT3F3UUYyMk5pTWJQaVZjbXNyVURwWDV0ZmxK?= =?utf-8?B?TXFDUkFTdDlHb0tETjNieUdVLzVmQlEybVJnVWROL29jYVV4THZHd280L2Va?= =?utf-8?B?Y3JCMHJ0ZkdNMy85bURRVzhDRUxpZ1pCOXU3d09CZXQ5NkhwandUQUloWDJw?= =?utf-8?B?dC9OWFEzYTY5UVRWdEF1ZWw4TzUrVEVtYy8yWllFNUZQdVdCRGFaZURVNnlC?= =?utf-8?B?SEQrQ0tlNy94VGR6bFY1Q0hjM0pOanFwNjBVbEllTzRlRlJLeGRZamVISjVQ?= =?utf-8?Q?OltTSkdb8kiR5UY+XnzExs02e?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7b52191f-d12c-4f99-faab-08db73ee57e2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jun 2023 13:32:51.9326 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2YT5nGL9pxnO5e5a42U7SA9oCb2UHyrqVQfY/jNyhu8jlmdemrfWoqRYmQoY8SMV X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB8021 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/7/2023 4:10 AM, Chaoyong He wrote: >> On 6/6/2023 2:23 AM, Chaoyong He wrote: >>> A gentle ping on this series. > ... >>>>> Long Wu (2): >>>>> net/bonding: add independent LACP sending function >>>>> app/testpmd: add support for bonding port's LACP negotiation >>>>> >>>>> app/test-pmd/config.c | 19 ++++++++ >>>>> app/test-pmd/parameters.c | 4 ++ >>>>> app/test-pmd/testpmd.c | 37 +++++++++++++++ >>>>> app/test-pmd/testpmd.h | 4 ++ >>>>> doc/guides/testpmd_app_ug/run_app.rst | 4 ++ >>>>> drivers/net/bonding/rte_eth_bond_8023ad.c | 58 >>>>> +++++++++++++++++++++++ >>>> drivers/net/bonding/rte_eth_bond_8023ad.h >>>>> | 21 ++++++++ >>>>> drivers/net/bonding/version.map | 8 ++++ >>>>> 8 files changed, 155 insertions(+) >>>>> >>>>> -- >>>>> 2.39.1 >>> >> >> Hi Chaoyong, >> >> Sorry for the delay, bonding maintainers are cc'ed. >> >> I can see this set adds new bonding specific APIs, instead can't application (in >> this case testpmd) call bonding Tx function explicitly to handle LACP packets? > > Actually, I think apps should not aware of LACP packets because these packets are stored by bonding pmd(port->tx_ring). > >> Or should we have a special forwarding mode for bonding, as we have one for >> ICMP echo? > > Yes, both ICMP and LACP are protocol. But LACP is related to a type of port (bonding port in mode4). > Of course, we can add a special forwarding mode for bonding, but that will make it valid in very narrow situation. > > What I really want is to support mode4 bonding port on every forward mode of testpmd, and I also want to treat dpdk bonding port as a regular NIC. > It makes sense to make bonding work as regular NIC and supported by all forwarding modes. But current patch adds bonding specific check to the shared forwarding function, that is not good I think. If application doesn't need to know about LACP packages, or if there is no decision making required by application, can we handle LACP packets within bonding PMD, transparent to application? Chas, Connor, what do you think?