From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7C38D2BBE for ; Mon, 10 Apr 2017 15:36:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1491831410; x=1523367410; h=subject:to:references:from:message-id:date:mime-version: in-reply-to:content-transfer-encoding; bh=5DsUGCa7u6zZs90w4rVlpQzNvfWefB7lJ265n4lIyTU=; b=MmeK1HMUxanbHJYfX6//lx04YIU5MqQkGWa1mEhSn5S9USIA3Qdp3EPr bk8yNZWb6l801I1RGUSscIj5C2xbYA==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2017 06:36:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,182,1488873600"; d="scan'208";a="87262336" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 10 Apr 2017 06:36:45 -0700 To: Laurent Hardy , "Dai, Wei" , Olivier Matz , "dev@dpdk.org" , "Zhang, Helin" , "Ananyev, Konstantin" References: <1479403792-11928-1-git-send-email-laurent.hardy@6wind.com> <1487262721-22370-1-git-send-email-olivier.matz@6wind.com> <20170330111959.43ac9078@platinum> <49759EB36A64CF4892C1AFEC9231E8D650A23CB0@PGSMSX101.gar.corp.intel.com> <58E24CC8.1080406@6wind.com> From: Ferruh Yigit Message-ID: <8ce85605-3e52-6088-754e-29ee892681c6@intel.com> Date: Mon, 10 Apr 2017 14:36:44 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <58E24CC8.1080406@6wind.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: ensure link status is updated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Apr 2017 13:36:51 -0000 On 4/3/2017 2:23 PM, Laurent Hardy wrote: > Hi Wei, > Thanks for your reply. > > If autoneg is false, then we set a default speed to the highest value > before performing the link setup. > You are right, there is no relevant reason to keep this check on speed > mask> should be: > + if (!autoneg) > + speed = IXGBE_LINK_SPEED_10GB_FULL; Hi Laurent, Should we expect a new version of the patch with above update? Thanks, ferruh > > Patch has been tested using testpmd with following setups: > > Autoneg setup: > ========= > - On dut, both ports of 82599 are connected to a switch with 1Gb ports > - auto-negotiate option is enabled on switch > > Defined speed setup: > ============ > - set link speed to 1Gb on both ports of the switch connected to the dut > <...> > > > Thanks & regards, > Laurent > > On 03/30/2017 06:32 PM, Dai, Wei wrote: >> Hi, Olivier >> >> Has anyone already tested this patch ? >> Can you present some useful info on how to test it ? >> Can I use ethtool with some argument to downgrade or upgrade the rate of peer port ? >> >> I have just run testpmd with 82599, the hw->phy. autoneg_advertised is 0 after rte_eal_init() and rte_eth_dev_start(). >> So I think the codes in if (!speed) { ... } is likely to be run. >> I agree with most of your codes. >> But why to limit speed of NIC to 10Gbps if autoneg is false and 10Gbps is supported ? >> In this case, how about setting multiple speed ? >> >> Thanks >> -Wei >> >> <...>