Re: [PATCH v2 05/19] net/xsc: add ioctl command interface

["WanRenyong" <wanry@yunsilicon.com>]

On 2024/9/11 11:50, Stephen Hemminger wrote:
> On Wed, 11 Sep 2024 10:07:26 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>> +#define XSC_IOCTL_CHECK_FIELD	0x01234567
>> +
>> +#define XSC_IOCTL_MAGIC	0x1b
>> +#define XSC_IOCTL_CMDQ \
>> +	_IOWR(XSC_IOCTL_MAGIC, 1, struct xsc_ioctl_hdr)
>> +#define XSC_IOCTL_DRV_GET \
>> +	_IOR(XSC_IOCTL_MAGIC, 2, struct xsc_ioctl_hdr)
>> +#define XSC_IOCTL_CMDQ_RAW \
>> +	_IOWR(XSC_IOCTL_MAGIC, 5, struct xsc_ioctl_hdr)
>> +
>> +enum xsc_ioctl_opcode {
>> +	XSC_IOCTL_GET_HW_INFO			= 0x100,
>> +};
>> +
>> +enum xsc_ioctl_opmod {
>> +	XSC_IOCTL_OP_GET_LOCAL,
>> +};
>> +
>> +struct xsc_ioctl_attr {
>> +	uint16_t opcode; /* ioctl cmd */
>> +	uint16_t length; /* data length */
>> +	uint32_t error;  /* ioctl error info */
>> +	uint8_t data[0]; /* specific table info */
> Do not use zero length array (ZLA). Instead use variable length array (VLA)

will fix it in next version.

>
>> +};
>> +
> Does this device driver depend on some upstr
Yes, it depends on linux kernel driver of the device.

Hello, Stephen,

Thanks for your review,  please see above.

-- 
Thanks,
WanRenyong