From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 6774C11D9 for ; Mon, 9 Jan 2017 13:07:38 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP; 09 Jan 2017 04:07:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,339,1477983600"; d="scan'208";a="806733791" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38]) ([10.237.220.38]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2017 04:07:36 -0800 To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , dev@dpdk.org References: <66806fbdd31de8610a0be5463d813eaf7b816e85.1481592848.git.mirq-linux@rere.qmqm.pl> <20161213012851.1F4A0388F@dpdk.org> <20161213010913.34C8B5597@dpdk.org> <539d7a893864e515b9bdc688ca9d7b975a6835f6.1481742624.git.mirq-linux@rere.qmqm.pl> From: Ferruh Yigit Message-ID: <8d189949-27dc-b557-6fbc-f9d07fbd5296@intel.com> Date: Mon, 9 Jan 2017 12:07:36 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <539d7a893864e515b9bdc688ca9d7b975a6835f6.1481742624.git.mirq-linux@rere.qmqm.pl> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] null: fake PMD capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 12:07:38 -0000 On 12/14/2016 7:16 PM, Michał Mirosław wrote: > From: Paweł Małachowski > > This allows for testing code which needs offloads to be supported. > > Signed-off-by: Michał Mirosław > --- > drivers/net/null/rte_eth_null.c | 23 ++++++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c > index 836d982..e60516f 100644 > --- a/drivers/net/null/rte_eth_null.c > +++ b/drivers/net/null/rte_eth_null.c > @@ -284,6 +284,9 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id, > return 0; > } > > +static void > +eth_dev_void_ok(struct rte_eth_dev *dev __rte_unused) { return; } > + > > static void > eth_dev_info(struct rte_eth_dev *dev, > @@ -304,6 +307,19 @@ eth_dev_info(struct rte_eth_dev *dev, > dev_info->pci_dev = NULL; > dev_info->reta_size = internals->reta_size; > dev_info->flow_type_rss_offloads = internals->flow_type_rss_offloads; > + /* We hereby declare we can RX offload VLAN-s out of thin air (they are not there) > + */ > + dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP | > + DEV_RX_OFFLOAD_QINQ_STRIP; > + /* We promise we will do any TX offloads before passing packets to /dev/null > + */ > + dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT | > + DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | > + DEV_TX_OFFLOAD_TCP_CKSUM | DEV_TX_OFFLOAD_SCTP_CKSUM | > + DEV_TX_OFFLOAD_TCP_TSO | DEV_TX_OFFLOAD_UDP_TSO | > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | DEV_TX_OFFLOAD_QINQ_INSERT | > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | DEV_TX_OFFLOAD_GRE_TNL_TSO | > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | DEV_TX_OFFLOAD_GENEVE_TNL_TSO; What do you think reporting offload capa based on user provided devargs, as suggested by Konstantin?And by default not report any. > } > > static void > @@ -477,7 +493,12 @@ static const struct eth_dev_ops ops = { > .reta_update = eth_rss_reta_update, > .reta_query = eth_rss_reta_query, > .rss_hash_update = eth_rss_hash_update, > - .rss_hash_conf_get = eth_rss_hash_conf_get > + .rss_hash_conf_get = eth_rss_hash_conf_get, > + /* Fake our capabilities */ > + .promiscuous_enable = eth_dev_void_ok, > + .promiscuous_disable = eth_dev_void_ok, > + .allmulticast_enable = eth_dev_void_ok, > + .allmulticast_disable = eth_dev_void_ok > }; > > int >