From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63945A0032; Wed, 14 Sep 2022 10:50:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 49E4540151; Wed, 14 Sep 2022 10:50:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3CEAA40A7A for ; Wed, 14 Sep 2022 10:50:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663145447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2hAhlsbLEXVHRM1wYLT3LNL+oym6JNBgAre+nKKSJKQ=; b=SC8M0cFlY1GtiOkJyXezIh/ALsN0MtGvQYcz14jkQ9PvhrUh/Kg8ke3V0zZM39h9ZlI1IH ki4gIzKR8j81XIs6Q28TzvaFCZQrSpfHqnVcNqj8iDleXQYh4rQ4vuWc2Gj0QJ2X4QBt4M Qeasdp136lZjSiq0aDhRVagcdnVsqJU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-605-nODcJQHHMI2tUvMV8awDwQ-1; Wed, 14 Sep 2022 04:50:42 -0400 X-MC-Unique: nODcJQHHMI2tUvMV8awDwQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F192101A52A; Wed, 14 Sep 2022 08:50:42 +0000 (UTC) Received: from [10.39.208.26] (unknown [10.39.208.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E3D1140D1439; Wed, 14 Sep 2022 08:50:40 +0000 (UTC) Message-ID: <8d2658ca-fe6e-9eba-e0a4-184c38080ecc@redhat.com> Date: Wed, 14 Sep 2022 10:50:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 05/37] baseband/acc100: memory leak fix To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-6-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-6-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Hernan, On 8/20/22 04:31, Hernan Vargas wrote: > Move check for undefined device before allocating queue data structure. > > Coverity issue: 375803, 375813, 375819, 375827, 375831 > Fixes: 060e7672930 ("baseband/acc100: add queue configuration") > Cc: stable@dpdk.org Please add fixes at the beginning of the series to ease back-porting by LTS maintainers. > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 349b8be5c1..586d06d1b3 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -828,6 +828,10 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, > struct acc100_queue *q; > int16_t q_idx; > > + if (d == NULL) { > + rte_bbdev_log(ERR, "Undefined device"); > + return -ENODEV; > + } > /* Allocate the queue data structure. */ > q = rte_zmalloc_socket(dev->device->driver->name, sizeof(*q), > RTE_CACHE_LINE_SIZE, conf->socket); > @@ -835,10 +839,6 @@ acc100_queue_setup(struct rte_bbdev *dev, uint16_t queue_id, > rte_bbdev_log(ERR, "Failed to allocate queue memory"); > return -ENOMEM; > } > - if (d == NULL) { > - rte_bbdev_log(ERR, "Undefined device"); > - return -ENODEV; > - } > > q->d = d; > q->ring_addr = RTE_PTR_ADD(d->sw_rings, (d->sw_ring_size * queue_id)); With patch reordering done: Reviewed-by: Maxime Coquelin Thanks, Maxime