From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8571CA034E; Wed, 9 Feb 2022 17:01:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5038E41143; Wed, 9 Feb 2022 17:01:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 20EA641141 for ; Wed, 9 Feb 2022 17:01:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644422494; x=1675958494; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=k1sxDeNOMnrcYL1OmGFqp+7N4afYbC1/DJza5PJ09oQ=; b=EA7wv2iAGLOOHguMftGR94nyABYaeMPQAP1C4XEeH1n60hgqCYPnSqsP rkTenWacrvgcEkAHLDdsM8UMsjNbBYXOr4DJO8GxrFVxVorGlBR6Epl1L RV3UVqdos3TF9YwFHIc9N1HfhqZogJlary9KJAwV9YqwEn04ZGw2boQzO FA419HuQmoSTj0pcXRTOUQgYGkw4oKDbvFNzDBSbjk6wa6SKccdWlm34f TQv3IepIwm4kcgXmXgUxM1122Nor43X6KI6Ax4BwnaS0UYDPOUXFq4ZRN xKFZz0rbRf6ANscB3T+TrTRYuwp5SslhFbLyMyAcheHx3G2CmL/BcoXQv Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="229881194" X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="229881194" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Feb 2022 08:01:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,356,1635231600"; d="scan'208";a="541150814" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga008.jf.intel.com with ESMTP; 09 Feb 2022 08:01:32 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 08:01:31 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 9 Feb 2022 08:00:53 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 9 Feb 2022 08:00:53 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 9 Feb 2022 08:00:43 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=De7k9Luj/VF/eCwUeIeNDorxafVX1d/9vxTA9Gm4xa2LYRLKt5nD6DPQL018QihUqgwWD9Fkispn2+LwOuZZ3iZovvQ87cROIvkbnHXpD6H6yN1fXJkbTsWr1JgVSz2GVd7UJ4/0ljZBp/XPu8y0C+hYZhyuykLIyuufGxiPbgl4qnP4Lyy9BQ4s1YTb4PzqxXkjEkvrwDyEkrGyuAOFEhY0R/kAJcfxQVgF1ru6HB9wYYz7g/CJ577CB/JyWf4dNHreB3UU+EaoSpp4S1A2ut79TcmqQ5zBCnRBTTk6JQesFTqZwRWh+yMou7Y84Ilz7iADjMBllHvDemESzEHlMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3gEH6qpStnSWeLTdi4qcbtJtq565kIWG0UyH7aJnCv4=; b=QOYV+XHta8j+svrIKyyLKBoDYUJ7b2pZmu/uxkdfOivBlB9taE/xRt9ilqAj8D6nN6/4UOEkW7Ie+L46U+ipb2RyZ5nAga7sm6y2PNeKONB3Z0wJwRb8d0s/Cj1MYpvoP+q+gPyIGha+F2Tt2LJp7esRJEUEikBoyUq6H3+8rNXLfm3znQShrRp3e8XRn65gpzZsfweKI4FUDUYwlXqbT6ZJFuG6j6V8RkbJ5CRvgdEU/rNjq/Z23pjPOhYvJrz9xwkH0vDDRVoIRJmS5vvGyTPtBQuMZQi3DL5m6mQDlrpBllXM1biQV5X5ECE4+Wu48rcH6bqyTCBLG5Pj9P7DlQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from MN2PR11MB4224.namprd11.prod.outlook.com (2603:10b6:208:18f::10) by MN2PR11MB3775.namprd11.prod.outlook.com (2603:10b6:208:f7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Wed, 9 Feb 2022 16:00:25 +0000 Received: from MN2PR11MB4224.namprd11.prod.outlook.com ([fe80::351e:f17e:6b11:a19c]) by MN2PR11MB4224.namprd11.prod.outlook.com ([fe80::351e:f17e:6b11:a19c%5]) with mapi id 15.20.4975.011; Wed, 9 Feb 2022 16:00:25 +0000 Message-ID: <8d2fbcbc-abee-5f4e-89c6-69fac2a6aa6b@intel.com> Date: Wed, 9 Feb 2022 16:00:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH v5 0/2] Add config file support for l3fwd Content-Language: en-US To: Bruce Richardson , "Ananyev, Konstantin" CC: Stephen Hemminger , "Morrissey, Sean" , "dev@dpdk.org" References: <20220126124459.2469838-1-sean.morrissey@intel.com> <20220204195905.449192-1-sean.morrissey@intel.com> <20220204142636.6250f05c@hermes.local> <20220207190419.2a1ca44b@hermes.local> <5a01520b-b85a-02c7-67eb-5a7119e46ada@intel.com> <20220208094904.5ca9db4c@hermes.local> From: "Medvedkin, Vladimir" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0477.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a2::33) To MN2PR11MB4224.namprd11.prod.outlook.com (2603:10b6:208:18f::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7faaa9f8-6011-49e1-9230-08d9ebe548d2 X-MS-TrafficTypeDiagnostic: MN2PR11MB3775:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: p3GDu09GFRjZU8FwdhjePvGCmgIfEyyuGTg2TqJF+kgE+eq4vZLoipXYKpAWrJrqbJdJJMdV3k+ZIGaWidbT7Pu8zRQc004H8IPaHOChKhnukw9BsOwHniS9bMLYYIxbhXTz8QJBrBqq8GN0QPG3UC3ayDSY1eKaAHWUsQK4m9VA50jDza7f919GKEH4Gy1GsvrP8e/+1frda25n5dgkzml4W5kmV5EDVJAPJgN9BTeTmEz2SAZaGbv/lk4P6UFhs62cretgb9dpGSr055TaJItvUS4kLXdmL1HlmG+RzXglsYEbPMgCurnI5aQ2VZrVEUgh8kAiynR4DRC5cUuGN4+GN1HUrtw+vcHS/9jpUZAc3iQfkdeHe7OIwBjRTeIQTzhwsAW7HN274ihnpJWzUgKIdjbX6ODiKEtH3r8Nv406mqBapeQ7LwjECkB4rK8x31CX4AnrOzdMCKoClX8GDiSl8R4knkxqNJ6ubCTu0ZR/jhFy2IrhRk33+8epMr9lDWW0Uqq3IE296lOyOaJxf70XMdsgQIMfBLtza4bC67gLr4ZWFQ/Pg0mOUqFFNYVaTLhufCHW9JsBzRpiFb77/RhO3QCQ6dliOSVvgrBqzHzWCoWRfXb70Gd5UUTNHCGWbDC/p9g6qqoSprF+BSOg0z12HATeOA23n23p9+dhZyNxM3vrDWapxlSMiskAGa/OV6SCGY+j7jB+FiYQVjAYdaqEZDQDWq3ctI518f419tw3pDaKzFeTWi1gqMtp8ZqctpX3sQGQmZDdkxctA1wBTA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR11MB4224.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(110136005)(4326008)(53546011)(508600001)(6506007)(66946007)(66556008)(66476007)(8936002)(6486002)(8676002)(38100700002)(82960400001)(86362001)(6666004)(31686004)(6636002)(2616005)(186003)(83380400001)(6512007)(316002)(26005)(54906003)(5660300002)(2906002)(31696002)(36756003)(32563001)(45980500001)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VmJ3MkZBbHVnMG1LWDJ2TkhrVElha3RPMFR5OEl2NWRXVk5jQm4vMWRHczRC?= =?utf-8?B?SFJYUzUvaGFIcDZNUWQ1bXNKUGQxaVJXTm1nL0cyaVFYU0tSUC9NcWRZRnR5?= =?utf-8?B?SnIyK2tuMWZKNE0vOXdEeGIva05QUEp0VHBOTi9sdFlKemwwbG9tOWM3elhl?= =?utf-8?B?OHZXbS9hRGJtWTF6VGV6NWVWcVI2RDN3aEJlTkU1b0t2NXlyd2lqNjBFTWg1?= =?utf-8?B?ZElxTkdBN2RSVit0cXR0VkdtMHJDK0M0eEZIOExjUk1OSzNRcS9iaWpIMFBZ?= =?utf-8?B?N3lvU1l4T015QTBCYzFack03Rk9QTkRaVExBTkVoM3dQQVdoQ0I2NmRkWkxQ?= =?utf-8?B?RTM4VnhRQUkzWlIzM0RUdXFkd1NGR0ltem1BUDJxVitNeFNER0ZvN094YjhE?= =?utf-8?B?M2s5UVE1a1BGQUdSUkozMHdPZjFEMkdwVldoRWEwanNoTi82TmY1RkwvbjV6?= =?utf-8?B?NkxONU1rSzFCWkdqYUVMaUNUUVBMSUx2aFRFclVBNHA4bFlqTDFSbU9EK2hp?= =?utf-8?B?VXkzMVNvdC9mSS9GZjhmUzJpOU52amJOaS9qUk5CT1hkRUJGNnl4TGFUbWJt?= =?utf-8?B?UU5ZRm5wZWpDVy9sQ0hYNGJoT3hlUDNNZWZvWGF4cHBIY1kyVHE3enV0VVRz?= =?utf-8?B?cmEyS3RCWjBadUpoRGp6U3ZGZEQycDVVbitBYjQ5c01OSTlySmVORGR3UlY5?= =?utf-8?B?WUtFSDV3eWMxaXRjOEJzUm52YVRsblJvQ0xVZ2Qxdm9kV0ZoeTducVVia3Vi?= =?utf-8?B?UWNoNnRmMmQ1L09qMHA2V2lER0FoRmJ3SlQ4NzkxVFNDWHFCZG4rVTB6aWJR?= =?utf-8?B?Ly9qUVNvaE9jMUdrbTM2VGo4UUJNR0tJMUNqN3N1T1YvYUZyMDQyUVZkKzV0?= =?utf-8?B?NVp3a1cyV0RvS0JhNzl4QVEwdjFFKzNlREdRYmgzQ1Fzd1A0a2RNd21RYmhW?= =?utf-8?B?Z2x3MXNSWGtTeE9kcVNpWG1oYnl4YnpSYlhqaGdUQ1lEUy9xUmNXQU5YMDk4?= =?utf-8?B?YjRJMXh4ZTBiUTArL0prQnltRldOWlY2b0tDODJmRFU5WEVneThTbGhKSGVx?= =?utf-8?B?UlVUNVZ5R3dSU3h2TDcyaEJSeHVPNndRbFdBejMzZk9yUFFKZkpFRlAwNU15?= =?utf-8?B?c2htWWlNYnZSazErRW5MRlE0WFErTUJ5QUxtbVpFNVRHNTdqN3JjUElacmhF?= =?utf-8?B?UGtDNUhsNzVtSzgwaEFZNGsyUXdYOFg1T0l4M0M5eG9Tdm1PZFV3VXZwd3Fh?= =?utf-8?B?U3I3ZmtNS3h0YzlOVklDTHY0ZXUraXFTTHo2elpLR3VTeWhYZ2ZXOEZFTlI4?= =?utf-8?B?RWY4Ri85eSs4YVlmalh4ZDJCeUJsdEVwSVllVW90MTVoWjhuTjAwSFhDYjAv?= =?utf-8?B?am0rTDYvL2NERHYrbEN6M3dDbkswN3BXYkRhYlFvN1FWSytFdTRpK3JQR3Vp?= =?utf-8?B?OXRyYkgzaTZyYWVDYXczajlDb2ZDb0daeUl1R2Q4VXlsYkUrTC9iTW9LY0ZE?= =?utf-8?B?TG1OMkhERFFrUzY4NHF2YzQ4Q3lGaUNMMU40clhXNFIrdUppRnNjcFhMeGpx?= =?utf-8?B?U2d4T0Fob1BsTDI2YmNZSDNRRDBVTGJsSFlRSnQ5VzZQcWxTdWFucVpOS0Ns?= =?utf-8?B?cVkzMmRrdEVmaU9pRk5OZHBKQWpUR3cwcEo5T3RSYTQ5a2s3WlBwNGhxMHlu?= =?utf-8?B?UHVJRUQ4SXRUd2NOWTVTVHpLVklqQXBDWmh3Z0V1Nk4zbmtReWVOK05Hbm1p?= =?utf-8?B?bWp5V1U2YzF4NXcxNk1ONFRyZG90VGU3YnJXMG56SXI3VFJZaUZKSmppN2xa?= =?utf-8?B?bURieGtjTDJNUkUxM3YyWTJjdEYwQmtTazh6K3VaTmw0Nmc4OVNkTkNSY0FI?= =?utf-8?B?KzN1cFlLWjdwTEN4cU5kWnQrOTlkZUlmRWl0UFhOYk8yR2g2WmY3czd4ODRy?= =?utf-8?B?NEIzUnFEcmNMOTNlSVlUZlh5T3BtZlUwYjROdVpNanVFSW9TVkxiaEgvbXhU?= =?utf-8?B?NG1aaUNJTmpFeGVzbis2ZnZ2SUhwdUVnc2I0V2MyWCtFRnd4d3A2cHdPNGpG?= =?utf-8?B?QlNDVmMrbUViZDRzdWlJaHBMbUF5eCt2MFFsUVlTdHltbzhTOThRRURnbDN1?= =?utf-8?B?cEV3YTFoQ1pORHZZQWdqeG5oUGN5WkJmeHdjbGxURk5iV0VoRWNnV0pNYmhB?= =?utf-8?B?Zko2TVpOOER0dmY0TnVPY3NLM0hFTjFoR1A1aDJ1dTJQb0FFVmhFRjU1UGtt?= =?utf-8?Q?2mxc3NGr3Sq/t0hJAT6m97oSi3bDbJ9hxXHTyBuWkg=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7faaa9f8-6011-49e1-9230-08d9ebe548d2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR11MB4224.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Feb 2022 16:00:25.3308 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: pCEPfFpJSbjncouKCWOvYtReh45A0eTPhHsrCBkiLaXlCF4zFbkypY91/ySmSK13PCMWkcLKocuPaXnvj/IakJoGZVdylNAG/KONduHP8SY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3775 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On 09/02/2022 13:54, Bruce Richardson wrote: > On Wed, Feb 09, 2022 at 12:00:40PM +0000, Ananyev, Konstantin wrote: >> >> >>>>>> Or have a generic library for reading LPM entries. L3fwd is supposed >>>>>> to be as small as possible (it no longer is), and the real work should >>>>>> be done by libraries to make it easier to build other applications. >>>>> >>>>> I never heard users ask about such thing, >>>>> but if there is a demand for that, then I suppose it could be considered. >>>>> CC-ing LPM/FIB maintainers to comment. >>>>> Though I believe it should be a subject of separate patch and discussion >>>>> (I think many questions will arise - what format should be, how to support >>>>> different types of user-data, to make it generic enough, etc.). >>>> >>>> Agree, it is very application specific, so it could be really difficult >>>> to make it generic. >>> >>> But several other also have LPM tables, so why not have common code for other applications. >>> >>> examples/l3fwd-power/main.c >>> examples/ipsec-secgw/rt.c >>> examples/ip_fragmentation/main.c >>> examples/l3fwd/l3fwd_lpm.c >>> examples/ip_reassembly/main.c >> >> Ah yes, that's good point. >> All these examples (except ipsec-secgw) started as l3fwd clones, >> so all of them have hard-coded LPM (and EM) tables too. >> Yes it would be good thing to address that problem too, >> and have some common code (and common routes file format) for all of them. >> I don't know is that a good idea to introduce parse file function in LPM/FIB library >> itself, might be better to have something like examples/common/lpm_parse*. > > I think it really depends on whether you are planning on implementing a > general config file for the application, or whether the file(s) will only > contain the LPM/FIB routing entries. If the plan is reading just the > routing entries from file, then I definitely think that it might be > something that would be generally useful inside the library itself. > > If it's a more general config file with other app settings in it, then an > examples-only parse function/file would make more sense. > I vote for this code to be in examples where we can control the file format with LPM/FIB entries. I don't think it's a good idea to move this API to the data plane library. I think it will only be used in our examples because dpdk users will have their own formats for routing information. >> Anyway, this is an extra effort, and I think no-one has time for it in 22.03 timeframe. >> My suggestion would be for 22.03 go ahead with current l3fwd patches, >> then later we can consider to make it common and update other examples. >> Konstantin -- Regards, Vladimir