From: Andrew Rybchenko <arybchenko@solarflare.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>, <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: check if hugedir write lock is already being held
Date: Mon, 30 Apr 2018 16:07:58 +0300 [thread overview]
Message-ID: <8d3e2cc3-d4fd-6c84-e136-aef593b5ea4d@solarflare.com> (raw)
In-Reply-To: <00fe124e2057fe6c5596fb0a24bdcce9b36c3b90.1525082912.git.anatoly.burakov@intel.com>
On 04/30/2018 01:38 PM, Anatoly Burakov wrote:
> At hugepage info initialization, EAL takes out a write lock on
> hugetlbfs directories, and drops it after the memory init is
> finished. However, in non-legacy mode, if "-m" or "--socket-mem"
> switches are passed, this leads to a deadlock because EAL tries
> to allocate pages (and thus take out a write lock on hugedir)
> while still holding a separate hugedir write lock in EAL.
>
> Fix it by checking if write lock in hugepage info is active, and
> not trying to lock the directory if the hugedir fd is valid.
>
> Fixes: 1a7dc2252f28 ("mem: revert to using flock and add per-segment lockfiles")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Tested-by: Andrew Rybchenko <arybchenko@solarflare.com>
next prev parent reply other threads:[~2018-04-30 13:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 10:38 Anatoly Burakov
2018-04-30 12:48 ` Shahaf Shuler
2018-04-30 13:07 ` Andrew Rybchenko [this message]
2018-04-30 13:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8d3e2cc3-d4fd-6c84-e136-aef593b5ea4d@solarflare.com \
--to=arybchenko@solarflare.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).