From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D4AB42A94; Mon, 8 May 2023 13:27:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF8A8410ED; Mon, 8 May 2023 13:27:43 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2065.outbound.protection.outlook.com [40.107.101.65]) by mails.dpdk.org (Postfix) with ESMTP id 6EC1D40685 for ; Mon, 8 May 2023 13:27:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qxy/1xLfDF7bcKQS2gufM/X1bGOIp3fr/dixhuo69xplOnIskjH0XHZlrD6B4MvfXifUOH6hSu8QT3kSKaR04RZl0MzbdumoLnywkYk+pzdPoAyhYw282T/bxQ+SWqXpBG6ro5h+zSZfqaW9m5wDsTYteUSX2D/C3aHiRPrW3Lr1U7LOgSPFMW9+m8QabWiFXa0Eq1toPcl9GxCwg5jsRdr3/Zt5Bnv4BEtMJT/ew811wAjQrftMj4OpipS1DbT5QWtYpdzzBOdAUERP6RRXHYBoCAUPXVhmOAapNxEzQYOUdISN5FyV10soL7TMCDvoROIgXacUUwI78y3qDyTcHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hk+IRWk/6gwX7qGXOM5mbmCy4ZeKfjozSmGIEpfJrv0=; b=F/7ZQ/nnN7rX1TXZb/ETJqsgQZuKfXvPLMFHSzZQ4t08PHlEyJ81i18EXG0AAMgbXMwAXWz5+/mrQDt84lBGaEYcSJzRQVmuzW3AfJhmhMR5v4GaHIb+3Cc95zm7VpWk07CY+l9a55PyE8xfqvVMfbQo7WuZf0/wdWYv2Zj9r2xgAcvve6v4/zKdCDMfArFcUN92BRXY4tDJJDUIzP7oiMJB1SHxzzBlDW4Ek0eCOvF+oGGQa41KUEvFwNWJeOEYsDNKnw+cLFMYvhGH0iWbJsbq7K5yNl4V9YN0yJZncgHsXkN9HlJrFBx/PXgYMZQLPtMH5IZQ5GvNzRy5KviutA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hk+IRWk/6gwX7qGXOM5mbmCy4ZeKfjozSmGIEpfJrv0=; b=wUMLkHgi9krNGSLdYzwhmZpBhcIilJ/M4S26rztOXicz8V2ogMfFJQd3AKDaqPZk0uDHdPzD6FSx1Ygr+z7Ui3DHWYP/BaMmqfup3bdif8xwf7RKXX37Tie+uerBqaUhR0HEtb27ZODonyUyPPiyidQrE48AFuBq1Q6cmRmr1LY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH0PR12MB5265.namprd12.prod.outlook.com (2603:10b6:610:d0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Mon, 8 May 2023 11:27:39 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::e818:77ea:75b5:f8cc%5]) with mapi id 15.20.6363.032; Mon, 8 May 2023 11:27:39 +0000 Message-ID: <8d729d5d-2de4-fc73-3ad6-d045079274e9@amd.com> Date: Mon, 8 May 2023 12:26:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX Content-Language: en-US To: "Gupta, Nipun" , "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" , Honnappa Nagarahalli , Ruifeng Wang Cc: "Anand, Harpreet" , "Agarwal, Nikhil" References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230421145406.12831-1-nipun.gupta@amd.com> <20230421145406.12831-6-nipun.gupta@amd.com> <54328b0c-584e-dc58-2559-9d30e089a66a@amd.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0178.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:311::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH0PR12MB5265:EE_ X-MS-Office365-Filtering-Correlation-Id: 25de0b88-e62a-4123-7d1d-08db4fb73b26 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TTG+Hu8O69i/ycj5t+2dAIvGg+sy0VyR1etEzwgIZXSTrg6hmHn+quGS+DyjNkv/9PczNcNKlx6tXKXo/4v9wgDC8guGhvDDmmBZtkDW3mtKZNUWR2w6oipWMCxFzJrioGLzoIZRS0MP1CIJSrKHUxpa8M0xwwMUFu53l3Kqeo2pLdHE9dIqvPz3yslZdz1k6FuPfG6lw4kHZXw0SZ4ga7mvB8HdXFJFz4m51pURvABvWS0UV5lcB1Yn9VC7YzTTL+M4hV1+o9OoM255TtWYcUq19EI/sv0TUWzLDyig3rDHEJa7CQ2miLhO02Tmx5/qy29YZG2dJNnUl9ERzLqDkuyu6rPjcRziYrm4FTQxXgEYVjf5f0drCLYBNXyWFUb4NctkgLqeRiEcrBh8aSoFd83ANPJFlVkux9VY58VMl1wBN5nR9lWUwObtSbWbYQ+4qhb1CxvUElEepRqY7m5NfTuYfJKd3egvEAWuqKOE36Q4BSyPxjA8pXc1Ld/dFEab5d+oSybabMIJHZLkSvJcUt9uftEPx1NdSO6G+V0aXZcwj3PKfqIRPV7YJIF+ESw0/klxaq5skQmAbHGap+yZOo0H9VduqrKPvagtwFRzWNhcW58narO+eH7X83YPuGpmunDtfe8M59AmHXKNAX84tw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(376002)(136003)(366004)(346002)(451199021)(6486002)(38100700002)(186003)(2616005)(26005)(83380400001)(6512007)(6506007)(53546011)(2906002)(44832011)(8936002)(8676002)(36756003)(110136005)(31696002)(478600001)(316002)(6666004)(86362001)(5660300002)(54906003)(4326008)(66556008)(41300700001)(66476007)(66946007)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cU85eDlSN0lodzlIYUl4VGZ2NWNPWWdTRGVlT0pwVEY5YVVVTEtEMTE1L1JU?= =?utf-8?B?eE9QbEFNWDNGTzNtYmxPZy92ZEs4TXYrWXVKRjNFU2FwS0tSZ0Q0ZmJpeitR?= =?utf-8?B?TXlqc0twRzlVZEFWOE1nVnBFM3JtSk05QWN6RmhacjdLWXpZQ1Q1bmUwSGlJ?= =?utf-8?B?WkR6MkRJWWtHRHc4MHFwVHdlRTNvdCtZQUxNY09tYlZzU2hubnI5QkFtdG5n?= =?utf-8?B?Z2VQaW9pSFdiZVJQTDhDb09CVUdCNzR0OEU5K24vandJQmorUHI1MzduTnBS?= =?utf-8?B?WU41RVZNMjZPS2xPYkxxV3AwODJKc2ZGd1h4VnRYUEN3bVdmTU5BZXFTMEpT?= =?utf-8?B?Z1M2YnJHcTE1ekh3SW1QMUlaWld0cUlZOUJlLzRsdjZXSDRQLzlJekJtdlJP?= =?utf-8?B?OTdINEF1WWduK1UzalhpdlRnSGxJQmZ3SVMwVnQzazFDaFljUXY0d2JsdERh?= =?utf-8?B?S3JDY2FyajVkcCs3ZklsaWxUUmVFclBTWmZEa3p0SFR3a20rR0lldHQ4L21o?= =?utf-8?B?UDZqbEIvaVN4emY4VGNnUUgrUDFyTHpOUW16UGJsaGxCUG1rdXZQM3ZsRWZt?= =?utf-8?B?aUVoQW8vdm9nejkxNSs5Tm9kS3BmWG16SmZaQVFFbFc2WjZwTHdicHEzZ0Zk?= =?utf-8?B?bHVzeHlvaDVsNHM1akVwaFYzczlpZlNvOGVZWllEc2NFaUFaYzlpN0xkbVl5?= =?utf-8?B?ZFdnUXRQYnNtRVpRZ3IwRExCOUJxT3phZjd5V2h2ekxsTnBvS0NZWXhHWHhE?= =?utf-8?B?b0NRU0ZVSUUwSGlRNDFOUm1GY1RxM3Y2VktYbk1ONVA0bnZPZVQzZ01KcXU5?= =?utf-8?B?ak9KSlhGeDQwRUFzQXpZbUMzRklrQkZWNjY5RFRRWHd0NnYrQkp4RldMeWU5?= =?utf-8?B?aVpHeGxJaGkxYjhESHVxK2J0aXR6ZHRrQW9ETitrZHlnMkF0SjJ5NndkTkky?= =?utf-8?B?WXQ4eXAyeWlCd1JEdHQvTDlIaDM5dEtTRSsyMnF1ZU1CdlNUYVJub3l4Qncv?= =?utf-8?B?OFFQMVFoc21WQ1pTUkJsRWQrT3M3Z0F6OGc4NndxcGhpS2ROQkw1d0xINTZr?= =?utf-8?B?OTBjWTJjbk91UXFzK3V3NXNNZnNMcXcza2lmVlVjYm9wQVR3WndqT2pmNVZK?= =?utf-8?B?OHpHNUVVanhEQ3d5emJjNHh3a2dJeWVwbC8xN0RCcFFYRWxmZkd4T3g0TG1q?= =?utf-8?B?REpBTlZ2WXNSb0w3WHBNRThYaDB0cFNTUWRxSXBpdmp0U3ZyU1ZMUGpvdnJj?= =?utf-8?B?b1RSMVZIRCtsZUlFS1ZEUUJaNXZWTDRMeC9DNVBsbW5WMGxFcS9Sa0NTWkd5?= =?utf-8?B?VUxydDJJNjhNNTZkVGhuMkVpRmF4akQ1ZUdCOW82VDBSOWU1Yk1jSXg2ZWRq?= =?utf-8?B?aW40bFcyZDlRNUtYcGNBRUpYdGRFc21Mem9UMzVjWStaSW4xM3FET05RQjRJ?= =?utf-8?B?MlN3dEd1UUJHcFFoQmYzY3J4aGdWQ3R1L1pDQ3RYTWFET0xMeVZ0RUZHZlB5?= =?utf-8?B?bS9GN3BTWSs0Y2xlMUV3VlZCcmlHZTcwTEdMV0I0ZWNsTlQ0cVMyelVWVmQ0?= =?utf-8?B?WkxRSDZka1Y1bEZGQW5oYjRuMFVldlFWcTVjTkg2TDM2bnNPUm9IYVcwdmky?= =?utf-8?B?dFdtSFUxYjJSbURoUFhOTHZ6clZGaEdnRHRnZXNtZ3Y2TjNxRzZHZFhSVVZZ?= =?utf-8?B?R3hqU2dVYUpEc3hPdi9ZK010dGFyVWUrTmErREx1S0kydDA1R21nOHpDR2dF?= =?utf-8?B?MDdyQzY1MzdzVStwcXM5T1JTK3drcE8vb3NsRHkrTzFUTVhmWmdob3ArNm9K?= =?utf-8?B?VzZnL0ptMXh2cnc5MkdMSTNyUTgzNHZNRjNQck9uYUVuelV1RXZlYTA3RU9F?= =?utf-8?B?aS9WK2NONTZMU3lMamJnaWpQeVprb3lmb3BnNExzVlY2L3krcnhLeHEvZjZP?= =?utf-8?B?eDN4VWpJNzdydmhyWEhhcmFpNHEybzZhWmh6Nml6LzFqQUo3TCs2U3FJMm1k?= =?utf-8?B?ZDNQa0pJK05xVUZWTGR0MkpQSEMwaUc0aHlvQVlmUXdZQzRmaUhUaEJrV1oy?= =?utf-8?B?aXJZUzdadGVBbUpwN2tCVjVJL0NoNVIxTlc2eSt0YWg5ZHpTdFQvL2JsMGxV?= =?utf-8?Q?0C9u2Qp8bMWUDV/Ffjtkt43CJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 25de0b88-e62a-4123-7d1d-08db4fb73b26 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 May 2023 11:27:39.5817 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oW0xkVP+OX1Zro8BX3xxiJt4XU5sRsIOZ0JGfKAnFoJPxhTu9DkYMsgj+yh7vWku X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5265 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/8/2023 11:24 AM, Gupta, Nipun wrote: > > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday, May 4, 2023 8:59 PM >> To: Gupta, Nipun ; dev@dpdk.org; >> thomas@monjalon.net; david.marchand@redhat.com >> Cc: Anand, Harpreet ; Agarwal, Nikhil >> >> Subject: Re: [PATCH v3 5/5] config/arm: add AMD CDX >> >> On 4/21/2023 3:54 PM, Nipun Gupta wrote: >>> Adding support for AMD CDX devices >>> >>> Signed-off-by: Nipun Gupta >>> --- >>> config/arm/arm64_cdx_linux_gcc | 17 +++++++++++++++++ >>> config/arm/meson.build | 14 ++++++++++++++ >>> 2 files changed, 31 insertions(+) >>> create mode 100644 config/arm/arm64_cdx_linux_gcc >>> >>> diff --git a/config/arm/arm64_cdx_linux_gcc >> b/config/arm/arm64_cdx_linux_gcc >>> new file mode 100644 >>> index 0000000000..8e6d619dae >>> --- /dev/null >>> +++ b/config/arm/arm64_cdx_linux_gcc >>> @@ -0,0 +1,17 @@ >>> +[binaries] >>> +c = ['ccache', 'aarch64-linux-gnu-gcc'] >>> +cpp = ['ccache', 'aarch64-linux-gnu-g++'] >>> +ar = 'aarch64-linux-gnu-ar' >>> +as = 'aarch64-linux-gnu-as' >>> +strip = 'aarch64-linux-gnu-strip' >>> +pkgconfig = 'aarch64-linux-gnu-pkg-config' >>> +pcap-config = '' >>> + >>> +[host_machine] >>> +system = 'linux' >>> +cpu_family = 'aarch64' >>> +cpu = 'armv8-a' >>> +endian = 'little' >>> + >>> +[properties] >>> +platform = 'cdx' >>> diff --git a/config/arm/meson.build b/config/arm/meson.build >>> index 5213434ca4..39b8929534 100644 >>> --- a/config/arm/meson.build >>> +++ b/config/arm/meson.build >>> @@ -305,6 +305,18 @@ soc_bluefield = { >>> 'numa': false >>> } >>> >>> +soc_cdx = { >>> + 'description': 'AMD CDX', >>> + 'implementer': '0x41', >>> + 'part_number': '0xd42', >>> + 'flags': [ >>> + ['RTE_MACHINE', '"cdx"'], >>> + ['RTE_MAX_LCORE', 16], >>> + ['RTE_MAX_NUMA_NODES', 1] >>> + ], >>> + 'numa': false >>> +} >> >> Hi Nipun, >> >> Why we need a new arm platform/config? Is it because of above flags? >> If it can work with default values, I think we can drop this patch. > > Hi Ferruh, > > CDX driver works with generic ARM compilation too (arm64_armv8_linux_gcc). > > The versal platforms supporting CDX have A78 cores, and adding this cdx config > Helps to provide gcc option "march= armv8.4-a" which is for implementer > "0xd42" (ARM cortex A78 cores)., whereas for generic ARM compilation > "march= armv8-a". > > Maybe ARM guys can provide more information regarding if there is any impact > on using generic architecture flag (i.e. march= armv8a) on A78 cores. > Hi Honnappa, Ruifeng, Can you please support on this question, what is the difference of 'march= armv8-a' flag (comparing march= armv8a)? Should we consider adding an arm config file to support this flag? Thanks, ferruh