From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 670994236B; Thu, 12 Oct 2023 04:21:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4328402BA; Thu, 12 Oct 2023 04:21:34 +0200 (CEST) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id AC29B40279 for ; Thu, 12 Oct 2023 04:21:33 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4S5YDN3rktzcd40; Thu, 12 Oct 2023 10:16:52 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Thu, 12 Oct 2023 10:21:29 +0800 Message-ID: <8d86f61c-b386-9738-e0e8-d4e1fb7d2214@huawei.com> Date: Thu, 12 Oct 2023 10:21:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v5 26/40] net/mvpp2: check RSS hash algorithms To: Ferruh Yigit , , Liron Himi CC: , , References: <20230908080030.3837515-1-haijie1@huawei.com> <20231011092805.693171-1-haijie1@huawei.com> <20231011092805.693171-27-haijie1@huawei.com> <0cf0a446-54ce-4bee-8ba6-c00ded26d923@amd.com> From: Jie Hai In-Reply-To: <0cf0a446-54ce-4bee-8ba6-c00ded26d923@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/10/12 2:00, Ferruh Yigit wrote: > On 10/11/2023 10:27 AM, Jie Hai wrote: >> A new field 'algorithm' has been added to rss_conf, check it >> in case of ignoring unsupported values. >> >> Signed-off-by: Jie Hai >> --- >> drivers/net/mvpp2/mrvl_ethdev.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethdev.c >> index 359a5d1df7ab..817153af2ef1 100644 >> --- a/drivers/net/mvpp2/mrvl_ethdev.c >> +++ b/drivers/net/mvpp2/mrvl_ethdev.c >> @@ -440,6 +440,9 @@ mrvl_configure_rss(struct mrvl_priv *priv, struct rte_eth_rss_conf *rss_conf) >> if (rss_conf->rss_key) >> MRVL_LOG(WARNING, "Changing hash key is not supported"); >> >> + if (rss_conf->algorithm != RTE_ETH_HASH_FUNCTION_DEFAULT) >> + return -EINVAL; >> + >> if (rss_conf->rss_hf == 0) { >> priv->ppio_params.inqs_params.hash_type = PP2_PPIO_HASH_T_NONE; >> } else if (rss_conf->rss_hf & RTE_ETH_RSS_IPV4) { > > what about updating 'mrvl_dev_configure()' ? > . Hi, Ferruh Yigit, Both mrvl_dev_configure() and mrvl_rss_hash_update() calls mrvl_configure_rss(), I update this for less code. It may be clearer to verify the two separately. Will change. Thanks, Jie Hai