From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2104CA0C4D; Fri, 13 Aug 2021 16:47:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 989454116C; Fri, 13 Aug 2021 16:47:36 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8B46D4069C for ; Fri, 13 Aug 2021 16:47:34 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10075"; a="279311214" X-IronPort-AV: E=Sophos;i="5.84,319,1620716400"; d="scan'208";a="279311214" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 07:47:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,319,1620716400"; d="scan'208";a="504213239" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga001.jf.intel.com with ESMTP; 13 Aug 2021 07:47:29 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 13 Aug 2021 07:47:23 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 07:47:23 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 07:47:23 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 07:47:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CDMKBOWFQLZNwzKgWy9zTpvy9U+qvtxNN9aegODSJR/ILAWsmfVAop8J2qyc+1jLXg0aaBPwQslmjDDpG/kWzUzsL4LQw0IHU6bR3Y3ZC+Z5bE9A1a2g8UlZ9fiIF5qhNcQmB/MubQg2Y0kaN/REXZgMrRKxYv4et6GTLRJ26SEpA45a3ZhV53jC9wJykoGXlOS+zlwQqJmuyuMc7LGdE4FqvcrvjrmlPCLavBR3mXpjZQO3FFCg1aevZfCTVb4or0Sbldd8E9wrb0Vk//wyP6vLjUz04EBc30gztvmgaB8f9/WGu00yIZwaQC+/wOGHg6gwOKKsk6cIAvjVQ7SoNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UnxDGKhSr7cYDPhfOZJwXeK7+F/n7/CtQDiPTsCZ1GA=; b=FL8hSLkVFhi49FpiDWfhW3nYqwhwCC5vL4k+njJvTz4AUiGxsixnMOWvP9AU1mZBvgr5Uw8UrH2G5H7zLn/FLx8ovEFop/PXrj+DMrbw+gAEIN+SkvENFFcmUsCMWVauW5JppI5PxXR9O3vgYKwN3vzjvgeaJPnslsXRB6QPAXyHULcOsqol6et6rwIXJIDs1iqRuPnDauMp0X4BbvUMx9HqF1EOvln5YoVyp/hsCjKJangNqeGrNhSydD6XnJtiZONfcvZUqq3GcbAzUsZj1bwsmcd9phSPNZjeCkHYzW18dx0RLP7Zr1GStmJtoAqs5hcnBB3vnCpB7skusNes2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UnxDGKhSr7cYDPhfOZJwXeK7+F/n7/CtQDiPTsCZ1GA=; b=GnG/hQsv+4bCnqs4BZz4xdEivF+0It093ukHE555/quSNnT7NK2gZ4PfMcYi+npjFhkCURwRLcS7vCUWXXYnDKchYNKzMK2VidDE5IpKG5DQ9T7HW7vhTfni/BRHpVe5d7jRceo8RrbW5I14RunSBFqqxjjEakiW7Do/3CewvUQ= Authentication-Results: canonical.com; dkim=none (message not signed) header.d=none;canonical.com; dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by BYAPR11MB3718.namprd11.prod.outlook.com (2603:10b6:a03:fd::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.19; Fri, 13 Aug 2021 14:47:19 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5ef:d69:fa61:6150]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::5ef:d69:fa61:6150%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 14:47:19 +0000 To: Heinrich Kuhn , References: <20210716083545.34444-1-heinrich.kuhn@netronome.com> <20210729134711.35870-1-heinrich.kuhn@netronome.com> <2a68e3ff-93af-bc89-9f1c-dbd59d97d26a@netronome.com> CC: Luca Boccassi , Christian Ehrhardt From: Ferruh Yigit X-User: ferruhy Message-ID: <8d9f5e82-f0e8-d403-5b25-d51d05cb4e9c@intel.com> Date: Fri, 13 Aug 2021 15:47:12 +0100 In-Reply-To: <2a68e3ff-93af-bc89-9f1c-dbd59d97d26a@netronome.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: ZR0P278CA0080.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::13) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by ZR0P278CA0080.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:22::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.13 via Frontend Transport; Fri, 13 Aug 2021 14:47:18 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fc68f6ae-3190-44bd-516e-08d95e694058 X-MS-TrafficTypeDiagnostic: BYAPR11MB3718: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: EbY5PilIZ9I/olVe2vh4bHwibAHwKNQBhG3OGw3uhEVSFCHf9ep+EZv+wBAETNC/mFOBpia9uo88/Z430T8xcqk8l2+d8ZITrF1tlgIjNUZTJC9r9CaknDAzbcEQpYRQTkyYYoIfrfBK3dQszSt/btWLb16q5EPscI1N3YvrUDn1ywPNmCC18wPL+ZJQoV7QdILV7kmCDlOlyKi1WWUaXaxKhCzc0e8HLUs/lwcnljitTuD1Zb2ewRWf8JCSjYXyDkLY+e8P5kNgMbxPiGDjeDBKDKHgGCJxiICzN120kz+lgUp5jT3KKRY/zzN/H08zUhNDweXs3qYBoqIPPk2zAVGmPqSFx4osyeW+GPkZ9PVVPYDIGKLnFwWbk/zt34UlPEYoHMo2gtUh4XGvB2N2lgZkAWAFxb+407m64/nMZaeqwARXg9ZazE7xSyEghajbyROLH7UIABjZOfnZcuXNK1AdYKwrNK5nmtfcaFfo6tdERJvRtsgKr1T7r4H6NVUlFgQg4PtQ+H5uNaSW9tCYtmtwGldu105eGmsbme7O++RFexFtVEA1GflTdw9GubGxbcLFiqu6Kkznxnn09MNndByt1tS8Qe2l7sXWLbrgMIBQbyZoOF5BlHvorzABaS2jXVujvmy/cSJj5ThQVu3/x0aHxQ/TehmxDGQHABgz97gwW2O57s8NhyGrkgxIKsPhvoAMCS5J5dzQiZFxAzW68pRDQTk3fJntL1clZj5Sn5GQ8KUBmI5eO8YgLGQMazsDj6XmhwD69VTYX6Jlcts+iAOVCB9/alrlL5QVqQUY8nA= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(346002)(376002)(39860400002)(396003)(956004)(2616005)(44832011)(4326008)(6486002)(83380400001)(66946007)(66556008)(66476007)(8936002)(966005)(478600001)(5660300002)(2906002)(8676002)(31686004)(6666004)(186003)(26005)(53546011)(16576012)(54906003)(38100700002)(316002)(36756003)(86362001)(31696002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmVLYUVLVUdYckRweEUzaWgwd2VXcWE0R0pnOWlROFEyNjh2dlc1L0tNZytE?= =?utf-8?B?bFNhU3NmbE5OM0xMdVFmZ0ladG9MTFNEazlNWEdVVE9qcUh1VGVXYU1QM0dG?= =?utf-8?B?WXIvSWY2TXVMYXY4WmVGMXRhZVlPWTVuUk5NTURJWDNhV3FrcDBpeTU1d0xO?= =?utf-8?B?OW4yL2JDUEZjZjExZ1JqeVNBN1Zvc1gyMklJby9OaTc1d1BVTjB3b1RDTEhQ?= =?utf-8?B?TFZFcUNOOEYyc2FpVEVQb3NjL05STFhnVFZSVWZMS3dKZllXY0h4ZnFwaXlG?= =?utf-8?B?YXZsWE9KKzhibFFsR1IxQm5ocTA5Szg4bnNGcDJpV2xXdGdST0owYzRDN0NF?= =?utf-8?B?eFFDVU93M1g4SzRUN0lUVFhseFdqcHp1UE9EblY4TWw1V3N4N3p6SlpwOTBo?= =?utf-8?B?V2N2TjhZMndJMlFGQUlkZm11dVNzUGNGRi9KREdpTDJUNVZ3SnpwS3BlbXdI?= =?utf-8?B?UmhRV0lWeVh3RDdDcXUySzd3UWRPNlkzamdnejNSdDJaT21Rc3kxQlI2dmZk?= =?utf-8?B?emlTUmRPRllyWUVLcUQ0SXFvZHVOeUk2WHZWcisyVmFGeS9MUXZBN0Z6NEpa?= =?utf-8?B?NjI4NTR0SGY2WWNTQTY4WS9LMTFoeFBaNjNBa1dZdEZlMlRBR3h4ZkRJMDlq?= =?utf-8?B?aTRTcFZFaEFIVUQxbmhDbk1HTGxPVnhURUlYSjRDRTBuTDg1a1VMM21kSG9k?= =?utf-8?B?ZXdXbjBRWnExVEtYOFNJYjl0SjhadHM0MC9VK2lwRTJrbEkySEJRNVRnb1A5?= =?utf-8?B?eWFYaGNKZmZtSlMvVzlneUl1TXM1VlEwS3NXbEFrQkRtMFo4bnBJeUNLTW11?= =?utf-8?B?THBxaEVlTFoycU02c2JDdTAzQTZSa05HRis1OCtmR2UreEoyNjJEN1VaNzB2?= =?utf-8?B?eWdkYUlyMS9qdVNBbEwyMWkyU1ZlNHNGTzVZN0l2NDZERDByVkNDSnZkUE5q?= =?utf-8?B?ZnhWZnZ6ZGdrcGhDRTVKZENVT0NNbHliZytHZVlTMkJ5RkFrcjh4VjBJb1FP?= =?utf-8?B?b1dIUWVLWmlqL1FsYTdiL2FWQjVQZW5EWXhRWUlVQ0tyRnk3S2JSRk1QUk1H?= =?utf-8?B?MmY3OXRCMkpMeERVWkplQVZzeHorRHg0WEhiaVpsNW53MVh3L0FrcnJPa3Zp?= =?utf-8?B?a1c0MWoxY1hUM0RRQk9sVHBpU01YdVBySmp2WHNTVldvNGdyOTFQUjdyazlt?= =?utf-8?B?RjVJTlNtUjF0OGlNTDErVURlUUN5RHlIM0pxWDJtbFBiQzZpQVd6TmluZUxQ?= =?utf-8?B?NWxVTVFOK2lxZGxzQ1FSd0Z0dG1iRzdPdU9rTDVqeXUwSy9wc2U1bTlYempG?= =?utf-8?B?TEVKN1ZkWjdSU1Nyc1QvUlBoTzFTY2dxc0hIRzZFWXFaNFNMNDZOVTgyU3J0?= =?utf-8?B?OWkwVnhyYTBEanBZRWtJU3VIV240SWViUlRSb2hDVVQxbU50OVRzYzFWOWVD?= =?utf-8?B?UlpLUVpiUExEOW0vR3RoRzg1RlJ2c2s5R0lheGNseEUxeDRSUU1MYVcraTJH?= =?utf-8?B?bm9zb2ZoVGVJR0ZkMkpnRjhuZUdLdWRacjlGUHZNM2Zrb2kwQTJJbnR4Q3dk?= =?utf-8?B?b2ZKRS96cS9lc3Bucno3UnptT1Frengydjg5VEgvS2V1SEZLMEt2WndmbU9U?= =?utf-8?B?MnR2WFphdnNmd081SUh0cG1pVDdiT1JKSkV0eGdtdTY0TUtJZUlBN2grd0hI?= =?utf-8?B?KzdhVjYwVksxeTNkODlDVndwWXh5SytZUW9SMW1iQ2tqTHBOOEpjeVoyYitK?= =?utf-8?Q?EEBl/KpufkM4g8nN53k7WB/+VZ9Spumij0RPg8X?= X-MS-Exchange-CrossTenant-Network-Message-Id: fc68f6ae-3190-44bd-516e-08d95e694058 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 14:47:19.5863 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mZEppRSBgbIw/qjkMhyWSqH0099+1KWNHSoWcD2kecCw96BSyOSLFf1QFAxHx3ZWWmgqQGnFF+gdBdrUHK4WUA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB3718 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/13/2021 1:46 PM, Heinrich Kuhn wrote: > > > On 2021/07/29 15:47, Heinrich Kuhn wrote: >> This patch set restructures the NFP PMD, aligning it more with the >> common layout adopted by most other PMD's. Although the changes look >> fairly large, functionally nothing is added or removed from the driver >> and the existing code is mostly just reorganized into the familiar >> structure seen in other PMD's. Apart form adopting the common PMD layout >> this change should also aid in future feature development to the NFP >> PMD. The previous layout where most of the logic resided in a single >> file (nfp_net.c) would have become tedious to support going forward. >> >> v3: >> * Avoid squashing the new firmware loader helper added in: >> https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 >> * Add dependency to patch-93299 >> >> v2: >> * Added missing sign-off's >> >> --- > > I think this refactor is a step in the right direction for the NFP PMD. > I do have a question/concern regarding future bug fixes. If this is > merged, back-porting any bug fixes will require a little bit more effort > since the code base will differ quite substantially for some time. > > If there is a strong preference to avoid a situation like this we can > certainly live without this refactor > I didn't check the set yet, but as generic rule when there is a conflict in backporting, stable tree maintainers ask support from patch authors, for this case from you. If you are OK to provide this support when needed, there should be no problem. We have rejected only a few refactoring patches in the past, they were doing batch syntax updates or batch renames etc.. The benefit was small comparing the conflict/noise it brings. But I am for having meaningful refactoring.