From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 1BC2D237; Tue, 28 Nov 2017 22:38:42 +0100 (CET) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Nov 2017 13:38:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,468,1505804400"; d="scan'208";a="7259017" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.203]) ([10.241.225.203]) by fmsmga004.fm.intel.com with ESMTP; 28 Nov 2017 13:38:40 -0800 To: Andrew Rybchenko , dev@dpdk.org Cc: Mark Spender , stable@dpdk.org References: <1510819481-6809-1-git-send-email-arybchenko@solarflare.com> <1510819481-6809-43-git-send-email-arybchenko@solarflare.com> <0b75e6e5-b7d0-4cd5-b840-fd1208faf220@intel.com> <638e3313-89b7-8668-c059-3d4ff39e6b21@solarflare.com> From: Ferruh Yigit Message-ID: <8dab11d5-925e-e951-5a28-95cc4765bb4b@intel.com> Date: Tue, 28 Nov 2017 13:38:40 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <638e3313-89b7-8668-c059-3d4ff39e6b21@solarflare.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 42/53] net/sfc/base: fix probes in licensing support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 21:38:43 -0000 On 11/28/2017 2:17 AM, Andrew Rybchenko wrote: > On 11/27/2017 10:58 PM, Ferruh Yigit wrote: >> On 11/16/2017 12:04 AM, Andrew Rybchenko wrote: >>> From: Mark Spender >>> >> What has been fixed here? >> If you can provide more details I can amend the commit later. > > EFSYS_PROBE1 takes one typed value (in addition to the probe name), > whereas EFSYS_PROBE has just the probe name. > > Which to use is determined by the probe name – “fail1” probes are > expected to include the function result. Commits are amended with shared updates and pushed, this and other ones. Thanks, ferruh > > Thanks, > Andrew. > >>> Fixes: 05fce2ce8451 ("net/sfc/base: import libefx licensing") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Mark Spender >>> Signed-off-by: Andrew Rybchenko <...>