DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Stokes, Ian" <ian.stokes@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Qi Zhang <qi.z.zhang@intel.com>, Helin Zhang <helin.zhang@intel.com>
Subject: Re: [dpdk-dev] DEV_RX_OFFLOAD_SCATTER for ixgbe and igb devices
Date: Fri, 13 Apr 2018 18:16:07 +0100	[thread overview]
Message-ID: <8daedfce-bf0a-87f4-c219-f0f0cb64deb5@intel.com> (raw)
In-Reply-To: <CD7C01071941AC429549C17338DB8A5289214FDC@IRSMSX101.ger.corp.intel.com>

On 4/13/2018 3:52 PM, Stokes, Ian wrote:
> Hi all,
> 
> Currently it's the case that for some NICs (e.g. igb driver or ixgbe driver based), scatter_rx needs to be enabled explicitly in the case where it was not configured before.
> 
> A patch submitted for ovs-dpdk proposes to check that the DEV_RX_OFFLOAD_SCATTER flag is present in rte_ethdev_info.rx_offload_capa before setting scatter_rx.
> 
> https://mail.openvswitch.org/pipermail/ovs-dev/2018-April/345901.html
> 
> While testing igb and ixgbe devices I spotted the DEV_RX_OFFLOAD_SCATTER flag is not set in rx_offload_capa.
> 
> As these devices require scatter_rx, should the scatter_rx flag be set for them as part of the eth_igb_infos_get() for igb and ixgbe_dev_info_get for ixgbe?

I agree, since that offload is supported by PMD, should be in capability flag.
Would you mind sending a patch for it, we can continue to discuss on it?

Thanks,
ferruh

  reply	other threads:[~2018-04-13 17:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-13 14:52 Stokes, Ian
2018-04-13 17:16 ` Ferruh Yigit [this message]
2018-04-16  8:18   ` Stokes, Ian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8daedfce-bf0a-87f4-c219-f0f0cb64deb5@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=ian.stokes@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).