From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-BY2-obe.outbound.protection.outlook.com (mail-by2nam03on0078.outbound.protection.outlook.com [104.47.42.78]) by dpdk.org (Postfix) with ESMTP id D88391BB29 for ; Wed, 4 Apr 2018 07:06:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=UoDeoTym1o6TIig99biXLglRIqG3ihCByMH/szYo7BA=; b=Y8GS7odv7sm4C0CHCE/xdVFr3xugCLTD5yyfBLBqgCa3U/nNH2Vci6ewh828sz4XvKqqQ0FQVesqjuyT7zr1UvPGkikZk1060vrZGCjVhuSGnhW/KKe6Ggin7LExaIDlM14zXKRKyW4O2bZyTkkm5QmWAoGZsDY0cG8hTtZDx/I= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.0.106] (103.76.56.167) by BLUPR0701MB1891.namprd07.prod.outlook.com (2a01:111:e400:5165::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.653.12; Wed, 4 Apr 2018 05:06:22 +0000 To: Jerin Jacob , Pavan Nikhilesh Cc: thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com, bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, hemant.agrawal@nxp.com, dev@dpdk.org References: <20180319092726.10153-1-pbhagavatula@caviumnetworks.com> <20180402091000.9208-1-pbhagavatula@caviumnetworks.com> <20180402091000.9208-2-pbhagavatula@caviumnetworks.com> <20180404032919.GB8574@jerin> From: santosh Message-ID: <8daff581-a03f-0659-2bbb-ef999caaca46@caviumnetworks.com> Date: Wed, 4 Apr 2018 10:36:09 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180404032919.GB8574@jerin> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [103.76.56.167] X-ClientProxiedBy: SG2PR02CA0024.apcprd02.prod.outlook.com (2603:1096:3:17::36) To BLUPR0701MB1891.namprd07.prod.outlook.com (2a01:111:e400:5165::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fe05382e-25d5-405f-6fe8-08d599e9d121 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BLUPR0701MB1891; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1891; 3:CLW/n2Qyam5umrIfFHG4WiVh7KqkNeMYPSIm6tZZemjG+ejQ7raWUwZ5u0xQXd+1fyaqIg2SaEIcJ6RJLpAs0cbR+h8dwIjf0L3ZkvLdEoYNJZ/9/+tDELYir7r5135AV6ZsIquV7RhknVJjuULwdshk8eGYlhpJTSS+Lo7qssRNr0aZLkW0EuTn21UESArW1ArKaH0bk65/L6vOAiL3ljiA9JsP6gDoTRzwQZQCK5TVnpeL1Yv3qoGBW43LV5D0; 25:BpXnb8jow2mETqR19n2covaBtK3ZjvyJ6gAk/+2Bt//FqlPMg+9r2AzSWTCp8Cua4+xaIktHjgD2GNVh/yZc2yVVuwNLAAai1yOpfMNwj7P4sUyNjNThagl70p/W1Dq1AlZ9RQZqXvz5GhpoZDvZIebUnf43qREOaQUpQQJbJPRcXAv1v3JvQMSVJYF91BUzhMZnAV3r9d2iX7rvzz4nNA2HFLb6eb71ZeRuOCyLSAg1+hEym16xURQN6YkmIaG8vHNlYwEKQTsq3JFkqZau/2+ja6aDfrvEMGW7IDZJC7UEdBESGziEz5aQ1b2fuWtBhS6VxwpDSwkdrj7lKo42Pw==; 31:lAZuKczX6bP3OjX9TpqhTnrg1IznwPVmRsT3RTGD9p4WV/UQpgjKTMsVjBrPsTQbZHlmTpHc5qp0rYpPd2Dl27YLhq9YTHN2c1owmwIw+V41GPhdXcSpFLK/7nD9jCev8JTcCU+7bl+3PQ+ssb09CCqwqJosvVd0Rb9GtnA5FtD1TrnSr0aO6ciOLnQoKFPs5toF6T+owwO3cCchAMaFoTW76H14pFn3Ab2cbHohuYU= X-MS-TrafficTypeDiagnostic: BLUPR0701MB1891: X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1891; 20:/5YtIGpamnHuBal7a+tvdVQ0VzjITOK8s3PT+q75WdqqSyyyotq/wr9a4CYAFUbY5dyKxCAEKxnydE26p+0jnAOG6wxVnWQ5z85nD3tASUe7XtbEqwnk+TDSwtD7z0fBncpmzLoX6w6WYhyS5kEPClMAse6ITx/wwPNxS+UCtccSgkukLOGtRDhYVL+dr5o6KflelaWXf0oV7F4eD+UimA/t5uBN9BUKBxgvxYD9n3DYoXz+cpsU7IXmEbWbYNZ0PWvSwRcwJsgs27WCcYEBSPcKDKFr9ocfTPmy3Kb2vX4p+MD+c02XVY/gpGJWmzCZj4Ecqr7r59h6UrbnHlKei3WJm+LVZXoCLS8G0DfJYgNqp/ceJXan70O7dad/ygAQFUuPjlpw5/XvSB4YUOTZTi67Nr7Fy/e8zq/X+0SJo1afNLcBM1ksEhqL0Ak+npMAVUDYp2GUcW/9dfgQQ0mU8tlN/Bh8LLNnLF0tOSHs6qBSBwXXcJ2QFUUvma4qNeUpORDP58id9uPsIo5cZf7shrKRkKDrHY/hlkVKxY693Itt5EIAoycalQgrhEsS42HEhB+jyndYFY7tSrNgXC/x8vPqFQl/nYWiDVTxq7f0sxI= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231221)(944501327)(52105095)(93006095)(3002001)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:BLUPR0701MB1891; BCL:0; PCL:0; RULEID:; SRVR:BLUPR0701MB1891; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1891; 4:onVNNX9VmqvdSvs1Jpi0iXSl7ufChVDc3075nWeb2x4xwp9PLlB+KgqNtZrMYY3+Eml9k3Cmc7kyZ0asvZYoqRwMYaGkWDpsIO5n/dtAoczfgxxFhlRUYsOS62nZCKwpXlDENL8dLmQ3LUPL3/gHwe5YKVBZcd5/a4Dsj/2Nt1twagM+jrzA/HWEM+y7JVcIVQmM9RigDy3sHxH+HVzQpb5I/Suq4Ey7n6U+N7df8VSa70bWqthwn0PDLOUe0XI062QhN7KRbGB320QtS+G/UlTndoowCxkicmG943F/uQfTFE2LmVHvTyIkxid3y80OQK5T1lER2N8GkZh4aYN/uNW0aQ0q2B4J1q+86q9UIrs= X-Forefront-PRVS: 0632519F33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(346002)(366004)(376002)(39860400002)(39380400002)(189003)(199004)(13464003)(26005)(8936002)(956004)(50466002)(305945005)(7736002)(64126003)(16576012)(2616005)(186003)(8676002)(16526019)(4326008)(446003)(52146003)(6486002)(72206003)(97736004)(52116002)(2486003)(23676004)(11346002)(81156014)(77096007)(5660300001)(31686004)(8656006)(110136005)(81166006)(58126008)(316002)(85306007)(86152003)(386003)(106356001)(230700001)(105586002)(65806001)(36756003)(65956001)(6666003)(66066001)(25786009)(3846002)(6246003)(478600001)(31696002)(53936002)(42882007)(68736007)(117156002)(229853002)(65826007)(6116002)(76176011)(6636002)(93886005)(476003)(59450400001)(2906002)(47776003)(486006); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0701MB1891; H:[192.168.0.106]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTFVQUjA3MDFNQjE4OTE7MjM6YllVcmRZZElPeXJJRnpxTkpMcjNJWldN?= =?utf-8?B?TnlIcitKbGJKbEtkVU8rY3ZEZk83c0NGZ0x2ajB5Qkc3NkYzSkVnVGFvbmp3?= =?utf-8?B?ck1Na2JlWHdBMlpCNCtjTFc0a0hOWkc5aWtuYXFsTk90MVhDSzQrVGsxNG44?= =?utf-8?B?bkgrUzRkOEFmMGgrelowcFB0alRIVUNyZHdYK29hSjdqaEtQQmkxS2JQY2ZB?= =?utf-8?B?L2JVZ3M0OUdjWmtVTTNGYUZMSWo3Y2pkR0dZL05iblg2UDA0QjV0c2Y5WmN1?= =?utf-8?B?T2lreXlETCt3aVYxQ0NKNk8xNzRpdmx5NjF4YzRkNXdITU5aSjBFM1k5SGp6?= =?utf-8?B?cExSVkZXU0x6Q25CNWJKR3B0NXdML0kvMitMOHJpSFpvSWN5bkJpMTlGWUJY?= =?utf-8?B?UmdJdGMzbkloU2hKcHJ0a0svY3kzQVdtZ09BOGdxMXlodDhKeWxSQXE5QlBO?= =?utf-8?B?Q1ZFeVdtUlpra1ZuaGt6ZnIxbjBtZDBqdjA4NGdZU0VPK1FueDNHRW9UUmI4?= =?utf-8?B?eE5UWjZ5bXJtN0h0NVVFK0FjVUJzMlR6Rnk1K3liVGpvaFMrM3o3VDB2UFFq?= =?utf-8?B?US96WGNrT1lRY3NhUURTZUFuYlRsMGpqTkhuamVEajE2c202OU9MQklTdkVq?= =?utf-8?B?VXlLS3NDaW1pcWoreHFjVVBxREp3SzdVM3FrNFV0eCs3eHNLUDM0c2Rka0JW?= =?utf-8?B?cVBYV1RvNGJYZ20rVHFsUE9sMldBdXJGNnFQQ21pU3Z3NmRlM3RqbzluUTVW?= =?utf-8?B?ZC9XYjBnV0RDcGdHT3pJcFovY0V1ZmpqU3RBZHZLSnFLVC9ISTFkL2VVK3Ny?= =?utf-8?B?Q2ZVRkpseDZpbWIvb2k5R20xNDhDVmEvQzNNNklnMzRhcnNwQmRNY1FXTTJT?= =?utf-8?B?cTMwbHdNT0hKSmxxOTBKSS9aYjRRWmh0Wllrc2F6WTBFcVk0MzFFSkJxQTd5?= =?utf-8?B?ejUwbHE2dlJha25hY1dEVnRGcHNHN09ZZEhLdVZxc0pEdzZVUFM4UWxCMVhP?= =?utf-8?B?dmNHSW9DQ0FQV2JvY2ZrQXJxSmxrUkxTczVlbkFqZWZVSmMrNllQeitxWFc3?= =?utf-8?B?V3pONXhZUW5ocSthd1Q2TUxYRE42ay9xSEtydkNEa205UUl6anZRZUpyV0dB?= =?utf-8?B?Y1FGeFJZbTBmQnRPTjlabmtoS1dxRGV6WU84bmRiK2RwaEhMaHVDNzBHc1VG?= =?utf-8?B?ajlCYWxWODkwSVVGem5lcE5kcXB1d3F2ZXl2TUcrVGROL3d2VzJlWWpzeGF0?= =?utf-8?B?VElRcDFJdUxiMGVCR2NkL1MrMXhLY2JiMks0NzBtaENCeGYyM3NON1BES2Fs?= =?utf-8?B?TTJaOVFheEhYWG90S0NyYk9nNW93UXZ3dWRjelFSbHdxamhTUnZEbzg5R05z?= =?utf-8?B?NVZFeE5iY2x6cVdHTllhRDlJODdlU2dGMjc4R3MvL0QxOUFZSjdXT2xFK2RL?= =?utf-8?B?dlM1YzYvemd5bGNiUFh2Wjhyd05aa3JEbmtiZVBCRDdhSjJRdGVINzEyRTVk?= =?utf-8?B?U0hORWJaNUhWZW1taUhUcXJybjJXTitybEtKem9ncDd2WG1pWXJ2UFd5Q1Yv?= =?utf-8?B?M0liK09PakZIV1pCKzRoeFpqUUdUbVBBREZsUldmUndBdEVVQThXanowbU1M?= =?utf-8?B?Q0xvR3VIS28rNkJKR2o5dmpBSzRqUSt5aENubmtpYUlTaW9tOTdTaUIrTUQx?= =?utf-8?B?NStzWGJNcHZMSzVYRTUrN25ZSjZoTkRBT3JwTWhKaUFqeWE4UDExaHZyQ1Na?= =?utf-8?B?Ly9kOXpPaHFWL0VIK1pZc2h0MnR1Ums3WFFLZW5LcXlybGFJMk83TVo2aG5u?= =?utf-8?B?dk16SnU0UDhDRXpEUzVhZWlWQ0hOcGJQU2szaTVTOVFhbEhHZzdGKzN6K0dv?= =?utf-8?B?WWFmWTRKQzZIVTBZaVFrY1J6RnBUSzAyVzFaNU5vNkZLdHRGNmFLZW1xL3or?= =?utf-8?B?ck5YRkRKVUZFR3lFMGN3Q2xzYVZ0YUR5S0NZWjBQOWJCM0xWVUtTcnNLTFc5?= =?utf-8?B?ZEpHdDI1cWMzb3lKdFBIUW5qazkyRjVCM2ttR2s1M2xhS29XUmNJamd6UzQx?= =?utf-8?B?V2crRVQ2aHdKcHNRWCttN1lLenVhbnhFa3hvYSt1ZjRQalcrVTRTVFVLelRQ?= =?utf-8?Q?HP/hILpcOIUxvL2qk9Jj1fQKlpf9vD9lrlLkbc5JDnk6mR?= X-Microsoft-Antispam-Message-Info: Ao0C0RkJCNC/sc7KI1qfQbtUNcKcYdq2kdb5+XMqGSkouXgsh+Lx61And0djgD9HgkC7O79plSllxwI7R5GHpm77vsl4tt0VhggptXd05BzdMKwhZqPEu/Jaebyxme624vWA6u/6BIzj/SMcfAKxJrN8jfOUD9badCUDuvRCJm0yoV2bxnMswEWztxa+fl2y X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1891; 6:u2aZqYNW+VHMq5GqlSGMTfExZQkJ+AhawUh2mdH+SsVvAmNLvI0IANTbPegYygron/h+dOb594GHiNtAqpZaQHUyoBYLfxwpIehkay4BFfVenz6bRrpKBapB8HrxuA3EzO8ozelwGBP/cyc8Hni+6m79i8YJAdo9VrTG0taSS7zrVXJ8o8GilJxV7yz6h+P8DBTscHFuxIh7BTi9QUcQeqtDgVFJDc2F+5II44AsapGo92ICNj1QjJyf761r/8QA6A43CMw+DivGq0yXUDSRugSy4JXWxyGAsZR67lgQA1IbMnXoqtnA5XHTMNhEZlAl33Z3wzCP/8rSrndusv7mVdkGO9NjpQL5BsEcONCJtvDgxOg2EfmnU2CDUjkUrwGpxKkWhOD3n+jJddl0yBmEuPyy7d+KNip7z0wBw4Y7FJdSNRxfs8+4KBPXT6/KQyuvICdBklVsJ85EBQtzv44B3Q==; 5:tcdPTaYtVPbuWLCjmQ6Wtd3Nz1Wo9N6hKY8A4OR8nfBSgaJsA5zyFFQawy2i8iiS9dOviF5S638PyukEQHSB/r2gDwu2Tn3vAhBBsfzT3bOpae9QhD5Kggrevk0HCgeclB3aOCsa58dLXjCZ8RZYEy0ew0idyh0s9DflYE0yZY4=; 24:UnBeG/ZLeqLefnXQlp/8p8NnFbXcGMQ8KYiMbRgLribQDVgQVXUb/GQzE4zCBOlwMMX+g9R1HkiSQPSZCWV5lxYKyG9RrwjW8amMlYNgOxc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR0701MB1891; 7:MzqaTw6EicrY76voTkwrhARIoPepDDfe6l57APnPTTihCoNafIzJR9NAWtoEwweV7SUPFsw3DHcwtazPuXu611zqg98ibFeTV867vqMl/c6uP4yZWGAaLFDC001uC+gZ6DwqOaFsD2DKbSnh/ogIVlyV4QlFpj53ztRaaVKArZcNcaVHuhJCJ3ZT0ypUV1nOFHIUWGdvAjPMQI8WafIlAtzS6yNt8WRjQI71M/tZFKA+6N2ECrNkQhfeQBWXfXfD X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Apr 2018 05:06:22.0021 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fe05382e-25d5-405f-6fe8-08d599e9d121 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0701MB1891 Subject: Re: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Apr 2018 05:06:28 -0000 On Wednesday 04 April 2018 08:59 AM, Jerin Jacob wrote: > -----Original Message----- >> Date: Mon, 2 Apr 2018 14:40:00 +0530 >> From: Pavan Nikhilesh >> To: jerin.jacob@caviumnetworks.com, santosh.shukla@caviumnetworks.com, >> thomas@monjalon.net, anatoly.burakov@intel.com, lironh@marvell.com, >> bruce.richardson@intel.com, fiona.trahe@intel.com, shreyansh.jain@nxp.com, >> hemant.agrawal@nxp.com >> Cc: dev@dpdk.org, Pavan Nikhilesh >> Subject: [dpdk-dev] [PATCH v4 2/2] octeontx: move mbox to common folder >> X-Mailer: git-send-email 2.16.3 >> >> Move commonly used functions across mempool, event and net devices to a >> common folder in drivers. >> >> Signed-off-by: Pavan Nikhilesh >> --- snip >> vfid == 0 ? >> >> + ram_mbox_base = octeontx_ssovf_bar(OCTEONTX_SSO_HWS, 0, 4); also ram_mbox_base may throw build warning in case vfid>0..right? >> + if (octeontx_mbox_set_ram_mbox_base(ram_mbox_base)) { >> + mbox_log_err("Invalid Failed to set ram mbox base"); >> + return -EINVAL; >> + } >> + } >> + >> rte_wmb(); >> mbox_log_dbg("Domain=%d hws=%d total_ssowvfs=%d", res->domain, >> res->vfid, sdev.total_ssowvfs); >> @@ -213,6 +221,7 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) >> uint16_t vfid; >> uint8_t *idreg; >> struct ssovf_res *res; >> + uint8_t *reg; >> >> RTE_SET_USED(pci_drv); >> >> @@ -246,6 +255,15 @@ ssovf_probe(struct rte_pci_driver *pci_drv, struct rte_pci_device *pci_dev) >> res->domain = val & 0xffff; >> >> sdev.total_ssovfs++; >> + if (!vfid) { > vfid == 0 ? > >> + reg = octeontx_ssovf_bar(OCTEONTX_SSO_GROUP, 0, 0); ditto for reg. >> + reg += SSO_VHGRP_PF_MBOX(1); >> + if (octeontx_mbox_set_reg(reg)) { >> + mbox_log_err("Invalid Failed to set mbox_reg"); >> + return -EINVAL; >> + } >> + } >> + >> rte_wmb(); >> mbox_log_dbg("Domain=%d group=%d total_ssovfs=%d", res->domain, >> res->vfid, sdev.total_ssovfs); > With above changes: > > Acked-by: Jerin Jacob > Acked-by: Santosh Shukla Thanks.