DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ray Kinsella <mdr@ashroe.eu>
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Cc: david.marchand@redhat.com
Subject: Re: [dpdk-dev] [PATCH] devtools: skip ABI check in static builds
Date: Tue, 21 Apr 2020 07:11:41 +0100	[thread overview]
Message-ID: <8db28849-b64f-75d7-51f9-aeade8e7203b@ashroe.eu> (raw)
In-Reply-To: <20200421013329.287556-1-thomas@monjalon.net>



On 21/04/2020 02:33, Thomas Monjalon wrote:
> When running make with CONFIG_RTE_BUILD_SHARED_LIB=n,
> no shared library is built.
> In this case, no need to run ABI check.
> 
> With meson, both shared and static libraries are always built.

You can easily do the same thing for meson, by checking the 3rd parameter to build() in test-meson-build.sh, 

> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  devtools/test-build.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index a298115002..6e53f86fc8 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -262,6 +262,7 @@ for conf in $configs ; do
>  		EXTRA_LDFLAGS="$DPDK_DEP_LDFLAGS" $verbose \
>  		O=$(readlink -f $dir)/examples
>  	unset RTE_TARGET
> +	grep -q 'SHARED_LIB=n' $dir/.config || # skip ABI check with static libs
>  	if [ -n "$DPDK_ABI_REF_VERSION" ]; then
>  		abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION
>  		if [ ! -d $abirefdir/$conf ]; then
> 
Reviewed-by: Ray Kinsella <mdr@ashroe.eu>

  reply	other threads:[~2020-04-21  6:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-21  1:33 Thomas Monjalon
2020-04-21  6:11 ` Ray Kinsella [this message]
2020-04-21  9:15   ` Thomas Monjalon
2020-04-21  8:02 ` David Marchand
2020-04-21  9:20   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8db28849-b64f-75d7-51f9-aeade8e7203b@ashroe.eu \
    --to=mdr@ashroe.eu \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).