From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0066.outbound.protection.outlook.com [104.47.32.66]) by dpdk.org (Postfix) with ESMTP id CF4412C0C for ; Thu, 13 Oct 2016 08:46:16 +0200 (CEST) Received: from BN3PR0301CA0024.namprd03.prod.outlook.com (10.160.180.162) by BL2PR03MB324.namprd03.prod.outlook.com (10.141.68.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Thu, 13 Oct 2016 06:46:15 +0000 Received: from BN1AFFO11FD008.protection.gbl (2a01:111:f400:7c10::134) by BN3PR0301CA0024.outlook.office365.com (2a01:111:e400:4000::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11 via Frontend Transport; Thu, 13 Oct 2016 06:46:14 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD008.mail.protection.outlook.com (10.58.52.68) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Thu, 13 Oct 2016 06:46:14 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9D6kAMi026098; Wed, 12 Oct 2016 23:46:11 -0700 To: David Marchand References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> <1474985551-14219-1-git-send-email-shreyansh.jain@nxp.com> CC: "dev@dpdk.org" , Jan Viktorin , Thomas Monjalon From: Shreyansh Jain Message-ID: <8dc0386a-f8c0-5c4f-9ffd-2eddaa68cfdf@nxp.com> Date: Thu, 13 Oct 2016 12:17:39 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131208147744930571; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(339900001)(24454002)(199003)(377454003)(189002)(68736007)(97736004)(19580395003)(8936002)(6666003)(85426001)(50466002)(19580405001)(6916009)(4326007)(65956001)(87936001)(65806001)(31686004)(47776003)(356003)(305945005)(2906002)(23676002)(83506001)(4001350100001)(2950100002)(86362001)(36756003)(92566002)(7846002)(65826007)(626004)(77096005)(104016004)(106466001)(230700001)(8676002)(5660300001)(81156014)(81166006)(105606002)(189998001)(31696002)(586003)(11100500001)(110136003)(54356999)(64126003)(33646002)(50986999)(76176999)(21314002); DIR:OUT; SFP:1101; SCL:1; SRVR:BL2PR03MB324; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD008; 1:4fugk7nKiHzA+EjPnWfPCYS5ZBOwgixsFiU5J4Aluyyf1G0YOGVs7vZ4wwX4H6uu/Oj1UzEAu6IfXBp8gI+R2TaDDA8nFnLYVP5Tfu9IvQdhB/ksz3gmGEOvSN8MO04qV/6dNWib6jYGUTiGmACMqGYxM/xHYU30yEd195XGY1q+42QVrBNa2lpo0hH9jSvGPpSITTPtFy7bBWgfmDXUB3t2gE+y1YNmTPGOK0dMPtMWR9cg5RWd9o4TfmcQElbVVGvXmfLhU2OhhIW2MbM1QDk51KX+qmdn0Wl/thbigNkgn6P6u/M+Ci8jjc5uzvhXIcCOSUULk/WNM8tf0wltGDwOhLechr/ekrzDbxQ8BPDvNLj7VK7f67a8f2/5inhdjKMx96ieZoZXF2DKQybN5oo5brlV8XY0GBy9um+5LrhKe17P6o6xKN+JCHQjl25gGGsI3LfkMkdAP9xYbiFzesd6oXZZc140f/BHBFcfabh1CWyOc2o1T9pj+eKRGHyDNUwkGjXocIQuJGj/DuEm/VXRJeFmlJOQlSFG4ZqfXJ2z0gdt1rrTK8OsrJV64RQnczHL2xtH3H1IlvMOFkYgbQ== X-MS-Office365-Filtering-Correlation-Id: 89fb8513-1431-4461-d9ab-08d3f334a06d X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB324; 2:yYq9i5yCRSiUob1Esv9hrf0FA/+hKOnTAM13cHBZCxzp+ipjdlPDHvzCgwZo/734wHQwhEMHKu0vAS2WyJYRz4eYrgpYZp0At13IVFwOMebZs3KbN4KstdTQ5JIZMY6PggwAJ6rxojlKQBZTSAsBYlNawFHTr9kd0KzSKCTU6i4Nk13TBDJk2jCl+ex/GDJuJlP12kUnw5gvUnmlOQXCJw==; 3:U1FCEpX7txmfi8/QTdJPRFFOsxSKtUcr7au3Mi1q1O+tZYHyKHQS45Ge8u4L4aNtQ2C2+qYW7BqUxl3+Dbsc5uP3HZZSpvZXKUoagcMTbfmMnDS7sVZH+GhTQHBKeu/I5cmEZTuROOI3T+tmejckTmA/ZUfAZ8w+u5CjepE2axNAKCvP92Iy4anLw4XgKXpqjAeBzZejHdMU2fZCl8L9zD3yhFMHX3gd1Oo2AneVWNkC0QEtAJEEIjRz3EEPDVj3; 25:sTSeR/fAEQ/u1oSzCkrVZNtGqrA2xqbwyF9WoYPZj/cnttIA3s0VCucLtgZJDgUvGQ26dejnJFOV02ks3PZuEsJp/00ErgJhKjvxihe8uoLeLICLDgXPL8UuZ3rjOHOqID9RuGWZiP9foXrujPKuCTKqvJSlto4b/trT+xhXS7TCIqU372c4Ac/43ISChzIv0aPpgEE3yamRk/sbrxCUZWs+SeYJFYN1qWEsWSxMwiln2mzcl4cqyv5l/WugsfU/nfkpmhxmz1WngmUBX/3joKQ+rA9xSlHUCQh2uhvHi/N/oq0HPpsZql6X+gEnr804DaF3LNI+uYT+YuWYtcIpGKZxTjsHhA2rTc6LCVSeQUlQT5gyT78EjWsBvW8ZK5VS1cKwYo8ZU8EzwWuyzpGqiVmsGoKsUXj21UiDHRo8DfQuWB/wgkj9c0lFgxNL0J0kls7VW5xxtGzG9Wg6dCPOfA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BL2PR03MB324; X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB324; 31:K3vSpT7muA1J2lIWMTEaX7832KxMt0cy7iloFybi9dCTT3RYc02e0wR1r/cg2O1shEGq/YDClC7+yaKajBeJNFXySgGZ6WiV17fD9dcDKRQH7Eek8bj1GBqKVvTQ74zxPV7w3jx/bRwi0bpxEVh1yLc7WIADA+vRgnUy1XHeGFyYov4lygBVkTx8WLn8hqqDcqOLT5bkSG+TEI+TWnzHTJY9dESdmGHiBnQu5Kz1BGbxSBW0+bUBfFVx8byI14lMWOELaG9OsqsHHwo1114+esgq6O5OIeZt7Gb1c5UELx4=; 4:Pfu9LUDnRqFPlpjO2gDmZTpIfKu0Nd6js41f/uFEPqjuY/9YqkuHBUxAEq8M+NbX/vQZqEh63Mj5/UeE2Oh2EzUhKTvzNKeJBNC8/oKqtNeyJosH+k1sDDvy1ia90Qj2gNigotbpyLybU4wB3Y0Avw1eeIbFeGJieC6dtHI9sDe+e5N0JjGzsZzw9GmaSGl8RQfubEBOz6dBppgBqo7UUvyfvseoMzARlZDKvv/g3f27yK2u2vsjNhS5687IkBcTk1mUgBBccee2iwKGI1aqofupJtsiEoBSCBesx/v/lxDRAGI451y85snlrlhYK9ib9bOyyjljcUqvCXQyrlQle/1e6zLHTVwSlGHgQhGTqzsm5SVkXhkaxDgajQ1s7Q4ArGfydiM+4zZNtDGijFHMZ3PvXNDr9pwJaghjBO8bk26WMjvojH1r7JpNuzlk0JTHWYMOAFRgiqobZKa1zRLlMOk5F/sdKiXesgmJbnOlEPoGIAjO2jB1NwSZweycR4UTu+D7enp5oAg45RyhYg8Xyne74pZIIEAJ0nVTr2Jft43b8fdzZ+dDJQMlRmQJABCK X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(13015025)(8121501046)(5005006)(13018025)(13023025)(13017025)(13024025)(10201501046)(3002001)(6055026); SRVR:BL2PR03MB324; BCL:0; PCL:0; RULEID:(400006); SRVR:BL2PR03MB324; X-Forefront-PRVS: 0094E3478A X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTDJQUjAzTUIzMjQ7MjM6aFMxd3UzMnBsNVB3Q0Z6QVFLTmFpUE45c2pS?= =?utf-8?B?Y0ZnN0V5d3VsMkxjb3hkM0xRT1pPbHFFK0dhMVJHVzNaTmM1V0ZDdHh6dThq?= =?utf-8?B?YS80WHV6ekxGcHE0SUdpbmVuemNUZ3o4RmZUcjQ1WlFhQVFabmxNbmwxbWZk?= =?utf-8?B?Q3kyUit4bVJya2FtaXE4dDUrZmJtekp6QVM5TlZPRnVGdVFnRWtmT1Jja21S?= =?utf-8?B?TSsrTnlmdlExekF2TTlaYndCZno3UGhZT212bzhubWNDMzBEREJlS2l0dVhz?= =?utf-8?B?LzZFS0FjYUU1RUtJRXhaWkRKOWVWVEZmMTJsQUJqVnFIQk9JUGlscFdIelZ0?= =?utf-8?B?bWdQTVZ5M1R4VkZ6RTZsaHRBa1JmUHpZVG1OTC8rcDFIb3h3SlRQcXdudnRB?= =?utf-8?B?R0QySFR0M1B3NVA0Ky9mZmJOT3ZVNmtUL2lsbk5SR1k1cUZrdDAxS3ZHZ2Jo?= =?utf-8?B?c3dUR3hjMXlMTkFKd1pTUHhINzVDeHhWOU53SG5LNmdoYVljNE4xMjNvRWRo?= =?utf-8?B?RllldEpBZmNRaFhjUHNidlcyU1l4UXFaRDZXNDkwd1JtL09VOUpWL3FqMjJF?= =?utf-8?B?WTcxRXBINGUrQWJvQnN0c1djbjhQeUhrMkJRZVgzUWZVRWZZYmEwVmNvSkJz?= =?utf-8?B?WU9OMVEzQjJ1WE1FNWtZWW5oK0thNTg5VHFsU1lRK05XSEM4WTFZL1RDaEdh?= =?utf-8?B?QW00aXpTMktOTUhOUURIYU9CMTRiSFZlL2o2a0pMV2RNR0tjK3R5aWRVV1Bt?= =?utf-8?B?ZzcvRi9iQUZaV1lPS1hSMGlWMWU3UTB3M25kczJ5Y0VBN2xvdEhOb0FZeDA4?= =?utf-8?B?WWNPblNVWVM2MkdTK3lyR0dzY0VmTWhvVG5qR09oaGowV2wzR25CVVJaUFht?= =?utf-8?B?TkFRSWNhb0FMTWxQd1I1bWlnWDE1bDZKYkVqQ1l0bHF4K0F5YzNEZGF5cjJ6?= =?utf-8?B?d0NEUy9zUk5PZE5ZRSt1UDlkRlBwVUJVdkJ4cEtPZXR6cGhMTUNjOWFubFZ4?= =?utf-8?B?NkUrT2xFcWtvUDNqZmhRZUlTaEIxRUoySk4xaEdBNzgxNnlQMXNxb3laK1VN?= =?utf-8?B?bCtFZ3hEUjFqSXloaEtaQTNIRFFEYkZGeEN1YnhwWHo5b09uMHRtYXdESlZr?= =?utf-8?B?b3VOSzZ1cmZ6aXNXVEoyL24vZk9hR2ZtM1cxTVBCMHZ6YVlEYzdPZUZ0aUpF?= =?utf-8?B?YVB1ZDNHV1NvaUZmNytZejVzVEpPMkh2MzBPZkN4aUphMHhhNlZrSG9zYVFX?= =?utf-8?B?dy9TVmVXeXM3blZEcEs4OFNWSitLbUdSNFk1b25FZUl5c1hMTUVIRWVlS052?= =?utf-8?B?QmxkOWFDaDd5NUVDdlU5WXkyLzN2RGQxUTEycHJkWFdtMVQzQkJiRGMwNTFY?= =?utf-8?B?UlM4VFZVbkNLWkZNek1OenpoMjdmRERtbk9pRlJGbnVYbmJvbTc2dWFpdGxN?= =?utf-8?B?Z1U3d2Q4aGhqVGp3K0VOOHlSRU5ZUHNNKzM3ZVFDMGh3Uk1xMUZoRmtTM0tW?= =?utf-8?B?MXRXTTZlKzdlaEZqK3h0L0tIejQzR2dlRG43bzRrbGdGRkNmYjRDQzdGQkQw?= =?utf-8?B?R1dCRCt0V1lRbHY0a2lnVzJrd3BlWEkzSkJpSUQzTnRBUGM5VE1UTWliRmRV?= =?utf-8?B?WEQvTjBaVEFIbDZxMkZoTTNXbGlINXJ1akdLdTJwUkovNlF2RzVmTzFNREFO?= =?utf-8?B?UzcrYzZHV1ErUndGaWhzL2YvNHkwMEhqUkp0dys2T09WMWkzby82dzJOdm4v?= =?utf-8?B?eGowMjVqYkN4alNYQUQ3dVlpbkRmcFdDZ2JPVTB3ekNGRVdGTUp3NDhYV3g1?= =?utf-8?B?d3pZWUVoWkZMcE8wbkJRV3hzdkFVMHFCamd2eUNLaWFZT3U0UzYrMTQvZWtz?= =?utf-8?Q?RO4pmViV7Y=3D?= X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB324; 6:hAGHOZBIyE8ZOt4Zh3RVv0S1NyksQ9onZOhh0qhPdK84cBqW2K41TKc37wI7YuFXSpZwKmxT2tqCZVGFgc2QNbwD2F1gAYIRrp30LCYegWrSa1jcVQngYMAnf7m30Fqkm/8piJm9YpmvFDIutY0YI+SajEHXUajtYSiUFtyXS6m6rSj+cGtVSu/zpe9ZQ5eVhG7GSMo9MPJyeOcGUNty79PH47j+0mX2PkKiVdp+10r+qZMp699zwzMyStHeSB4zZrVKvedPPAE877F7Q45ek+3D/IBuu2WHdd7l6wtqTsHNGsZWiN96ts2wN0lJpP+1; 5:tQqUbMHVdj2tPqXGwpBvwz+0moafnzu7l/M8adEl+EcnMjzzZvb3W9FkR575OKgxpoTx2hZhAEwvxMy6xPOPs9bwl4HIjtcEw6k+9RD6Wf5UEMvaBubxtghrC+2uY5NGjK/1aa4E0XlMF4j16hVp0U0lUvxyulu6n8MmFYbC4uzPQa5UyFrbbRwDWK3MoksI; 24:X6k0YrEzwHR/ahKrHVusOiiY0O0xuL08HUoktqscicInbPsW/SB9vh6a92JDlwE7fqYeTn1YxWkA1HnylKUR90pQmjd7iTVyH4Y9WX/xZHU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BL2PR03MB324; 7:1BpMgTpf4bXPSwgQvuu9y+XIKJAdeyMep4/8qEeqdskI7lpomf5TD0xNhYAw0aJ5HSnyZb/QDFLAI09u1phxnvQzLNtv1Kb2PkChpeBvQ8OmV+BK82XzyOZ0Mgpg1pvj3gUHoFv4/b2YLQT0uRguOx/RsIV0pJrgKA+0GXki5WNVBiSvQo/kCUiberG3lq4DQ88SYQ5d2zTTa+sg2diyYKVouN73p0E8vTCa09GVKkhF90SpEqypCjTJfSYOMRtSU3mTCkCZTGQLEl9O62TUed3sf/zwvGAd4/uuEoRUa/MRruYraGr6s04MFJRb1orlX1ZHxVcXiKPcATvz/g7nqXIceOnsCmeszLeNnFEOO78= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2016 06:46:14.2434 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB324 Subject: Re: [dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 06:46:17 -0000 Hi David, On Friday 30 September 2016 09:01 PM, David Marchand wrote: > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain wrote: >> (I rebased these over HEAD 7b3c4f3) >> >> These patches were initially part of Jan's original series on SoC >> Framework ([1],[2]). An update to that series, without these patches, >> was posted here [3]. >> >> Main motivation for these is aim of introducing a non-PCI centric >> subsystem in EAL. As of now the first usecase is SoC, but not limited to >> it. >> >> 4 patches in this series are independent of each other, as well as SoC >> framework. All these focus on generalizing some structure or functions >> present with the PCI specific code to EAL Common area (or splitting a >> function to be more userful). > > Those patches move linux specifics (binding pci devices using sysfs) > to common infrastucture. > We have no proper hotplug support on bsd, but if we had some common > code we should at least try to make the apis generic. > rte_eal_unbind_kernel_driver() defined in the patch is essentially a wrapper which can be implemented for Linux as well as BSD. Just that in this patch a ENOTSUP implementation of this was not given for BSD. I can think of two options: 1. Implement a ENOTSUPP code for BSD and allow rte_eal_unbind_kernel_driver() as part of common/eal_private header. implement rte_eal_unbind_kernel_driver in BSD as not supported. 2. That we keep this contained within Linux area: linux_unbind_kernel_driver <-- pci_unbind_kernel_driver ^ `-- xxx_unbind_kernel_driver bsd_unbind_kernel_driver <-- pci_unbind_kernel_driver `-> this returns ENOTSUPP @Jan: any additions/suggestions? - Shreyansh