From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 540E811F5 for ; Mon, 28 Aug 2017 11:32:33 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Aug 2017 02:32:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,441,1498546800"; d="scan'208";a="123196328" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 28 Aug 2017 02:32:31 -0700 To: "Dai, Wei" , Srinivasan J Cc: Thomas Monjalon , "dev@dpdk.org" , "Lu, Wenzhuo" , "Ananyev, Konstantin" References: <1492685271-7583-1-git-send-email-srinidpdk@gmail.com> <6A0DE07E22DDAD4C9103DF62FEBC09093B59C4B1@shsmsx102.ccr.corp.intel.com> <3282640.JDCqqrB9e9@xps> <49759EB36A64CF4892C1AFEC9231E8D650A7D260@PGSMSX106.gar.corp.intel.com> <49759EB36A64CF4892C1AFEC9231E8D650B64CD9@PGSMSX106.gar.corp.intel.com> From: Ferruh Yigit Message-ID: <8dc70a8c-28a9-15e3-b731-c3f441c68522@intel.com> Date: Mon, 28 Aug 2017 10:32:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <49759EB36A64CF4892C1AFEC9231E8D650B64CD9@PGSMSX106.gar.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot swapped SFP/SFP+ X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Aug 2017 09:32:34 -0000 On 7/18/2017 3:56 PM, Dai, Wei wrote: > HI, Srini > > Sorry for late response. > > As I have pointed out that Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw) unconditionally, > I think it is no need to call hw->phy.ops.init(hw) after ixgbe_pf_reset_hw(hw) at least for 82599. > I also think that only moving "hw->phy.type = ixgbe_phy_unknown" just before ixgbe_pf_reset_hw(hw) is OK. > > What's more, how about X540 and X550 ? > I have just got a X540 and a X550 NIC with copper interface, so I only can plug in/out the RJ45 line to help test it. > > Is your patch designed for plugging out original SFP and then plugging in another different type of SFP ? > > By the way, I'd like you provide more details on how to test your patch? With testpmd ? Or other app ? This is an old patch, with no update for a while. If this is still needed please shout, otherwise patch will be removed. Thanks, ferruh > > Thanks > -Wei > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Thursday, June 29, 2017 9:00 PM >> To: Srinivasan J ; Dai, Wei >> Cc: Thomas Monjalon ; dev@dpdk.org; Lu, >> Wenzhuo ; Ananyev, Konstantin >> >> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot >> swapped SFP/SFP+ >> >> On 5/19/2017 11:04 AM, Srinivasan J wrote: >>> Hi Wei, >>> Yes the changes are in ixgbe_dev_start( ), the patch shows >>> the function as eth_ixgbevf_pci_remove() probably due to the way diff >>> recognizes the change. I have tested the change using Intel >>> Corporation 82599ES. >> >> Hi Srinivasan, Wei, >> >> What is the latest status of the patch? Are all issues pointed by Wie >> addressed in the patch, or are we waiting for a new version? >> >> Thanks, >> ferruh >> >>> >>> Thanks, >>> Srini >>> >>> On Tue, May 16, 2017 at 9:04 AM, Dai, Wei wrote: >>>> Hi, Srini >>>> >>>> There is a bit confusion. Your patch shows that your code is added into >> the function eth_ixgbevf_pci_remove( ). >>>> But it is not. It is added into the fucntion ixgbe_dev_start( ), right ? >>>> So would you please rebase it to R 17.05 ? >>>> >>>> Which type of ixgbe device id did you tested ? >>>> >>>> There are many MAC types with different device id. >>>> >>>> The function ixgbe_pf_reset_hw(hw) is called before your adding code. >>>> ixgbe_pf_reset_hw() calls hw->mac.ops.reset_hw( ) which may points to >> following different function for different MAC type. >>>> Ixgbe_reset_hw_82598( ) calls hw->phy.ops.init(hw) if >> hw->phy.reset_disable == false . >>>> Ixgbe_reset_hw_82599( ) calls hw->phy.ops.init(hw) unconditionally. >>>> ixgbe_reset_hw_X540( ) doesn't' call pw->phy.ops.init(hw). For X540, >> hw->phy.ops.init points to ixgbe_init_phy_ops_generic() which only initialize >> some function pointers. >>>> Ixgbe_rest_hw_x550em() calls hw->phy.ops.init(hw) unconditionally. >>>> >>>> And for VF, ixgbe_reset_hw_vf( ) and ixgbevf_hv_reset_hw_vf( ) don't >> call hw->phy.ops.init(hw) anywhere. >>>> >>>> Thanks & Best Regards >>>> -Wei >>>> >>>>> -----Original Message----- >>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas >> Monjalon >>>>> Sent: Sunday, May 7, 2017 6:36 AM >>>>> To: Srinivasan J >>>>> Cc: dev@dpdk.org; Lu, Wenzhuo ; Ananyev, >>>>> Konstantin >>>>> Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: support detection of hot >>>>> swapped SFP/SFP+ >>>>> >>>>> 06/05/2017 15:51, Srinivasan J: >>>>>> Hi, >>>>>> Do we need an explicit "Acked-by" keyword for >>>>>> this patch to be accepted and applied? >>>>> >>>>> Yes, given it is not a trivial patch, an ack from the maintainer is required. >>>>> Anyway, it has been submitted too late for 17.05 testing. >