From: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: "Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Morten Brørup" <mb@smartsharesystems.com>,
"Tyler Retzlaff" <roretzla@linux.microsoft.com>
Subject: Re: [PATCH v2] test/bitops: check worker lcore availability
Date: Fri, 25 Oct 2024 10:46:49 +0100 [thread overview]
Message-ID: <8ddcca82-5f6e-46c5-90af-87db626188db@foss.arm.com> (raw)
In-Reply-To: <20241025073926.43621-1-david.marchand@redhat.com>
Acked-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
On 25/10/2024 08:39, David Marchand wrote:
> Coverity is not able to understand that having 2 lcores means that
> rte_get_next_lcore(-1, 0, 1) can't return RTE_MAX_LCORE.
> Add a check.
>
> Coverity issue: 445382, 445383, 445384, 445387, 445389, 445391
> Fixes: 35326b61aecb ("bitops: add atomic bit operations in new API")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v2:
> - added a helper,
> - prefer RTE_VERIFY(),
>
> Note:
> - a better fix would be to check lcore id validity in the EAL launch API,
> but it requires inspecting all functions and it could result in some
> API change, so sending this as a simple fix for now,
>
> ---
> app/test/test_bitops.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c
> index 681e984037..78a7df6bb1 100644
> --- a/app/test/test_bitops.c
> +++ b/app/test/test_bitops.c
> @@ -13,6 +13,17 @@
> #include <rte_random.h>
> #include "test.h"
>
> +static unsigned int
> +get_worker_lcore(void)
> +{
> + unsigned int lcore_id = rte_get_next_lcore(-1, 1, 0);
> +
> + /* avoid checkers (like Coverity) false positives */
> + RTE_VERIFY(lcore_id < RTE_MAX_LCORE);
> +
> + return lcore_id;
> +}
> +
> #define GEN_TEST_BIT_ACCESS(test_name, set_fun, clear_fun, assign_fun, flip_fun, test_fun, size, \
> mod) \
> static int \
> @@ -158,7 +169,7 @@ test_bit_atomic_parallel_assign ## size(void) \
> printf("Need multiple cores to run parallel test.\n"); \
> return TEST_SKIPPED; \
> } \
> - worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \
> + worker_lcore_id = get_worker_lcore(); \
> lmain.bit = rte_rand_max(size); \
> do { \
> lworker.bit = rte_rand_max(size); \
> @@ -217,7 +228,7 @@ test_bit_atomic_parallel_test_and_modify ## size(void) \
> printf("Need multiple cores to run parallel test.\n"); \
> return TEST_SKIPPED; \
> } \
> - worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \
> + worker_lcore_id = get_worker_lcore(); \
> int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, &lworker, \
> worker_lcore_id); \
> TEST_ASSERT(rc == 0, "Worker thread launch failed"); \
> @@ -266,7 +277,7 @@ test_bit_atomic_parallel_flip ## size(void) \
> printf("Need multiple cores to run parallel test.\n"); \
> return TEST_SKIPPED; \
> } \
> - worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \
> + worker_lcore_id = get_worker_lcore(); \
> int rc = rte_eal_remote_launch(run_parallel_flip ## size, &lworker, worker_lcore_id); \
> TEST_ASSERT(rc == 0, "Worker thread launch failed"); \
> run_parallel_flip ## size(&lmain); \
prev parent reply other threads:[~2024-10-25 9:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 15:25 [PATCH] " David Marchand
2024-10-11 15:27 ` Morten Brørup
2024-10-13 6:53 ` Mattias Rönnblom
2024-10-14 14:26 ` David Marchand
2024-10-25 7:39 ` [PATCH v2] " David Marchand
2024-10-25 9:22 ` Morten Brørup
2024-10-25 9:46 ` Jack Bond-Preston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8ddcca82-5f6e-46c5-90af-87db626188db@foss.arm.com \
--to=jack.bond-preston@foss.arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).