From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 1BB905A6A for ; Wed, 31 May 2017 18:43:03 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP; 31 May 2017 09:43:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,275,1493708400"; d="scan'208";a="93296667" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.81]) ([10.237.220.81]) by orsmga004.jf.intel.com with ESMTP; 31 May 2017 09:43:01 -0700 To: Lee Roberts Cc: "dev@dpdk.org" References: <1496245215-3859-1-git-send-email-lee.roberts@hpe.com> From: Ferruh Yigit Message-ID: <8e035ab5-0435-3346-b572-c618df12571f@intel.com> Date: Wed, 31 May 2017 17:43:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496245215-3859-1-git-send-email-lee.roberts@hpe.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation under RHEL 7.4. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 16:43:04 -0000 On 5/31/2017 4:40 PM, Lee Roberts wrote: > Fix kni compilation under RHEL 7.4. > > Signed-off-by: Lee Roberts Not tested on RHEL 7.4, but patch looks good to me except following nit-picking: - There should not be "." at the end of the patch title - It can be good to add Linux commit that is the reason of the change to the commit log: Linux: 9b36627acecd ("net: remove dev->trans_start") Acked-by: Ferruh Yigit