Re: [PATCH v5 07/15] net/xsc: add ethdev configure and RSS ops

["WanRenyong" <wanry@yunsilicon.com>]

On 2025/1/17 2:19, Stephen Hemminger wrote:
> On Tue, 07 Jan 2025 10:49:55 +0800
> "WanRenyong" <wanry@yunsilicon.com> wrote:
>
>> +static int
>> +xsc_ethdev_rss_hash_conf_get(struct rte_eth_dev *dev,
>> +			     struct rte_eth_rss_conf *rss_conf)
>> +{
>> +	struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev);
>> +
>> +	if (rss_conf->rss_key != NULL && rss_conf->rss_key_len >= priv->rss_conf.rss_key_len)
>> +		memcpy(rss_conf->rss_key, priv->rss_conf.rss_key, priv->rss_conf.rss_key_len);
>> +
>> +	rss_conf->rss_key_len = priv->rss_conf.rss_key_len;
>> +	rss_conf->rss_hf = priv->rss_conf.rss_hf;
>> +	return 0;
>> +}
>> +
>> +static int
>> +xsc_ethdev_rss_hash_update(struct rte_eth_dev *dev,
>> +			   struct rte_eth_rss_conf *rss_conf)
>> +{
>> +	struct xsc_ethdev_priv *priv = TO_XSC_ETHDEV_PRIV(dev);
>> +	int ret = 0;
>> +
>> +	ret = xsc_dev_rss_key_modify(priv->xdev, rss_conf->rss_key, rss_conf->rss_key_len);
>> +	if (ret == 0) {
>> +		rte_memcpy(priv->rss_conf.rss_key, rss_conf->rss_key,
>> +			   priv->rss_conf.rss_key_len);
> This should probably be memcpy (not rte_memcpy) since not critical path.
OK, I will fix it next time.

-- 
Thanks,
WanRenyong