From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-SN1-obe.outbound.protection.outlook.com (mail-sn1nam02on0065.outbound.protection.outlook.com [104.47.36.65]) by dpdk.org (Postfix) with ESMTP id 058FE20F for ; Tue, 20 Dec 2016 07:13:10 +0100 (CET) Received: from CY4PR03CA0010.namprd03.prod.outlook.com (10.168.162.20) by BN6PR03MB2466.namprd03.prod.outlook.com (10.168.223.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14; Tue, 20 Dec 2016 06:13:09 +0000 Received: from BN1AFFO11FD006.protection.gbl (2a01:111:f400:7c10::131) by CY4PR03CA0010.outlook.office365.com (2603:10b6:903:33::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.789.14 via Frontend Transport; Tue, 20 Dec 2016 06:13:08 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; networkplumber.org; dkim=none (message not signed) header.d=none; networkplumber.org; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BN1AFFO11FD006.mail.protection.outlook.com (10.58.52.66) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.789.10 via Frontend Transport; Tue, 20 Dec 2016 06:13:08 +0000 Received: from [127.0.0.1] ([10.232.133.65]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id uBK6Cxh0009502; Mon, 19 Dec 2016 23:13:04 -0700 To: Stephen Hemminger References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-1-git-send-email-hemant.agrawal@nxp.com> <1482180853-18823-2-git-send-email-hemant.agrawal@nxp.com> <20161219081651.6482f6b1@xeon-e3> CC: , , , , , , From: Hemant Agrawal Message-ID: <8e0f68ed-73c6-dc81-bebc-37498f44b284@nxp.com> Date: Tue, 20 Dec 2016 11:42:59 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20161219081651.6482f6b1@xeon-e3> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131266879887030573; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39380400002)(39400400002)(39410400002)(39860400002)(39450400003)(39850400002)(39840400002)(2980300002)(1110001)(1109001)(339900001)(377454003)(189002)(199003)(24454002)(47776003)(50466002)(50986999)(68736007)(69596002)(33646002)(6916009)(81156014)(5660300001)(76176999)(65826007)(54356999)(120886001)(8676002)(77096006)(6666003)(23746002)(31696002)(2950100002)(36756003)(38730400001)(81166006)(110136003)(229853002)(8936002)(104016004)(92566002)(7126002)(626004)(64126003)(8666005)(2906002)(93886004)(86362001)(4326007)(7246003)(105606002)(4001350100001)(356003)(189998001)(305945005)(106466001)(83506001)(65956001)(230700001)(97736004)(65806001)(31686004)(85426001)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR03MB2466; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD006; 1:P4NYm3bCN+b+CtV6x+NaBZEhC2coFXZeQR+aR0xRnPoKkHJp8s9yt9RiSr8MoesoEjW65gCnI/RTCjBNx+sjmiwlZ31yIydjNEfwehzfWacLuE+qSiSMNtJ0BBHthdHcFDuv5SD78AseXX7gsF+cgIx/Uemp2Ls+fIhM90O0P7KVvvzUC4RR1MTtm30W1E4Obm2CHXh2k3UhPlrMLvEXEP6XI67+7l3GwmH1skzot9bvWUhBS41SgMYf/shQEFr9VNvP4sdJa8JN3Bf54rannaq9fxYB+x+fFcpyyhT3yR7z+fp5vPSYtUOWHk5aGmr8IV/liPQeeBkq/JUWz8ILAC35MJfemOsNCgSuJicpO2huhHqDfksNAK/OlLlawY1NJZfEPRtdA7LXwq8pUgFhqygSMDG+pNoowH+IZDY51cTcJDKjylzBmooB3Lav1Q7OF17rKp48a0dNx25nnVyRhqJumRQaXxQtUrq6JWNJpn+xhfU5ZFstSg47DxV6JS/z3fDIZjvC85uT5NszNgl6QmLdF0Cg6cL7447TG8Q2NZSUOyuREknWwca3D19LL/ALpQhkGl0LJ17/P20GQ8lVERfo8ifpqaUEE7KoMmwoZBKO9ZULk6X3T3njO9BIVWnPcCiwMKAWR/WpcPYFOcBi0Q== X-MS-Office365-Filtering-Correlation-Id: 6f56ae7b-b381-42b5-57e1-08d4289f44e5 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR03MB2466; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 3:0bp41WGMnY8/YhzkjCGb5T0gsBqvngPfteM2qmlpg2H7PC+fGwy5jFs265L9vwIXTGkIETPJRc4ye65UPGaMIM/zHaDqpsbZI5xZNoLrMfpXi8E8TxKbjE6CISIsyUQkK0bYfioxaAQUnHgLKNr29CADTkuUXU4GDfTUO7bNOzKcbJHKgyvkfbdom5SX5hSdlq3VOphkAu7u5uDfDvYscDkRCbq8TweDX044s5MW7ocdn4kk+LUZ/f23XOYHqf8GtOHjPVj4MrZKIvwvuVPlTfOzgQKThzc3MGHweu/1/6yk+2kVslWlRPD+E2E7lFb8aHHMbQLd7tKHfqB9HBR8fo/aO4ve0pAkrclMbfgBCQE= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 25:exKAKtk97yf1xMz7CP/xzUx2AuFm6uKy89R0oNs6KSeJR8EA6nL3ZydJlNMsJ/antaDHOtaRWb6lGHnbtjlE8gJiOcR7GvdWCWVal/pTCUuPmltOC879sQ0QSzJM2PAYU38ynD0uWxz3D35GNuDRMqCjSE7lhuPIHjpT29kBR4pO+N9HGiFCegNTK7JnccuqUPzztJgwpczQ32Edlih+rUMdrAOFVBk2XEi5N6l9NK7TkrsPabz1tekVuFKU2Kv65Vc2/cQ35jPQeC72u8mbnMv6x9SW4HvZKU9ZlX7Y9rFuPa0++l38/s7qXlKJeK5JA/j5ChltqH31Jg3scfbVlYs2Lnl35+OCjwBfCAd7mNDNGs/cvKw3Gzm/EF7qncWQyyaFiAgh9cgrfltLm0yM60ZLSHGiM6rTb7rHmxn9KVIqC0RDUXnU5USEKiIyoK3bh+mOnUPHOzoIus+xpSaY8AZlW+HjqCa9tmvlpvBBRv/oaDNHkQlAyk1kywQsloDxk+QlVWZo7NUK/ApQOaVCOd4c6o41ALsiK5vJ7P1VGgVW0BJz5Xh7WyP9yvg+yxTiTqTFGGCMEFFi9CIXoT9+vPeNocm1RHz1j86FL8LkRqfjQnYRXhuixOQq2U6MggBny8RMJBB9TlV2Y4gmEzfiuNNfCwlT0NCeAQJSwuSEZK7GGjvaW/Q81yjb3fhc8tfrfiWLbSwVBvrkHqvozAttB2TDPk8XXZIxjf3CzPdMsE3pdZOzvv2AFMIAN4TYyvTWDrkuB448/b1/Ks0d29+KC8CM4nlPxNfu4+g2ssOQmGg= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 31:WHQeKGgi1X+rC1SsVdWCMNfeiWHDA35y391zZi0rcfqYsHnRdkO9bt5DGXzL08GFI4BZmU5Xd7e+6g4JXPVkvv5ngjMXgY7z9dteX0oH4DeMbS76UyNEHrbRLKApM0NC8JS8Ndgxa5M0nnioC0L/HuHzkEw+1h8cNkGS+MpqbmnBBMMY3lDY5stP/hFphtqNItvq/BqfMmnnFkkkaYszSfUwM1gz+xutD/bb4mMuvHjJEze7Dw1dkmyXCFs29fJAprb488yX5MUHtISkrg+29g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13015025)(5005006)(13024025)(13023025)(13017025)(8121501046)(13018025)(10201501046)(3002001)(6055026)(6096035)(20161123563025)(20161123556025)(20161123565025)(20161123559025)(20161123561025); SRVR:BN6PR03MB2466; BCL:0; PCL:0; RULEID:(400006); SRVR:BN6PR03MB2466; X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 4:he6+zKvjAUmyseRq+IjLLaFDe0DQ61Y2LhWYXTbMZ9Ntd2AWRqDy0Z1Wb7cORy6VFEyQ+zvW1ixQ8/25pkfZgLyHqP75aD1Ew8OmtlHLw5XTesoRNMtJ8YgCDmeKVjQcqd1Tp2BLrsGE7dt1uIAt6QsGAB7OBphCcQNLuOkjn2603mz+wb2BHqT/OO3NWigZJCMesM8u+T/LHzHigFvySyyS0sT3oCiinXOYy7oJBUxIkyzWMF1dTC8cT+I13vievf11kdoC9S/4joebN42rH2Yl/PUo0B7PHaOBJxiV3+qBmVF7ocZ0J84lwaFf2F40nUV5xLM2roeA/Fb3AwbXQJg9z/dFsQRdf+MEWHfK8DNKkA2gcsQzY+yMp7DYHUAkqC1TFk6Cn3zbQPfN7Tm2Q7Rj3PyEKc6Yq0NLXO6ITP/byKiNb8XhmJ8b97OhVLL/EwOdjYas8n/bYd1JY5rpTIwGHxXPFWgiOjb9fKLTOzsOy5fnSHkchj8CeJU2eLk0s/BXyC0eiae4Q5eIEQ3tsvly/iaQ5YeU1mUaB5zl8gDGlfHHXat/+QoHWRARo0UHFHmJnoeJbNQVVFJQb5qjaJoNnrHEpIj1BG1brEkKa3rN1pEYVPR5kMxFeHgN8UPvMtogedQkEeTFTVj5N9Hmb2P6mnwojVQX9iLKXlLXtsFWVPZv+SQsFkbv46Wv9Zv3PeMeBDa2wXr1aYj+bmWIniIyi4+I6K/GbRsU6JTl2e482w15OXjVQZeuLrjg5kYpBG5FY4R5yXjUsOf/iyRM1Q== X-Forefront-PRVS: 0162ACCC24 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BN6PR03MB2466; 23:likmtMmLhBKM6Kb+v6FVgH2kgmrwtYaaiuD7I?= =?Windows-1252?Q?njf6tL2yuj5BJ0pLEFHNn0bilK0TzMrmPdgzi1pri2lpxKrhr8iJibaO?= =?Windows-1252?Q?ShkL2W/u4D4tcecW3cC0RRJ0L3rJZuI2nL3hGZbEIzjwdHBABjKPTEfE?= =?Windows-1252?Q?9pt7DABW5MpnSHnf4y/DpnTnPG4z8ahrRk4cwWHvs3l/O7BXmzP23YfW?= =?Windows-1252?Q?VRwuZ+QW0Qbfxd28skNAcQc6kEwbyxT7W/G4El4q8uFYn9tQEV0sPKJ8?= =?Windows-1252?Q?WJVAVbAfJBlwTikoZwFN+I+z1x1JoHlAb2yTuWvVg602HMaGZwZJAqbC?= =?Windows-1252?Q?18ENMmC+f1pysrs2PDjrt6Ed5gWe5LD/pOxJbXfqCV9rPdgs5UxB2iEw?= =?Windows-1252?Q?qX/CW4w51RMt+gdgqV3KVT5jsTW4TDHR0YxbCcoyzabyN7Narum1QdmQ?= =?Windows-1252?Q?8epuX+PBlASKNxZV7KqE8yJeAeBa556JO9vqT2vkxOk8FJEsXMyPp13q?= =?Windows-1252?Q?DQBvB2vprNEV+1VFZj8+l7qkDGrQDo+zwomAwp/V1YP4gG5KMNhIYl1/?= =?Windows-1252?Q?ThY0xttA2pemBKDZz+iqQ2iEX4NrCjKdZr5bfk16Y5W93Et9LxIveXsM?= =?Windows-1252?Q?TZOShPNWcO1/TbzEdzKVkSsjuTmXyuc9TjC/ETQvsMF6P+hmuK1HfpFI?= =?Windows-1252?Q?DJmAL/HGsOGsgXHQOQu2YTL997rFEPpPpG12Rv8RCJL+2DzahvjfjZPh?= =?Windows-1252?Q?GCuCE3gXXjC8fWGBOUldGO6tdOBn8jl/F2mVLsVaMuv9gYDUOXLchu+A?= =?Windows-1252?Q?y3tqsFfxgwmjFT/hdqVQdSzJILvGlnwQsQPnctgEQGLkgv88mNpMW2Qv?= =?Windows-1252?Q?Epa4+4a2K9zCLXkKYmxULzD63dN+SiOx1eP6UpW6pU+Q+8J9Bi3CZYFU?= =?Windows-1252?Q?lDSWvAqp8RNG3JweCSNLgKyTkZZ4MFqam/RfKO6SxY3Bk0IMQ5MUmSPW?= =?Windows-1252?Q?KBi9vRFkScWU6YNnGCCJSwnmDCMHSs+lwronWglO7n6UiUjsQUJQVAKZ?= =?Windows-1252?Q?nKEw7iskycnRIDxXId2OjknOZTeNbtRVzOaUxLUbMwuspTDCJlw52Jzy?= =?Windows-1252?Q?D0Yk82A6v5/o6mTuM86ZxqfHDML0cRzu2BcJ4IUyOquN5tbC4mD6nFYQ?= =?Windows-1252?Q?bvQXYY1rLTpc+L3ZT8BJDkHONsodOfXNJzW/Ivt9RobKpwXLfVRPyPKp?= =?Windows-1252?Q?AlIe9xdz21SRRXyM8rfQcHcFKHpmi9pi7eISJTRQ351PR4oboWY215Y4?= =?Windows-1252?Q?GYiiu2cMxRTMAVk5O+ZFnmfPtU8jE5SDIymjPOUmkLMUPOYUpJsbaa6V?= =?Windows-1252?Q?bAV6h9FpKuPqhlU4j8vzM7Sw6FvdYaaNkTnB4V13vGPF9oF5dHMXuIVL?= =?Windows-1252?Q?CJ0YCsD6UBPbduLTudHpsegDs67ov3M7YmP2I0P60hQCpyFaUcnHdPAx?= =?Windows-1252?Q?t3X1U3SZ5qFxN/mGnWZd8fThyXFV1jGqm+W4lsVbTYIJCxBw2z0smwOY?= =?Windows-1252?Q?91o+SXNiTz8nBpUvQ0w8Ppvm4THj4SyWDT/lFUF9caGMltOPKISHytHd?= =?Windows-1252?Q?qKNSAar6MsKPs21d3+9Hq/bjZ7ze92fKrQFF9LLg2VMqvuqt3OD66prW?= =?Windows-1252?Q?/dxX1myI+hyuytUBhhbAH64BwCnrm2/4eF409f+R4raKcO73d4ZG+cbc?= =?Windows-1252?Q?1iq3Ef1wT3US4UutQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 6:lH4NufIubUbJwFHFOn5HT/+4/2m7HbiAl5y7DD6kWofbQ9fvUkppvc0Z0Iv3lWULnS+Crg06M8INHmrQBv8NNmHJ1jeXf+hlz9/m9ZJ5MG7BohIinQ9mZlidcjVomwH/q+DRggKNFU++tJbpZVIV+MWcogJd2zcSE++iKppJYDQBU2+OlwXjfO4qhNRPtcfWZIemLUVwe/CXVFMc8qiVQ18PBVKRSY00kX9OOU9Vj3nMHON1pUbQW5WjMX0t1mhLpEtCiA0g/7MFwyA2AKUGk8SZT49vTWDuQ+Ff2FS0zVmnKzOjy5QxFAlObArUWPI4xKz+dQ8UKWFBARNi67nPhumH9+hTE/D0F/lphK1RoV6EapJDKgmP3gm0Qfe3+jz8m8u1vdPSYu0iqSWyVnXUtDTHKKRvyk6Sr4mMDO/Y0kwtZh3iMxxhy0+0yun/J6lr; 5:sU6EPqAJjny41leJw+H4ypYSRhCFEZW9QtXoI2P+v1/rjL2scdNEWe5uwoaK1g6YPyJ3NVUbg1Msi+rrynU1D2BgX46WHYUAyZfha+nJQIMr4t1tkuuKvpu0EmTNuIOWPO+iqogXUGrJwtjXP6mH7cTIURWh7wZIDXpPuCl8V9cNPPlN19kuJ/Remcvg8WWk; 24:Mf1v8b7FH3ci4iNoLmLU1cc+RmfRIn2bapiUFxliUllNf4PTetbHN/cID5UtoKeVTwoPA1aoCrSIOb4fcwz0avkZxjzhPduo/zxyUuuAHuQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR03MB2466; 7:7VnJprBQY0YoB0ZoySyb1dj+SeSIe0TcZTh9gVFLjFW6KAgY/50OPoP48Q7bG3EkqXPsp4oP2/639dhH+rXopLSylNP9Kqbo72qy+Af2MSHfNG7EJ5J5l2IxarsHh1aec5Xj2zgjFuHU4QgN94SxmsiZcEbPtHj5bEjPgnbL/GR8PxrndGomXeHflPhFcffy1lQ2ciVXS2iiWXBt2W8uu/RpeoMsX4uye+tnFXOCzivOlhjqgl2/j9dWUcOVZnftet4b5C98Om3JZJjwsQw2lQlNC2G8upq7bFH44bPi4udD7ZuO662DJenSRNF7af8X2WHddr3bf8PlJJSUzH4YM0BFXkRphxE2RAhlz5KILtF3vPLLkD4AkZQH/K38jFJsCvbbX7ppWgBWtAFqqlNYCRqEDflj8XSAZolooON+jB8O7/HPrDTDn8NOohXtC700Gf4iI9OxJST1eDwObFsPHQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Dec 2016 06:13:08.4066 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR03MB2466 Subject: Re: [dpdk-dev] [PATCHv2 01/34] lib/ether: add rte_device in rte_eth_dev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Dec 2016 06:13:10 -0000 On 12/19/2016 9:46 PM, Stephen Hemminger wrote: > On Tue, 20 Dec 2016 02:23:40 +0530 > Hemant Agrawal wrote: > >> Signed-off-by: Hemant Agrawal >> --- >> lib/librte_ether/rte_ethdev.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >> index 9678179..0b601e9 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -1626,6 +1626,7 @@ struct rte_eth_dev { >> eth_rx_burst_t rx_pkt_burst; /**< Pointer to PMD receive function. */ >> eth_tx_burst_t tx_pkt_burst; /**< Pointer to PMD transmit function. */ >> struct rte_eth_dev_data *data; /**< Pointer to device data */ >> + struct rte_device *device; >> const struct eth_driver *driver;/**< Driver for this device */ >> const struct eth_dev_ops *dev_ops; /**< Functions exported by PMD */ >> struct rte_pci_device *pci_dev; /**< PCI info. supplied by probing */ > > NAK > I would rather that rte_pci_device be eliminated from rte_eth_dev_data and > replace by more generic rte_device. I am working on a patch set to do this, > it is not fundamentally hard. > As discussed before, this patch is just an stop-gap arrangement till we get a proper solution. That is the very reason, I put it as first patch in my patchset - to be removed easily. It is helpful that you are coming with the proper solution.