From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <shreyansh.jain@nxp.com>
Received: from EUR03-VE1-obe.outbound.protection.outlook.com
(mail-eopbgr50077.outbound.protection.outlook.com [40.107.5.77])
by dpdk.org (Postfix) with ESMTP id A00CE1B725
for <dev@dpdk.org>; Mon, 9 Apr 2018 09:08:21 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version;
bh=6xvPKmuoV+8I/4DUW21ny/qRrux4qJAaJAfukNTIuhA=;
b=aqm6qCYZdqSHXyFUKKaC4zLDtSiqaLkNdtEeHKT09V5CCncObS7d51OvyXiEgTCeqxrdl3bb9pvXMhdTOG+F3g4XPdFIWW/izuNgZEXiy3EFEap75iVyXyuN6BSJdHuiB0Mi8mIq069pxPRPJyHfg0k5tfJv8GZJziaRrFEhgxA=
Authentication-Results: spf=none (sender IP is )
smtp.mailfrom=shreyansh.jain@nxp.com;
Received: from [10.232.14.39] (14.142.187.166) by
DB6PR0402MB2776.eurprd04.prod.outlook.com (2603:10a6:4:96::13) with Microsoft
SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Mon, 9
Apr 2018 07:08:19 +0000
To: Hemant Agrawal <hemant.agrawal@nxp.com>, ferruh.yigit@intel.com
Cc: dev@dpdk.org
References: <1522918464-4586-1-git-send-email-hemant.agrawal@nxp.com>
<1522918464-4586-4-git-send-email-hemant.agrawal@nxp.com>
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Message-ID: <8e340f7c-b20d-0947-5ef0-a6482a09094b@nxp.com>
Date: Mon, 9 Apr 2018 12:53:26 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
Thunderbird/52.7.0
MIME-Version: 1.0
In-Reply-To: <1522918464-4586-4-git-send-email-hemant.agrawal@nxp.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [14.142.187.166]
X-ClientProxiedBy: MAXPR0101CA0024.INDPRD01.PROD.OUTLOOK.COM
(2603:1096:a00:c::34) To DB6PR0402MB2776.eurprd04.prod.outlook.com
(2603:10a6:4:96::13)
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 039fdd5d-b8af-44ff-e2d7-08d59de8ad0b
X-MS-Office365-Filtering-HT: Tenant
X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0;
RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(4604075)(48565401081)(2017052603328)(7153060)(7193020);
SRVR:DB6PR0402MB2776;
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776;
3:CYdaxxd3FYiZF+N/4N1bUPz4k3cCzGmm0CEsHu+pQV2oawWKQVmzSNnBO1erJRXwk9UAeRYC69fk8VYXxRBR3th3Jw3bqGdOZfBETlIRcIZra4hVN7c/hYSE/ZWxqqF6AoJ477lU0MQSh0XLqbEF+HYyyDohxlftzjZjYHe4iCSV11RNcyPEx/eC0lpGYp3Id1/vL+anPJBefwo+gVkf24SJHLpE4VgtR4Uh3faITKc63qHM8SGkrn3PP3FbvCAz;
25:VJ3wKF3dlzKOiOQi2YWsub+mLijC3Fb4dwsRrLCHTdsHKnf0Vkf+gro0idIaL8c4ZZYptq0ZFkTbx7w7O3p/DuKAfw/jr2RttzPfaVhTOTnT12n7Gikvj3KYS0SV+KVNB8b/l/AZounh/+HGZ5s4+7Wf42JYz3Ui2lSDTos9SvgEuUKUI7tRjO/9dobpLV75kHVb8ECDhTQT7zNod0J/fuqffztMMor4tNtjF0ZvVMD2Kp89jS28XU/LQf02zSm/KSbUUHV9eZgkxUAR18zgjUnhrJFQvTwWJwzny3uHHzOdKttYfp5Jfmf0z0q1ij7ZP/dTxcLBY9A2dZWJtzmwMw==;
31:lF0WVlwBSw/en7+4K92u/cQJF7s3n5qDrxeSCIag77Oz4NZ141Hx2R4VllwiytZ7x6+1WPn321c/wmc6I7CxGx8wLCI31PjcsEZzQIGOoXr9s64UpodZuRdl3eYXSDTa0fn2BKwCTZI/E99MnEk9MHBYbkFheXBfdYmfJl+Uet7I5LNYGB3kTPm3+IZB+OukJJvfVMloQr5GpA5FGMnmFMHZ3MLFPC1zBS+8RW3DoT0=
X-MS-TrafficTypeDiagnostic: DB6PR0402MB2776:
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776;
20:N3Jv9VPJ8wBlVkk4C3HH9Tv7s8ehXhjZRaCQbcxXA6z55rClPN/faSkPEFBtSWr/RqP8QOQJoGBxOQ6+iJ5UaTFs5ykYEXxsnMLArV+oZYtW/jxlCJW9vt98kyeyGulu5V5s+2EvrVjuR4Es9/lCx9jN4d6eQ9QXndkLd+Ud9bPvOOHVa+IW7lEye0TRQjNzZDeEO7oBRS9LgExawkjERHlO5v7fmwJBoi9oGMkPV3uGvS82n7BzsGFalBv9aKfZLcfiPqwLljzssyx+FiY/2GFqOyxm1q+17GJWkKIhq0YgXvpPJaAxhKXu7SXnNwCKo24K+Aq/ZJeZ1DtxzPFtSgt+HRtwJCLmmyqEBLmy0YgQYBaF35mFBgrWC/xErSSl+ZAYZvbNQ1OcBjhZgAkgxKnJUkEmJJ+JBYgsaJnKKf6b5NIU4TXnV1K19zAbHwtGEBvEpEUQFEw/WCBldSqFGrZbgu7P5m54DQvmo9JlenUKkHadBH0BRhrsW99Hh9v7;
4:lyjwsW7W2UODQTi06JlzdmFct9Md67HxckavibE3NdRk4pP6EFAqXVdJCF4/66pVBd0D4/hoJvo9lG/ZO8JhG9SKfDVdMJV//VlbVS2GeTyEOY76ydlSbo/OmRd1GdOKJ1bU/1uGKsphMm52s5hMbaDROwfnMVpkud9TpjBzMO0akPJEs9XH9cL3c51vLLjDkDseWkeYcXp097BMQcBHJmHMTQq8Iup+gQqZsUZdkoI8UU00yA8wHKg2GNNaZeXIWw2O/JC6t5R/hFoMQtISHShhRTOfxZ/qQwIwUZpBB1j1rH517PkgKMldecuVAO1T
X-Microsoft-Antispam-PRVS: <DB6PR0402MB277696CB95C0451DA2BAA32590BF0@DB6PR0402MB2776.eurprd04.prod.outlook.com>
X-Exchange-Antispam-Report-Test: UriScan:(185117386973197);
X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0;
RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3231221)(944501327)(52105095)(3002001)(6055026)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(20161123560045)(6072148)(201708071742011);
SRVR:DB6PR0402MB2776; BCL:0; PCL:0; RULEID:; SRVR:DB6PR0402MB2776;
X-Forefront-PRVS: 0637FCE711
X-Forefront-Antispam-Report: SFV:NSPM;
SFS:(10009020)(6049001)(366004)(39860400002)(376002)(346002)(396003)(39380400002)(199004)(189003)(86362001)(47776003)(76176011)(106356001)(4326008)(55236004)(316002)(36756003)(68736007)(16576012)(59450400001)(386003)(77096007)(186003)(105586002)(64126003)(52116002)(50466002)(16526019)(26005)(7736002)(67846002)(31686004)(305945005)(5660300001)(53936002)(6246003)(65826007)(229853002)(58126008)(23676004)(6666003)(2486003)(52146003)(11346002)(478600001)(65956001)(66066001)(6486002)(2906002)(486006)(446003)(31696002)(8936002)(65806001)(8676002)(81156014)(81166006)(25786009)(476003)(5009440100003)(97736004)(230700001)(3846002)(6116002)(2616005)(956004)(110426004);
DIR:OUT; SFP:1101; SCL:1; SRVR:DB6PR0402MB2776; H:[10.232.14.39]; FPR:;
SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1;
Received-SPF: None (protection.outlook.com: nxp.com does not designate
permitted sender hosts)
X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjZQUjA0MDJNQjI3NzY7MjM6NTkxbFkzZWZkOVk3MEhqVFk2NzdMUnd4?=
=?utf-8?B?TjloNEFtU0hKR0c3Q3F1Z2UxWVN1cUJheU9zeS96UGk5OWFIanFadmtXSjQ0?=
=?utf-8?B?UmJXTll3QVVkam5CMGg0MisrQ3hiVXJubGFVSEpTbU0xLzVFZHMxditUMDd3?=
=?utf-8?B?ZUlML2FHbjhjbTZSL3Axd0RSY3hOLzQ3eGo0QVUwVnorWCtTalZ4azJZS282?=
=?utf-8?B?R1U4Y3RsYk0vZFJ6Yzg1TlFHam12NEhRZFpYMTBpeGZlbHlLeWc1U245S2s3?=
=?utf-8?B?aDcrZlF3WU43MTRNS1pIQU1iMFMxY25iMWhvQ3RZWGZtN01xSFVLZUNjd0ZB?=
=?utf-8?B?ZWF4eTVNNXRZTFlPZ3phZSt5ODcyNzFKb3NRWEZBa2ZEK3Izd3V4MGpDM0p5?=
=?utf-8?B?V0hwbVI1eHhTanorNk9scFNYeUp3SGoxVG9jMlVqcGRQM0U4NzlpWUdoTFhF?=
=?utf-8?B?Uy8zT2poM2dVRUhpUGtsSGFRYW1oOU1UV0VTVDdlK2IySExOWGNGbkpENHRW?=
=?utf-8?B?SXd0eGlhZk5mUDFyb0x2WXNnemppTjVodnhqRjBIT1BJQ3gyK1M5VFhSQnZu?=
=?utf-8?B?RVdmczFVYVFUanF0N2tUQ3RHV0hkcjZwN1dTQkxPd1NnZERvU1RKcnlIam1N?=
=?utf-8?B?a2pjbHozcWNFaWlTWS9WTXJTSFJqUjZ1NCtBNExzQzlRYVJLWE5nTndKRHpS?=
=?utf-8?B?RXJaWnllVzdoQ20vaDVtREsza0ZtZUNFT09Eay8vYWZNa2doY1R6b1pPTVpB?=
=?utf-8?B?QjhVOXBtZlJ2dHY0Z3dKVldEV3ZpQlJrVDBZbFkwRVhCRDFaWERBeGZQNm9D?=
=?utf-8?B?anQ4UVI1b2dhZnBaNzhNYnZtZ083UFRMMzZhUVc1ekFieEZROGsxSFBPcWlO?=
=?utf-8?B?MGpncWU3Q1gxa3BrUTE3bmg0ejBPOEF0SlpNOERrTHlud2pLZlhHQWNjSUZQ?=
=?utf-8?B?cWlMOEZ3NGZseXFFNEVnMXQrWEROc2xwYTQ3cFlqN01SR0RRQTIwSmRVYUo5?=
=?utf-8?B?Mmt3cHBKR1A5c05NMzZGcytGaDZBb0lRcWo3UGpaUUJUVEwrM0xCRkdtSXQ0?=
=?utf-8?B?aGJWb3IvdnF2Q3J0eFpQRlVTMXhabk00Q0VKU05ESkpHM1k3eHJiRUtHbVlp?=
=?utf-8?B?OFlDZUhmV3RqK3BKVUEzTkg0RzEwampkTE9jdTNQWnpEeW5QRVNZaEJwUGpY?=
=?utf-8?B?TGJKekFudDNLcXhxUXAycU9sNjF5QllrNE5LZ2xqaE5ncWlMSkFPbDBVdDRh?=
=?utf-8?B?dm5NZzVuWEk4ZER5RTRQa0xLV0lvL0NHTzNXQ3MzeWk5YjVpaHl3MlUwdmVp?=
=?utf-8?B?UTdFSFJOTFdabHlncEZhRk5SWTJUSDZMTXhhblhvY2xhV2Vid3ljc3c5Z1Zs?=
=?utf-8?B?M1dsWlJGeS9aOGpSWUR6dVFSZmNwajVGdDVBUVcvM0VBZGx4WDhCbEZ4eHg5?=
=?utf-8?B?R05GdnpnTGVmc0poZnNRRzNqNHo1elMrcW55YVFJN2ZUU0FaREZLVlN1b1h6?=
=?utf-8?B?SVphNGNOUThEOW9uYW1wclI5QTh6NDZqUURTVXlvdEl1K3FVK0VvdjNyS3NN?=
=?utf-8?B?M3RUWW9kRU5vQVprTGZOM2J5VGh4QkxHZTNINW8rOEN0RG5VVXczOVVrNWxt?=
=?utf-8?B?QUdRRGhRaVROSEtXT0ZOc1pkemRYWk1nTmgzNlh0c0M1aW9GS20wMG92SzZP?=
=?utf-8?B?NlFQYjFiQ29MRnpuMjd5cmhRRjBsTk15b2lkTkhGMzNZakpXRmFyZEZ6d2tU?=
=?utf-8?B?a2kwSDgvNDJObTZVNjZJVkFXc1J1aVNWcWM0c0lNWDMrSGRxQmJSZ3lsUXcz?=
=?utf-8?B?b1ZKZ1VJcjF5YTZsdGlDNk85cHVrQzNQVXFCMWVIUXVYZGZ0ZnVMQ2VuVENW?=
=?utf-8?B?ODdHTFhXajNDUlk1RnJVQjhPQmcwM0xsODlFOGJlaTBkbURtRHpJK0o0aUtr?=
=?utf-8?B?aGU5ZU9hSjlmcGNzQkRkRGVxbzd5cC9tdU4rOXVreWJpdU5xOTVkNVZEOWZs?=
=?utf-8?B?M0ZQMEY5bVBNMjJ3di91MHpuZ1QwNjJNY3l0TnhZQkkvbmd3S0k0bTNZVTkr?=
=?utf-8?Q?Mom8RQ=3D?=
X-Microsoft-Antispam-Message-Info: iot3HRN+0abnD1p+B9KQKAfw3lBeGmMoHgd5JrUERdYOzlpB8r/DYps5k/UKiU4yvYOEFjENYOG64Wc1dP5zk24/cRnF8XN2p05DgTEySW3nEzLovBwWGp3R1pGa0HsEKn6kT+5KX5l1Z1I+6ioqpD30g4X2XXRg/TeeO0PrNkn3XlvokXCRr0I0JYAJx2+0
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776;
6:oc9bDiuOleChSESBq4lRTc5M5eUNjVQFLLYQ97H09yn4HLfwh3sTBdV8nK3ZyoGKHzPT0PiH+VwptBoDHVg4UNpQt4sigrW7Euudvu2Sk3ri9fCxH246Wspgpxz3zH8SGDgpqGF4ImYz4M8CmbNq6Vhgt+DKjXt9YF5W8DJckS9441XL5UK0EqLgSVzw/Qiw69ZjedUg4wlElUg4B7A3it4wG3L3uit0jgujTl/+zYi9omwHDxCo2V1gLXIWfuC2zBl5k5q4MPb0/kwlzLqozfyyFgxlrTw+IvTXh/iyckXeeXk8tU9TwUKj8O+vhMeIJDw/erHt8x5N4Pq+6iRC6TSXzBM7tMpaNaKvMFpg0iT7grxznQovP02WOWX0id9Pp/6ipjxVvM2S2Lr7UxVEiNkpjxGh0I2uwtKmWkjPgdJ5//pEHrSe1TwPzeCscAuKhw6jKsvgEpFHpF03EYCJJw==;
5:oKUeCWByaVTWxVfj+EJ89llDS9Outse+I88aZWfeG7AfyzmNNaUZ6pOTdqiOpLsQKslN1GVXnfDFsEjYw1dHZfSZcR/LPt6qPkhZ9B6DGFafejtRsSuOXXmmd7Psstf3RPYxbPk6PJpSY5atyRG8OhRDPVBfsxiJ3gcWCVqhQiU=;
24:HLYst1l3/XQY5nQtMiqswG090lmOnzi4Pd3IAEMCd8ecpTtKgXwGYISc6+FayX1Y51VzsImeskmCkziIhbYLeQZ4e1nWslYnCa8inApHX10=
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-Microsoft-Exchange-Diagnostics: 1; DB6PR0402MB2776;
7:JkIEnxWPYEPspNxozElIGU0qAW6nhIbZL49Uxn2r0Cx7dPC7HK9SWelcYlXw1JK7Bd9H/j7PtgPhh1uGOR4Z+mojP1LI2Ogmxh3/VC39uBGAL7LDPMGnj1P/1fNz45ZXYqfC6YzJms7VscBzgbSclJYld5gA4NFmCghjAFPk/7+yoAmsKEl1LluWcPEwieuiJ9wKCjLcB4dGj6oiyTgCn4PVzmSN/TxypiAn/zpkCFclxXtqIpangsZq2Jy3Fw5W
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Apr 2018 07:08:19.3847 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 039fdd5d-b8af-44ff-e2d7-08d59de8ad0b
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0402MB2776
Subject: Re: [dpdk-dev] [PATCH 4/8] net/dpaa: fix the oob access
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Apr 2018 07:08:21 -0000
On Thursday 05 April 2018 02:24 PM, Hemant Agrawal wrote:
> Fixes: b21ed3e2a16d ("net/dpaa: support extended statistics")
> Coverity issue: 268318
> Cc: stable@dpdk.org
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> drivers/net/dpaa/dpaa_ethdev.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
> index 0aad111..cbdc4f2 100644
> --- a/drivers/net/dpaa/dpaa_ethdev.c
> +++ b/drivers/net/dpaa/dpaa_ethdev.c
> @@ -339,6 +339,9 @@ dpaa_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
Definition of this function is:
static int
dpaa_xstats_get_names(__rte_unused struct rte_eth_dev *dev,
struct rte_eth_xstat_name *xstats_names,
__rte_unused unsigned int limit)
> {
> unsigned int i, stat_cnt = RTE_DIM(dpaa_xstats_strings);
>
> + if (limit < stat_cnt)
> + return stat_cnt;
As this patch is using the 'limit' argument, '__rte_unused' should be
removed from the function arguments.
> +
> if (xstats_names != NULL)
> for (i = 0; i < stat_cnt; i++)
> snprintf(xstats_names[i].name,
> @@ -366,7 +369,7 @@ dpaa_xstats_get_by_id(struct rte_eth_dev *dev, const uint64_t *ids,
> return 0;
>
> fman_if_stats_get_all(dpaa_intf->fif, values_copy,
> - sizeof(struct dpaa_if_stats));
> + sizeof(struct dpaa_if_stats) / 8);
>
> for (i = 0; i < stat_cnt; i++)
> values[i] =
>
Once the above is correct, please use:
Acked-By: Shreyansh Jain <shreyansh.jain@nxp.com>