From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Dean Marx <dmarx@iol.unh.edu>,
probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu,
luca.vizzarro@arm.com, yoan.picchi@foss.arm.com,
Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v1] dts: add verify argument to set forward mode
Date: Mon, 16 Sep 2024 12:42:28 +0200 [thread overview]
Message-ID: <8e39d81f-c09a-4b75-8295-66194d33a984@pantheon.tech> (raw)
In-Reply-To: <20240812142355.12532-1-dmarx@iol.unh.edu>
On 12. 8. 2024 16:23, Dean Marx wrote:
> Add optional verify argument to the set_forward_mode
> method in testpmd shell.
>
This doesn't add the method, just fixes it's use. Don't forget to fix
the subject as well. And also add the tags that Jeremy mentioned.
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
> ---
> dts/framework/remote_session/testpmd_shell.py | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py
> index 43e9f56517..b8cdfc01b9 100644
> --- a/dts/framework/remote_session/testpmd_shell.py
> +++ b/dts/framework/remote_session/testpmd_shell.py
> @@ -717,11 +717,12 @@ def set_forward_mode(self, mode: SimpleForwardingModes, verify: bool = True):
> fails to update.
> """
> set_fwd_output = self.send_command(f"set fwd {mode.value}")
> - if f"Set {mode.value} packet forwarding mode" not in set_fwd_output:
> - self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}")
> - raise InteractiveCommandExecutionError(
> - f"Test pmd failed to set fwd mode to {mode.value}"
> - )
> + if verify:
> + if f"Set {mode.value} packet forwarding mode" not in set_fwd_output:
> + self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}")
> + raise InteractiveCommandExecutionError(
> + f"Test pmd failed to set fwd mode to {mode.value}"
> + )
>
> def show_port_info_all(self) -> list[TestPmdPort]:
> """Returns the information of all the ports.
prev parent reply other threads:[~2024-09-16 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-12 14:23 Dean Marx
2024-08-12 15:29 ` Jeremy Spewock
2024-09-16 10:42 ` Juraj Linkeš [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e39d81f-c09a-4b75-8295-66194d33a984@pantheon.tech \
--to=juraj.linkes@pantheon.tech \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=jspewock@iol.unh.edu \
--cc=luca.vizzarro@arm.com \
--cc=npratte@iol.unh.edu \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
--cc=yoan.picchi@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).