From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7C8EF459AD; Mon, 16 Sep 2024 12:42:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1B4F34025F; Mon, 16 Sep 2024 12:42:32 +0200 (CEST) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mails.dpdk.org (Postfix) with ESMTP id B9B1A40041 for ; Mon, 16 Sep 2024 12:42:30 +0200 (CEST) Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-a9018103214so608119466b.3 for ; Mon, 16 Sep 2024 03:42:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1726483350; x=1727088150; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=EUzeNCsGKrutfdmePOfmF44uu4PLbYJxdUDPGgA64eo=; b=tqNg22I0bCfxUEzSv0Rwu/ojEEL0mOWGyQ2LSjiyRqFkmbnbCepNb9dvQc4TLbrY3y xgTkFc1lOlEMWhf1sGbF3aMt7X8g0f5q36E96T4Gud5PXsLXBGV9OAG8vwkeKOLFVB5n ObS/sma+1b2MoE0GP+X1hrYYy4lnkIY4sT6ku34MjtCqrldHR9eVk7QkenEG1LFbMcij 1hT+fhl86FDYbhogeFtCs9UW168I0bmlREoTXqd4MoINI24qa5rRagZ3d69EQguE7LtM ws4nUktiAfKXaFXseGXqD5k9Rfm6onav238/rSPbTMpSPZBh7e7LxkXMARUhVdqtOQSR oZjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726483350; x=1727088150; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EUzeNCsGKrutfdmePOfmF44uu4PLbYJxdUDPGgA64eo=; b=VrTLDdGrBs3iAclVQFSH/nF6OGPaWrOCn+ffqoh7zZV4R+Nccz8H9EnOyj8Akmra4p 4lHLBCasC83MlvFGDY9nIJXYGNQQ7iIe2awAmDH7EvnmaYvjsdz00/WCENaE1YMvJIPL RXdATb3rF0rHJQuZTqcAEQQKzpGWSWwDATKEc2Qetf3labTd1onacaj8LDTNrCXxHI6K pEnG6t/1F6c+KVZTbWmsdvCe9SGOL4ICrTuYKmLQliDw3y6mofpV1jejN2S7LnqTR2u8 iXk7xDfaYlKqKbFgaszCQKVwFSqYVUbV+F2UYz4w4EZmfhKJbpuQjL8hrqa9Lo6jXA1v s5Nw== X-Gm-Message-State: AOJu0YxoY3KtSy+4vIztENv0dpuNO9iI1Z74O1xGhpjtmkwnLI8K9DjB 2GeNC1ZC1ZwkpMDO4lV55mugP8TQ2w/uIiajiCkSNiVj40QO6UyR+w49RzKPcg0= X-Google-Smtp-Source: AGHT+IHUkAGGni3TUSbUWpyUevr4zCSeztlosoRN4dgd2Bgo9nnSufY0/OtdAdpEjX8ec0TUcoOK0Q== X-Received: by 2002:a17:907:f1e4:b0:a8a:58c5:78f1 with SMTP id a640c23a62f3a-a90293fc854mr1445940966b.11.1726483349988; Mon, 16 Sep 2024 03:42:29 -0700 (PDT) Received: from [192.168.200.22] ([84.245.121.62]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a9061321568sm294184066b.191.2024.09.16.03.42.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Sep 2024 03:42:29 -0700 (PDT) Message-ID: <8e39d81f-c09a-4b75-8295-66194d33a984@pantheon.tech> Date: Mon, 16 Sep 2024 12:42:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] dts: add verify argument to set forward mode To: Dean Marx , probb@iol.unh.edu, npratte@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org References: <20240812142355.12532-1-dmarx@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240812142355.12532-1-dmarx@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12. 8. 2024 16:23, Dean Marx wrote: > Add optional verify argument to the set_forward_mode > method in testpmd shell. > This doesn't add the method, just fixes it's use. Don't forget to fix the subject as well. And also add the tags that Jeremy mentioned. > Signed-off-by: Dean Marx > --- > dts/framework/remote_session/testpmd_shell.py | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py > index 43e9f56517..b8cdfc01b9 100644 > --- a/dts/framework/remote_session/testpmd_shell.py > +++ b/dts/framework/remote_session/testpmd_shell.py > @@ -717,11 +717,12 @@ def set_forward_mode(self, mode: SimpleForwardingModes, verify: bool = True): > fails to update. > """ > set_fwd_output = self.send_command(f"set fwd {mode.value}") > - if f"Set {mode.value} packet forwarding mode" not in set_fwd_output: > - self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}") > - raise InteractiveCommandExecutionError( > - f"Test pmd failed to set fwd mode to {mode.value}" > - ) > + if verify: > + if f"Set {mode.value} packet forwarding mode" not in set_fwd_output: > + self._logger.debug(f"Failed to set fwd mode to {mode.value}:\n{set_fwd_output}") > + raise InteractiveCommandExecutionError( > + f"Test pmd failed to set fwd mode to {mode.value}" > + ) > > def show_port_info_all(self) -> list[TestPmdPort]: > """Returns the information of all the ports.