From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id CBF607CDE for <dev@dpdk.org>; Thu, 4 Oct 2018 11:11:58 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Oct 2018 02:11:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,338,1534834800"; d="scan'208";a="78398429" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.113]) ([10.237.220.113]) by orsmga007.jf.intel.com with ESMTP; 04 Oct 2018 02:11:24 -0700 To: Jeff Guo <jia.guo@intel.com>, stephen@networkplumber.org, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, gaetan.rivet@6wind.com, jingjing.wu@intel.com, thomas@monjalon.net, motih@mellanox.com, matan@mellanox.com, harry.van.haaren@intel.com, qi.z.zhang@intel.com, shaopeng.he@intel.com, bernard.iremonger@intel.com, arybchenko@solarflare.com Cc: jblunck@infradead.org, shreyansh.jain@nxp.com, dev@dpdk.org, helin.zhang@intel.com, jerin.jacob@caviumnetworks.com References: <1534503091-31910-1-git-send-email-jia.guo@intel.com> <1538635483-92222-1-git-send-email-jia.guo@intel.com> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <8e44ad47-133f-8e20-6600-df0df3ac8682@intel.com> Date: Thu, 4 Oct 2018 10:11:22 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1538635483-92222-1-git-send-email-jia.guo@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 0/4] Enable hotplug in vfio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 04 Oct 2018 09:11:59 -0000 On 04-Oct-18 7:44 AM, Jeff Guo wrote: > As we may know that the process of hotplug is different between igb_uio > and vfio. For igb_uio, it could use uevent notification and memory > failure handle mechanism for hot-unplug. But for vfio, when device is be > hot-unplugged, the uevent can not be detected immediately, because of the > vfio kernel module will use a special mechanism to guaranty the pci > device would not be deleted until the user space release the resources, > so it will use another req notifier event at first to notify user space > to release resources for hotplug. > > This patch will add a new interrupt type of req notifier in eal interrupt, > and add the new interrupt handler in pci device to handle the req device > event. When the req notifier be detected, it can trigger the device event > callback process to process for hot-unplug. With this mechanism, hotplug > could be enable in vfio. > LGTM Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> -- Thanks, Anatoly