From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D389D42B82; Tue, 23 May 2023 16:29:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A769540A80; Tue, 23 May 2023 16:29:23 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 88CAC40689 for ; Tue, 23 May 2023 16:29:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684852161; x=1716388161; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=JI7khY7w2cqU7yjsrq9DeneQMFsRiReSDn/b6FmDw18=; b=M3X73gbNe/rwRzufieEYcUNaROxWT/BMd63ZoxnUTjZMdnMYIJWPq/Tm uWSzaUc/k8X6vQqdjcViq85g0PlzzMIdE/0GigOOVv9t/xba8WFU9cpSB USe0EzIdPKx6bll4/WDJP7UCIumuERuAV2U4dvJUE1YJbmDTbGpGF6SvF fDR/WzTyHip5k7l3tPkfd/dTzXF39f5xJ6iFj5dGTG0oSZP0eMpExk9Eq X076GUM6kmQJXhEmftkijEmVAtS9ZQBVAHhzmFw16yhRb5JZ+MQvahvrr l0W88DTyyKS11zV7ukpLBQ1cjcgxjWYMYS4cQW1IdeaccXdRyXulg65LC Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="353278205" X-IronPort-AV: E=Sophos;i="6.00,186,1681196400"; d="scan'208";a="353278205" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 May 2023 07:29:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10719"; a="848308420" X-IronPort-AV: E=Sophos;i="6.00,186,1681196400"; d="scan'208";a="848308420" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 23 May 2023 07:29:20 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 07:29:20 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 23 May 2023 07:29:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 23 May 2023 07:29:19 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 23 May 2023 07:29:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cbSfpxUQoB5oZDFyKwXYdy1qh9xTZ2ReYEw6L5zWBnGnQEhvkKodC/ox6GU20iC/s8SxibRZsQV+yDki5ZtEkrAyFX0AY35vQ/IoXDTxVgMzLVgP3ZYSSkaK/uuGiind28pNq3klMwrRMoF3Gzsw/vdyqGGgmnXaAEDkqneJmg+Y1IwjB+4H13ybsgwPzql97CJExv3Yekqkw+Ft4I45qFBNTAV7+I+G5cG20G0HjmDgzxsKD7HF8H76dNHXc5k4kZh7iohIR8geZQ3AFDUOn852ltyzSR7kHgOHZVrfQB40ZU+mB8EVUeblRyxLHMmkyBlUXB0Ml0dmi5BTzBfxnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=j7KtmSfHbFokO1Ws0fq2681E8jOL+GcXz2r865uTYvI=; b=nYqJGHbfcZ32koUR/BaOkIdCLTqlb1N5FG1Zds7xNA3WHxUVSEZlOpFG2abAzV3pvUnN2JUQfPRV78HfGpwn1GagdfEdk9jOa1KDYbHCuPjslKVCgeZ6ZkJzAvrf058hmw195JYeJtjc7czvDHomo1TEBPz17Bf+gS1aqZbXUiPG6ZiEP/7wCr5GWG6NAtLo/2/engMR6dVckeuo7QFgc1qervcWs7D2/Y++IOJwlgmuW0OPD4ejigatk9OqdaqyMqRoQpgMu1URdM9mmI+qG35CNVX0CbXxhRhxAz/fjbDnAeMY3KZjwoLTUEq9a3j4rTiFRxRK+ge0dFLB6pNvkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by DM6PR11MB4610.namprd11.prod.outlook.com (2603:10b6:5:2ab::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29; Tue, 23 May 2023 14:29:17 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::49c0:aa4c:e5b4:e718%5]) with mapi id 15.20.6411.028; Tue, 23 May 2023 14:29:17 +0000 Message-ID: <8e68ef09-457a-6b14-1b52-5039f4a06c37@intel.com> Date: Tue, 23 May 2023 15:29:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.11.0 Subject: Re: [PATCH v1 1/1] eal: warn user when lcore cpuset includes multiple sockets Content-Language: en-US To: Bruce Richardson CC: , , , References: <0f77ce4515ff074f997f0068635b328060322d5a.1684847165.git.anatoly.burakov@intel.com> From: "Burakov, Anatoly" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB8P191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:10:130::27) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|DM6PR11MB4610:EE_ X-MS-Office365-Filtering-Correlation-Id: a70332c6-6315-4a11-f3ba-08db5b9a16f7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: x84kj8MWzoMVP3Qb4AT/EwhzhFsZovSqD9K/OWiwtP6IxzmmkoNhVWVCy/ai37t92Rfdr4ayaJuIFPMyXrmOBZinwEv4wBC0FxJGi3d9DoM9XFrK5Yh+SmqFD5bR53uR1nWL/3ndCYjoQ3HhzQHIiDotvGE/LU5xoJ+lrdZ8GxCOK8pypPfPBOoowMFzSATRPcaeI0qWgq3EkLLz5AxjbFvLfeDhCV+4Fe0cmgbMGnw7Q2KhQhmjSr6t3AEHX1vV9BAKmmQWqxw8fy+p0UKjWbA+i5MhQUanGi7un6ZVsFfHY6BwQM+GrF4yubJ7QkzvbzVe8d4FQMCjMLsBqNKqIkgx0eGuPAeZ8tbRN2GjAVElGuqGRb3ZebVqenO3dBrlrf+/F4BB10QjLbi8ddFOGKXy48yrhcwnauDBYnzg+5dNcLGRnMq7IrNc25OdQDXawmZdPN+hv04azTcE9JHUfaHaatx/wmoUR/mdJGYBceX62BdnNO2f+OYiJ4oxDmcTky3JGtII+lbiL5Q26s5u2khXYlv5OeZiFqkieRTDIN6rWdVEmJ9XjB1Z2M+Gn27p2UzyTSZogcyEQqWiQTY1kWXdLhv8JGpGterrIB9xC9FhRu59hLlAXor2aBN1+rwlhajAeiLcuafpMBOVRDjNmA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(376002)(396003)(346002)(39860400002)(136003)(366004)(451199021)(6506007)(186003)(6512007)(82960400001)(53546011)(26005)(38100700002)(2616005)(36756003)(83380400001)(2906002)(316002)(6666004)(66946007)(66556008)(66476007)(4326008)(6636002)(41300700001)(6486002)(37006003)(31696002)(86362001)(31686004)(478600001)(6862004)(8676002)(8936002)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1huSzdJa1dCMmVDZlBrSTJrcHFLRkd3UEk3SUxLSXk4ZGUwMnJOSEp3ekRK?= =?utf-8?B?bHpoMXp3aG9rTTBkenJnSWt4ZTN4Z241WHJ0S2w4TVJrZGlzVm5GMHVQOERp?= =?utf-8?B?YldhYitaYWVGcVd0b0xiMS9DOXlvWGZFQmNkc1NBWVQ2M1pObm0vUmxIK2JT?= =?utf-8?B?TUNpUDhkRTFCMlJ5YU55eHlrVDdLdTVDQy9BejNwakdPTU1mdGNlVU10M21Q?= =?utf-8?B?Sk1YVzczZHZsQVZDaE95dXhEYW81SSsvVGxjQjcxSy92Y2NFYmlOb1FlSUJ6?= =?utf-8?B?czlLc0ZQODFXVWNZTzJwYTJYRGdjR2hqSmpkZ3QwU2hBR3BqWGJjSFR1NkZt?= =?utf-8?B?OWoxM0tMK0MvY0xWUUF3NHJLWk5pL0tsek9mbXpUKzZRaVF1WlJZTjJnT2xU?= =?utf-8?B?Yzc5TkIzZjBsa21tV0NrWm1BZnprckRyVHg2V1JsRHVhOFhlWFdYaVMvWWIz?= =?utf-8?B?Uk1RQmd3T3dMOHVDVno2LzFYT3Foazc2cnJtWlNEcWtJa0JBZkJ2V0dveWZJ?= =?utf-8?B?dm53SXdHQjhoZzBid2FyQVR0b3NVeW1YdU50QThwblRGZlZ1ci9qTUtOUzRp?= =?utf-8?B?cXFFZGMzbE9xdEhOLytnRzZIZWVTaTEzMEFZYi91bldhY0RoSm1sNU9MT3Jw?= =?utf-8?B?alFjSC9PRThrd1dwaWFiaGZ5VUtkQzhZZEdseHNKbkN2aFExZXYzdDUvMjdD?= =?utf-8?B?dUJmWHBWSG9oMHpYNDAvT1F2K0RwYnNLVkw2UDY2bE1CZTM5RWxrdC9DVEQ0?= =?utf-8?B?OFR2WW0wM2gxQ3M5QTlUVHREaXNoSUVZdThQMHhqMW45WklqZjBrRjQzRy9S?= =?utf-8?B?YzlyNE9QOUMrbno2c0ZTazcyYlc1SjFrOFU5RTB2TFdlWWFUSjZBL2MvV3BI?= =?utf-8?B?KzM5aENlZ0tyQjdMWTJsY1dISTROWE5VRlA1R3V2aG40UVJWNFlSeXh5NkVt?= =?utf-8?B?czNJWFF1RVB6YXVFSzA0SU1YU0diZ3lsZk0wT29tN2pETktpWTVuR0l0YnIz?= =?utf-8?B?ZWdHcmU2OGl4bkQxNG0zalRDRldVVzgxcUtmMklpNnlQcFBiVS9jWHV4TDU1?= =?utf-8?B?Z3lodHNqem9IUTVmSEZSWEJzRnZUdXpwZWxtaXZXVC9JWTlOYmU0cS9NbllQ?= =?utf-8?B?T093bmhOL2FWUDdnUG9ZVUJkQ1FRUlFhUFErKzhJUG5NQnVYSHYrYWsvUmZH?= =?utf-8?B?ZVdwZGxxN3I4K2hZSHpsZ1FlQmFtNDFRVUpIT0NRSDhubFFVUmZSKzZFcC9x?= =?utf-8?B?Mjg1Z2U4NGdZRVhYVWJNZzBkVFU3OTFkVXAzM1FuOTRBNGRBVkYyWDVydkdq?= =?utf-8?B?blAxbzhZREFSZFhjMjg5YTRmcUpFQ3ZSZVNUT1BMLysvZllZSzZTT3VLMVpF?= =?utf-8?B?ODdjNWFJU2pHZUdmZnYzdlM0a2o5R05OMzFvSnJDSkFWQThyL01la2wwVFlV?= =?utf-8?B?bmdVdzMzSlJFTFBoUUdTVlVMVERTcVZQNE5ITk81N2xRSUluODRZVTBlNENT?= =?utf-8?B?a0JzNzVKTkZGS0lXOTFyUkNuRldYYWY4SmRjV1k0YnIyMmp5VG96WW50YkxQ?= =?utf-8?B?TitxRFM3WGlMQ0lvU1c3MlpOcWkveFdrOXBCUEpKTlYwaVdMTTRJY2hkYTVx?= =?utf-8?B?enFDS2pNMEw4bktOOFMrTHFheHp1Ri9pcXFqU1dKUkFqVldNRldIWG11R3lw?= =?utf-8?B?amFiaytzbHZtZzlrTWZmZVl1eDArSkJyZFZ2UkFXMWJyVit0S3FnSGwxTjNx?= =?utf-8?B?MFVCcGkramNTTHcrcjFEazhRWk5sN3NNTnhDZXJnU1ZXRXF6WDVVZ0V1dUxF?= =?utf-8?B?TnBtNVZUVEZxc3ExYkFCd3hjR29tWkNxNkFoZncxb21LOUt0RkNJa2g5Nyts?= =?utf-8?B?Z0F5T2taSjdCSVJNSDRsZEJkM0FYSUFSVFZLVjNTUkcwUHFBZ2V6UkMyNUp0?= =?utf-8?B?VlVmM1NJaHJiR0RnVmM3SUhWam0zOFpINmRKWVVtM3I0MS9mYXg0bmVPOGdI?= =?utf-8?B?RmkwZmFUTi9EVHdTTk40NjV6TmhZSllvNzdRU3hYRWdabENzR2czU01JZzRl?= =?utf-8?B?eTEyQThSdFRmdzRPRkJqUXpXQllISFQvbDY4Y3V0N1BrL0Z1ZkxwM3BzZXVX?= =?utf-8?B?dDV5aFpNRXBsSXovWU01TzAyZjc4TWJrOHl5S2wvU1dGelBFYTNRUXlENllj?= =?utf-8?B?cXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: a70332c6-6315-4a11-f3ba-08db5b9a16f7 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 14:29:17.4318 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +q2M1homixWhsm4YDkWLXWYCoN+yKgBs/g0nnNjztcE1mholWw1eO/IcxAKMgLAy7+beviRIL3xHjGPa93FFDnqemk3ZEwMHFGN0rTwCu3E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4610 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/23/2023 2:55 PM, Bruce Richardson wrote: > On Tue, May 23, 2023 at 01:06:16PM +0000, Anatoly Burakov wrote: >> Currently, it is allowed to specify a cpuset for lcores such that it >> will include physical cores from different NUMA nodes. This has an >> effect of setting `rte_socket_id()` for that lcore to SOCKET_ID_ANY, >> so add a warning about it. >> >> Signed-off-by: Anatoly Burakov >> --- >> lib/eal/common/eal_common_thread.c | 20 +++++++++++++++++--- >> 1 file changed, 17 insertions(+), 3 deletions(-) >> >> diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c >> index 079a385630..46fd2aca1e 100644 >> --- a/lib/eal/common/eal_common_thread.c >> +++ b/lib/eal/common/eal_common_thread.c >> @@ -65,10 +65,13 @@ static void >> thread_update_affinity(rte_cpuset_t *cpusetp) >> { >> unsigned int lcore_id = rte_lcore_id(); >> + int socket_id; >> + >> + /* find socket ID from cpuset */ >> + socket_id = eal_cpuset_socket_id(cpusetp); >> >> /* store socket_id in TLS for quick access */ >> - RTE_PER_LCORE(_socket_id) = >> - eal_cpuset_socket_id(cpusetp); >> + RTE_PER_LCORE(_socket_id) = socket_id; >> >> /* store cpuset in TLS for quick access */ >> memmove(&RTE_PER_LCORE(_cpuset), cpusetp, >> @@ -76,9 +79,20 @@ thread_update_affinity(rte_cpuset_t *cpusetp) >> >> if (lcore_id != (unsigned)LCORE_ID_ANY) { >> /* EAL thread will update lcore_config */ >> - lcore_config[lcore_id].socket_id = RTE_PER_LCORE(_socket_id); >> + lcore_config[lcore_id].socket_id = socket_id; >> memmove(&lcore_config[lcore_id].cpuset, cpusetp, >> sizeof(rte_cpuset_t)); >> + >> + /* >> + * lcore_id is not LCORE_ID_ANY, meaning this is a DPDK lcore, >> + * so having a valid NUMA affinity for this lcore is important. >> + * However, if cpuset includes cores from multiple NUMA nodes, >> + * the socket ID will be set to SOCKET_ID_ANY. Notify the user >> + * about it if that happens. >> + */ >> + if (socket_id == SOCKET_ID_ANY) >> + RTE_LOG(INFO, EAL, "DPDK lcore %u has NUMA affinity set to SOCKET_ID_ANY\n", >> + lcore_id); >> } >> } > While having a warning comment in the code is good, should we not also have > a user visible warning to the user when the specific a corelist parameter > value which includes the cross-socket scenario? > > /Bruce We could, yes. We could walk through the cpuset for a given lcore, and list their socket ID's, would that work? -- Thanks, Anatoly