From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 251E242DC7; Tue, 4 Jul 2023 04:01:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EDA2340F18; Tue, 4 Jul 2023 04:01:36 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 3566A40E03 for ; Tue, 4 Jul 2023 04:01:35 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Qw5Y84m70zMqQD; Tue, 4 Jul 2023 09:58:20 +0800 (CST) Received: from [10.67.103.42] (10.67.103.42) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 4 Jul 2023 10:01:33 +0800 Message-ID: <8e6bcefc-2239-d8c0-060b-9e8f31f86e1d@huawei.com> Date: Tue, 4 Jul 2023 10:01:32 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] app/testpmd: fix invalid queue ID when start port To: Ali Alnubani , Aman Singh , Yuying Zhang , Ferruh Yigit , Shiyang He CC: "dev@dpdk.org" , "liudongdong3@huawei.com" References: <20230703110232.28494-1-haijie1@huawei.com> From: Jie Hai In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.103.42] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2023/7/3 20:33, Ali Alnubani wrote: >> -----Original Message----- >> From: Jie Hai >> Sent: Monday, July 3, 2023 2:03 PM >> To: Aman Singh ; Yuying Zhang >> ; Ferruh Yigit ; Shiyang He >> >> Cc: dev@dpdk.org; liudongdong3@huawei.com; Ali Alnubani >> >> Subject: [PATCH] app/testpmd: fix invalid queue ID when start port >> >> Function update_queue_state updates queue state of all queues >> of all ports, using the queue num nb_rxq|nb_txq stored locally >> by testpmd. Error on invalid queue ID occurs if we start testpmd >> with two ports and detach-attach one of them and start the other >> port first. That's because the attached port has zero queues and >> that differs from the nb_rxq|nb_txq. The similar error happens >> in multi-process senoris if secondary process attaches a port > > Do you mean scenarios? Yes, sorry for the spelling mistake. I'll correct it. > >> and starts it. >> >> This patch updates queue state according to the num of queues >> reported by driver instead of testpmd. >> >> Fixes: 141a520b35f7 ("app/testpmd: fix primary process not polling all >> queues") >> Fixes: 5028f207a4fa ("app/testpmd: fix secondary process packet >> forwarding") >> Cc: stable@dpdk.org >> >> Signed-off-by: Jie Hai >> --- > > Thanks Jie. > > Tested-by: Ali Alnubani