From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B6CDA1B212 for ; Fri, 26 Apr 2019 18:31:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 09:31:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="154024869" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.92.20]) ([10.251.92.20]) by orsmga002.jf.intel.com with ESMTP; 26 Apr 2019 09:31:28 -0700 To: Kevin Traynor , dev@dpdk.org References: <20190426162230.21158-1-ktraynor@redhat.com> From: "Burakov, Anatoly" Message-ID: <8e70dd36-7981-8837-1481-9cbebcf89e90@intel.com> Date: Fri, 26 Apr 2019 17:31:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190426162230.21158-1-ktraynor@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2019 16:31:31 -0000 On 26-Apr-19 5:22 PM, Kevin Traynor wrote: > "VFIO group is not viable" error message is correct > but not very user friendly for something which can > usually be easily rectified. > > Add some additional text to give more of a hint. > > Signed-off-by: Kevin Traynor > --- > lib/librte_eal/linux/eal/eal_vfio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c > index 19e70bb66..6892a2c14 100644 > --- a/lib/librte_eal/linux/eal/eal_vfio.c > +++ b/lib/librte_eal/linux/eal/eal_vfio.c > @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, > return -1; > } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) { > - RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr); > + RTE_LOG(ERR, EAL, " %s VFIO group is not viable! " > + "Not all devices in IOMMU group bound to VFIO or unbound\n", > + dev_addr); > close(vfio_group_fd); > rte_vfio_clear_group(vfio_group_fd); > Come on, everyone knows /that/! Acked-by: Anatoly Burakov -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2392CA05D3 for ; Fri, 26 Apr 2019 18:31:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C2B8F1B6F2; Fri, 26 Apr 2019 18:31:32 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id B6CDA1B212 for ; Fri, 26 Apr 2019 18:31:30 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Apr 2019 09:31:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,398,1549958400"; d="scan'208";a="154024869" Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.92.20]) ([10.251.92.20]) by orsmga002.jf.intel.com with ESMTP; 26 Apr 2019 09:31:28 -0700 To: Kevin Traynor , dev@dpdk.org References: <20190426162230.21158-1-ktraynor@redhat.com> From: "Burakov, Anatoly" Message-ID: <8e70dd36-7981-8837-1481-9cbebcf89e90@intel.com> Date: Fri, 26 Apr 2019 17:31:27 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190426162230.21158-1-ktraynor@redhat.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190426163127.107D_b9dVcmoXvvgI2eTW6_ruf9rUMM9IsYDnpiXfSk@z> On 26-Apr-19 5:22 PM, Kevin Traynor wrote: > "VFIO group is not viable" error message is correct > but not very user friendly for something which can > usually be easily rectified. > > Add some additional text to give more of a hint. > > Signed-off-by: Kevin Traynor > --- > lib/librte_eal/linux/eal/eal_vfio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c > index 19e70bb66..6892a2c14 100644 > --- a/lib/librte_eal/linux/eal/eal_vfio.c > +++ b/lib/librte_eal/linux/eal/eal_vfio.c > @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr, > return -1; > } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) { > - RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr); > + RTE_LOG(ERR, EAL, " %s VFIO group is not viable! " > + "Not all devices in IOMMU group bound to VFIO or unbound\n", > + dev_addr); > close(vfio_group_fd); > rte_vfio_clear_group(vfio_group_fd); > Come on, everyone knows /that/! Acked-by: Anatoly Burakov -- Thanks, Anatoly