* [dpdk-dev] [PATCH] vfio: expand non-viable group error message
@ 2019-04-26 16:22 Kevin Traynor
2019-04-26 16:22 ` Kevin Traynor
2019-04-26 16:31 ` Burakov, Anatoly
0 siblings, 2 replies; 8+ messages in thread
From: Kevin Traynor @ 2019-04-26 16:22 UTC (permalink / raw)
To: anatoly.burakov, dev; +Cc: Kevin Traynor
"VFIO group is not viable" error message is correct
but not very user friendly for something which can
usually be easily rectified.
Add some additional text to give more of a hint.
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
index 19e70bb66..6892a2c14 100644
--- a/lib/librte_eal/linux/eal/eal_vfio.c
+++ b/lib/librte_eal/linux/eal/eal_vfio.c
@@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
return -1;
} else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
- RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr);
+ RTE_LOG(ERR, EAL, " %s VFIO group is not viable! "
+ "Not all devices in IOMMU group bound to VFIO or unbound\n",
+ dev_addr);
close(vfio_group_fd);
rte_vfio_clear_group(vfio_group_fd);
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-04-26 16:22 [dpdk-dev] [PATCH] vfio: expand non-viable group error message Kevin Traynor
@ 2019-04-26 16:22 ` Kevin Traynor
2019-04-26 16:31 ` Burakov, Anatoly
1 sibling, 0 replies; 8+ messages in thread
From: Kevin Traynor @ 2019-04-26 16:22 UTC (permalink / raw)
To: anatoly.burakov, dev; +Cc: Kevin Traynor
"VFIO group is not viable" error message is correct
but not very user friendly for something which can
usually be easily rectified.
Add some additional text to give more of a hint.
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
index 19e70bb66..6892a2c14 100644
--- a/lib/librte_eal/linux/eal/eal_vfio.c
+++ b/lib/librte_eal/linux/eal/eal_vfio.c
@@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
return -1;
} else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
- RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr);
+ RTE_LOG(ERR, EAL, " %s VFIO group is not viable! "
+ "Not all devices in IOMMU group bound to VFIO or unbound\n",
+ dev_addr);
close(vfio_group_fd);
rte_vfio_clear_group(vfio_group_fd);
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-04-26 16:22 [dpdk-dev] [PATCH] vfio: expand non-viable group error message Kevin Traynor
2019-04-26 16:22 ` Kevin Traynor
@ 2019-04-26 16:31 ` Burakov, Anatoly
2019-04-26 16:31 ` Burakov, Anatoly
2019-04-27 6:58 ` Rami Rosen
1 sibling, 2 replies; 8+ messages in thread
From: Burakov, Anatoly @ 2019-04-26 16:31 UTC (permalink / raw)
To: Kevin Traynor, dev
On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> "VFIO group is not viable" error message is correct
> but not very user friendly for something which can
> usually be easily rectified.
>
> Add some additional text to give more of a hint.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
> index 19e70bb66..6892a2c14 100644
> --- a/lib/librte_eal/linux/eal/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal/eal_vfio.c
> @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
> return -1;
> } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
> - RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr);
> + RTE_LOG(ERR, EAL, " %s VFIO group is not viable! "
> + "Not all devices in IOMMU group bound to VFIO or unbound\n",
> + dev_addr);
> close(vfio_group_fd);
> rte_vfio_clear_group(vfio_group_fd);
>
Come on, everyone knows /that/!
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-04-26 16:31 ` Burakov, Anatoly
@ 2019-04-26 16:31 ` Burakov, Anatoly
2019-04-27 6:58 ` Rami Rosen
1 sibling, 0 replies; 8+ messages in thread
From: Burakov, Anatoly @ 2019-04-26 16:31 UTC (permalink / raw)
To: Kevin Traynor, dev
On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> "VFIO group is not viable" error message is correct
> but not very user friendly for something which can
> usually be easily rectified.
>
> Add some additional text to give more of a hint.
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> lib/librte_eal/linux/eal/eal_vfio.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/lib/librte_eal/linux/eal/eal_vfio.c b/lib/librte_eal/linux/eal/eal_vfio.c
> index 19e70bb66..6892a2c14 100644
> --- a/lib/librte_eal/linux/eal/eal_vfio.c
> +++ b/lib/librte_eal/linux/eal/eal_vfio.c
> @@ -686,5 +686,7 @@ rte_vfio_setup_device(const char *sysfs_base, const char *dev_addr,
> return -1;
> } else if (!(group_status.flags & VFIO_GROUP_FLAGS_VIABLE)) {
> - RTE_LOG(ERR, EAL, " %s VFIO group is not viable!\n", dev_addr);
> + RTE_LOG(ERR, EAL, " %s VFIO group is not viable! "
> + "Not all devices in IOMMU group bound to VFIO or unbound\n",
> + dev_addr);
> close(vfio_group_fd);
> rte_vfio_clear_group(vfio_group_fd);
>
Come on, everyone knows /that/!
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-04-26 16:31 ` Burakov, Anatoly
2019-04-26 16:31 ` Burakov, Anatoly
@ 2019-04-27 6:58 ` Rami Rosen
2019-04-27 6:58 ` Rami Rosen
2019-05-03 20:43 ` Thomas Monjalon
1 sibling, 2 replies; 8+ messages in thread
From: Rami Rosen @ 2019-04-27 6:58 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: Kevin Traynor, dev
> On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> > "VFIO group is not viable" error message is correct
> > but not very user friendly for something which can
> > usually be easily rectified.
> >
> > Add some additional text to give more of a hint.
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
Reviewd-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-04-27 6:58 ` Rami Rosen
@ 2019-04-27 6:58 ` Rami Rosen
2019-05-03 20:43 ` Thomas Monjalon
1 sibling, 0 replies; 8+ messages in thread
From: Rami Rosen @ 2019-04-27 6:58 UTC (permalink / raw)
To: Burakov, Anatoly; +Cc: Kevin Traynor, dev
> On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> > "VFIO group is not viable" error message is correct
> > but not very user friendly for something which can
> > usually be easily rectified.
> >
> > Add some additional text to give more of a hint.
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
Reviewd-by: Rami Rosen <ramirose@gmail.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-04-27 6:58 ` Rami Rosen
2019-04-27 6:58 ` Rami Rosen
@ 2019-05-03 20:43 ` Thomas Monjalon
2019-05-03 20:43 ` Thomas Monjalon
1 sibling, 1 reply; 8+ messages in thread
From: Thomas Monjalon @ 2019-05-03 20:43 UTC (permalink / raw)
To: Kevin Traynor; +Cc: dev, Rami Rosen, Burakov, Anatoly
27/04/2019 08:58, Rami Rosen:
> > On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> > > "VFIO group is not viable" error message is correct
> > > but not very user friendly for something which can
> > > usually be easily rectified.
> > >
> > > Add some additional text to give more of a hint.
> > >
> > > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Reviewd-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [dpdk-dev] [PATCH] vfio: expand non-viable group error message
2019-05-03 20:43 ` Thomas Monjalon
@ 2019-05-03 20:43 ` Thomas Monjalon
0 siblings, 0 replies; 8+ messages in thread
From: Thomas Monjalon @ 2019-05-03 20:43 UTC (permalink / raw)
To: Kevin Traynor; +Cc: dev, Rami Rosen, Burakov, Anatoly
27/04/2019 08:58, Rami Rosen:
> > On 26-Apr-19 5:22 PM, Kevin Traynor wrote:
> > > "VFIO group is not viable" error message is correct
> > > but not very user friendly for something which can
> > > usually be easily rectified.
> > >
> > > Add some additional text to give more of a hint.
> > >
> > > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
>
> Reviewd-by: Rami Rosen <ramirose@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-05-03 20:43 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-26 16:22 [dpdk-dev] [PATCH] vfio: expand non-viable group error message Kevin Traynor
2019-04-26 16:22 ` Kevin Traynor
2019-04-26 16:31 ` Burakov, Anatoly
2019-04-26 16:31 ` Burakov, Anatoly
2019-04-27 6:58 ` Rami Rosen
2019-04-27 6:58 ` Rami Rosen
2019-05-03 20:43 ` Thomas Monjalon
2019-05-03 20:43 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).