From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF691A00C5; Fri, 8 May 2020 03:52:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A65F31DBA8; Fri, 8 May 2020 03:52:30 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id EDED21D9B3 for ; Fri, 8 May 2020 03:52:28 +0200 (CEST) IronPort-SDR: UtSHI12rhMbC/fmR5ZRN62Pys8u6t+WZQIOToLhDjmyc0WA+TKkH+WOFJyfAWOsBQghndzYRwd CLW8870eErnw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 18:52:28 -0700 IronPort-SDR: grEOMgdIU+oVJfbE4Xt+xq+x3oy3XMoAi7eC/UhBQKvkoSmkwaEopseL5brJ7ZZWx9OlRp+GQW R+rzZhASkJfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,366,1583222400"; d="scan'208";a="264146348" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 07 May 2020 18:52:27 -0700 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 18:52:27 -0700 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 8 May 2020 09:52:24 +0800 Received: from shsmsx602.ccr.corp.intel.com ([10.109.6.142]) by SHSMSX602.ccr.corp.intel.com ([10.109.6.142]) with mapi id 15.01.1713.004; Fri, 8 May 2020 09:52:24 +0800 From: "Wang, ShougangX" To: "Xing, Beilei" , "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix hash enable issue in RSS flow Thread-Index: AQHWJFUVuRYm8TPDVkW1sAVlyaWzFKic2nKAgACMI4A= Date: Fri, 8 May 2020 01:52:24 +0000 Message-ID: <8e8523f82a2e46cd85055ee52ad088a7@intel.com> References: <20200507094401.54928-1-shougangx.wang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix hash enable issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Beilei > -----Original Message----- > From: Xing, Beilei > Sent: Friday, May 8, 2020 9:04 AM > To: Wang, ShougangX ; dev@dpdk.org > Subject: RE: [PATCH] net/i40e: fix hash enable issue in RSS flow >=20 >=20 >=20 > > -----Original Message----- > > From: Wang, ShougangX > > Sent: Thursday, May 7, 2020 5:44 PM > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Wang, ShougangX > > > > Subject: [PATCH] net/i40e: fix hash enable issue in RSS flow > > > > This patch fixes the issue that failed to create an RSS rule with type > > L2- payload. > > > > Fixes: feaae285b342 ("net/i40e: support hash configuration in RSS > > flow") > > > > Signed-off-by: Shougang Wang > > --- > > drivers/net/i40e/i40e_flow.c | 14 ++++++-------- > > 1 file changed, 6 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index 7e64ae53a..f5f2f0d5d 100644L2- > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4511,6 +4511,7 @@ i40e_flow_parse_rss_pattern(__rte_unused > struct > > rte_eth_dev *dev, >=20 > <...> >=20 > > @@ -4544,8 +4545,7 @@ i40e_flow_parse_rss_pattern(__rte_unused > struct > > rte_eth_dev *dev, if > > (i40e_match_pattern(i40e_rss_pctype_patterns[i].item_array, > > items)) { > > p_info->types =3D i40e_rss_pctype_patterns[i].type; -rte_free(items); > > -return 0; > > +break; > > } > > } > > > > @@ -4580,11 +4580,9 @@ i40e_flow_parse_rss_pattern(__rte_unused > > struct rte_eth_dev *dev, > > } > > break; > > default: > > -rte_flow_error_set(error, EINVAL, > > -RTE_FLOW_ERROR_TYPE_ITEM, > > -item, > > -"Not support range"); > > -return -rte_errno; > > +p_info->action_flag =3D 0; > > +memset(info, 0, sizeof(struct i40e_queue_regions)); return 0; > > } > > } > > > > @@ -4640,7 +4638,7 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > > *dev, return -rte_errno; } > > > > -if (p_info.action_flag) { > > +if (p_info.action_flag && rss->queue_num) { > > for (n =3D 0; n < 64; n++) { > > if (rss->types & (hf_bit << n)) { > > conf_info->region[0].hw_flowtype[0] =3D n; > > -- > > 2.17.1 >=20 > Are the above changes relating to L2-payload? >=20 Yes, in order to resolve the conflict between hash enable and queue region = which caused by ether pattern, there are also a little bit changes for queu= e region. Thanks. Shougang