From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E704FA0A03; Tue, 19 Jan 2021 09:06:12 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C14A140CEA; Tue, 19 Jan 2021 09:06:12 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id E502E140CA3 for ; Tue, 19 Jan 2021 09:06:08 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8F90B7F4E3; Tue, 19 Jan 2021 11:06:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8F90B7F4E3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1611043568; bh=1eDwJ+b++r0+IIkIqxUH9eLd2ke5fP3Ufe05XY9ElsY=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=FCTiPTZbsvcuZl1PpnM42ylfdchc/lPzLDBprO28ucUPqNlLToS4vKJIMAEpAkazH MyAIDszGMSrhWZ45aKiaov/EuGws+z6z+cd617fWVjFT8S8F8XkHZHjInbqBMlMnCe FLBtjHDooofEqhif5jSSTtPWgc0kZe6FyPLkZsug= To: Xueming Li Cc: dev@dpdk.org, Viacheslav Ovsiienko , Asaf Penso , Thomas Monjalon , Ferruh Yigit References: <1611040501-11666-1-git-send-email-xuemingl@nvidia.com> <1611040501-11666-8-git-send-email-xuemingl@nvidia.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <8edbba36-ab2f-f07a-0133-246afe36d0a3@oktetlabs.ru> Date: Tue, 19 Jan 2021 11:06:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <1611040501-11666-8-git-send-email-xuemingl@nvidia.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v5 8/9] ethdev: add capability of sub-function representor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/19/21 10:15 AM, Xueming Li wrote: > Old DPDK version or some drivers didn't support SubFunction representor. > For application to adapt different DPDK version automatically, or to be > used for different NICs, this patch introduces new eth device capability > of supporting SubFunction representor device. Sorry, it does not sound sufficient motivation to introduce the capability. I simply need real life example why application need to know it. > Signed-off-by: Xueming Li > Acked-by: Viacheslav Ovsiienko > Acked-by: Thomas Monjalon > --- > lib/librte_ethdev/rte_ethdev.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 2cbce958cf..da65adf1ab 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1433,6 +1433,8 @@ struct rte_eth_conf { > #define RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP 0x00000001 > /** Device supports Tx queue setup after device started. */ > #define RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP 0x00000002 > +/** Device supports SubFunction representor. */ > +#define RTE_ETH_DEV_CAPA_REPRESENTOR_SF 0x00000004 Will we have a PMD which supports it in the release cycle? > /**@}*/ > > /*