From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <jia.guo@intel.com>
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
by dpdk.org (Postfix) with ESMTP id 1F9445F30
for <dev@dpdk.org>; Thu, 4 Oct 2018 04:56:59 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga008.fm.intel.com ([10.253.24.58])
by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
03 Oct 2018 19:56:59 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.54,338,1534834800"; d="scan'208";a="76047615"
Received: from jguo15x-mobl.ccr.corp.intel.com (HELO [10.249.174.2])
([10.249.174.2])
by fmsmga008.fm.intel.com with ESMTP; 03 Oct 2018 19:56:23 -0700
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"stephen@networkplumber.org" <stephen@networkplumber.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"gaetan.rivet@6wind.com" <gaetan.rivet@6wind.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"motih@mellanox.com" <motih@mellanox.com>,
"matan@mellanox.com" <matan@mellanox.com>,
"Van Haaren, Harry" <harry.van.haaren@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>, "He, Shaopeng"
<shaopeng.he@intel.com>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Cc: "jblunck@infradead.org" <jblunck@infradead.org>,
"shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Zhang, Helin" <helin.zhang@intel.com>
References: <1498711073-42917-1-git-send-email-jia.guo@intel.com>
<1538483726-96411-1-git-send-email-jia.guo@intel.com>
<1538483726-96411-8-git-send-email-jia.guo@intel.com>
<8CEF83825BEC744B83065625E567D7C260D0BB7F@IRSMSX107.ger.corp.intel.com>
From: Jeff Guo <jia.guo@intel.com>
Message-ID: <8ee966e4-ffdd-52a1-80f2-6a21fa43e828@intel.com>
Date: Thu, 4 Oct 2018 10:56:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
Thunderbird/60.0
MIME-Version: 1.0
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D0BB7F@IRSMSX107.ger.corp.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH v12 7/7] testpmd: use hot-unplug failure
handle mechanism
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Oct 2018 02:57:00 -0000
hi, bernard
thanks for your review, comment as below.
On 10/2/2018 11:21 PM, Iremonger, Bernard wrote:
> Hi Jeff,
>
> <snip>
>
>> Subject: [PATCH v12 7/7] testpmd: use hot-unplug failure handle mechanism
> ./devtools/check-git-log.sh -1
> Wrong headline label:
> testpmd: use hot-unplug failure handle mechanism
>
ok, let me check it.
>> This patch use testpmd for example, to show how an app smoothly handle
>> failure when device be hot-unplug. Except app should enabled the device event
>> monitor and register the hotplug event’s callback, it also need enable hotplug
>> handle mechanism before running. Once app detect the removal event, the hot-
>> unplug callback would be called. It will first stop the packet forwarding, then
>> stop the port, close the port, and finally detach the port to clean the device and
>> release the resources.
>>
>> Signed-off-by: Jeff Guo <jia.guo@intel.com>
>> ---
>> v12->v11:
>> no change.
>> ---
>> app/test-pmd/testpmd.c | 39 +++++++++++++++++++++++++++++++--------
>> 1 file changed, 31 insertions(+), 8 deletions(-)
>>
>> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
>> 001f0e5..bfef483 100644
>> --- a/app/test-pmd/testpmd.c
>> +++ b/app/test-pmd/testpmd.c
>> @@ -2093,14 +2093,22 @@ pmd_test_exit(void)
>>
>> if (hot_plug) {
>> ret = rte_dev_event_monitor_stop();
>> - if (ret)
>> + if (ret) {
>> RTE_LOG(ERR, EAL,
>> "fail to stop device event monitor.");
>> + return;
>> + }
>>
>> ret = eth_dev_event_callback_unregister();
>> if (ret)
> Should there be an RTE_LOG() call here?
ok, in order to make it more clean, no need to add help here.
>> + return;
>> +
>> + ret = rte_dev_hotplug_handle_disable();
>> + if (ret) {
>> RTE_LOG(ERR, EAL,
>> - "fail to unregister all event callbacks.");
>> + "fail to disable hotplug handling.");
>> + return;
>> + }
>> }
>>
>> printf("\nBye...\n");
>> @@ -2244,6 +2252,9 @@ static void
>> eth_dev_event_callback(char *device_name, enum rte_dev_event_type type,
>> __rte_unused void *arg)
>> {
>> + uint16_t port_id;
>> + int ret;
>> +
>> if (type >= RTE_DEV_EVENT_MAX) {
>> fprintf(stderr, "%s called upon invalid event %d\n",
>> __func__, type);
>> @@ -2254,9 +2265,12 @@ eth_dev_event_callback(char *device_name, enum
>> rte_dev_event_type type,
>> case RTE_DEV_EVENT_REMOVE:
>> RTE_LOG(ERR, EAL, "The device: %s has been removed!\n",
>> device_name);
>> - /* TODO: After finish failure handle, begin to stop
>> - * packet forward, stop port, close port, detach port.
>> - */
>> + ret = rte_eth_dev_get_port_by_name(device_name, &port_id);
>> + if (ret) {
>> + printf("can not get port by device %s!\n",
>> device_name);
> It would be better to use an RTE_LOG() call here instead of printf().
ok.
>> + return;
>> + }
>> + rmv_event_callback((void *)(intptr_t)port_id);
>> break;
>> case RTE_DEV_EVENT_ADD:
>> RTE_LOG(ERR, EAL, "The device: %s has been added!\n", @@ -
>> 2779,14 +2793,23 @@ main(int argc, char** argv)
>> init_config();
>>
>> if (hot_plug) {
>> - /* enable hot plug monitoring */
>> + ret = rte_dev_hotplug_handle_enable();
>> + if (ret) {
>> + RTE_LOG(ERR, EAL,
>> + "fail to enable hotplug handling.");
>> + return -1;
>> + }
>> +
>> ret = rte_dev_event_monitor_start();
>> if (ret) {
>> - rte_errno = EINVAL;
>> + RTE_LOG(ERR, EAL,
>> + "fail to start device event monitoring.");
>> return -1;
>> }
>> - eth_dev_event_callback_register();
>>
>> + ret = eth_dev_event_callback_register();
>> + if (ret)
> Should there be an RTE_LOG() call here?
please see above answer.
>> + return -1;
>> }
>>
>> if (start_port(RTE_PORT_ALL) != 0)
>> --
>> 2.7.4
> Regards,
>
> Bernard.