From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: David Marchand <david.marchand@redhat.com>, dev@dpdk.org
Cc: Chenbo Xia <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH] vhost: rework RARP packet injection
Date: Tue, 28 Sep 2021 21:23:44 +0200 [thread overview]
Message-ID: <8eebb8e8-aa28-a18e-d2c4-76b0b788ebc5@redhat.com> (raw)
In-Reply-To: <86cd730e-6573-7e04-5c01-7726e0b02e2a@redhat.com>
On 9/28/21 17:32, Maxime Coquelin wrote:
>
>
> On 9/15/21 16:54, David Marchand wrote:
>> Caught by code review, this copy is unnecessary.
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>> ---
>> lib/vhost/virtio_net.c | 11 +++--------
>> 1 file changed, 3 insertions(+), 8 deletions(-)
>>
>
> Applied to dpdk-next-virtio/main.
>
> Thanks,
> Maxime
>
As you suggested on IRC, I added back the comment that got removed:
@@ -3136,6 +3136,12 @@ rte_vhost_dequeue_burst(int vid, uint16_t queue_id,
count = 0;
goto out;
}
+ /*
+ * Inject it to the head of "pkts" array, so that
switch's mac
+ * learning table will get updated first.
+ */
+ pkts[0] = rarp_mbuf;
+ pkts++;
count -= 1;
}
Regards,
Maxime
prev parent reply other threads:[~2021-09-28 19:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 14:54 David Marchand
2021-09-15 19:51 ` Maxime Coquelin
2021-09-16 1:40 ` Xia, Chenbo
2021-09-28 15:32 ` Maxime Coquelin
2021-09-28 19:23 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8eebb8e8-aa28-a18e-d2c4-76b0b788ebc5@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).